public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] Fix racy output matching in gdb.base/memattr.exp
Date: Fri, 10 Nov 2017 00:28:00 -0000	[thread overview]
Message-ID: <2c88253fc469fbf40be7f0d1f7060b81055f2eb1@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 2c88253fc469fbf40be7f0d1f7060b81055f2eb1 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 2c88253fc469fbf40be7f0d1f7060b81055f2eb1

Fix racy output matching in gdb.base/memattr.exp

Testing with:
 $ make check-read1 TESTS="gdb.base/memattr.exp"


Exposes a testcase bug that can result in racy fails:

  info mem
  Using user-defined memory regions.
  Num Enb Low Addr           High Addr          Attrs
  1   y   0x0000000000601060 0x0000000000601160 wo nocache
  2   y   0x0000000000601180 0x0000000000601280 ro nocache
  4   y   0x0000000000601280 0x0000000000601380 rw nocache
  3   y   0x0000000000601380 0x0000000000601480 rw nocache
  5   y   0x0000000000601480 0x0000000000601580 rw nocache
  (gdb) FAIL: gdb.base/memattr.exp: info mem (1)

The problem is that:

  "Attrs\[^\n\r]*.."

matches:

  "Attrs \r"

when the output buffer is filled with partial output like this:

  "info mem\r\nUsing user-defined memory regions.\r\nNum Enb Low Addr           High Addr          Attrs \r"

gdb/testsuite/ChangeLog:
2017-11-09  Pedro Alves  <palves@redhat.com>

	* gdb.base/memattr.exp: Tighten regexes to match the end line.


             reply	other threads:[~2017-11-10  0:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-10  0:28 sergiodj+buildbot [this message]
2017-11-10  0:28 ` Failures on Fedora-s390x-m64, branch master sergiodj+buildbot
2017-11-10  0:29 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2017-11-10  0:37 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
2017-11-10  1:13 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2017-11-10  1:25 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, " sergiodj+buildbot
2017-11-10  1:30 ` Failures on Fedora-i686, " sergiodj+buildbot
2017-11-10  1:54 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot
2017-11-10  5:52 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot
2017-11-10  6:17 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2017-11-10  6:41 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c88253fc469fbf40be7f0d1f7060b81055f2eb1@gdb-build \
    --to=sergiodj+buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).