public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] Fix stripping relocs in a file with mergeable notes.
Date: Fri, 08 Dec 2017 10:27:00 -0000	[thread overview]
Message-ID: <2d054e6bfdfb0f58fb9cc501c29327df34fec697@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 2d054e6bfdfb0f58fb9cc501c29327df34fec697 ***

Author: Nick Clifton <nickc@redhat.com>
Branch: master
Commit: 2d054e6bfdfb0f58fb9cc501c29327df34fec697

Fix stripping relocs in a file with mergeable notes.

  A recent Fedora bug (1520805) exposed a problem with objcopy's reloc
  copying code, when a binary also contains mergeable notes.  The note
  merging code would delete some relocs, but then the reloc copying code
  would try to put them back again, which did not work.

  So I am checking in the patch below to fix the problem.  The patch
  also tweaks one of the binutils note merging tests so that it is
  skipped for the Sparc64 target, since this has funky relocs.

binutils	* objcopy.c (copy_relocations_in_section): Use the orelocations
	field of the input section, if it has been initialised.
	* testsuite/binutils-all/note-2-64.d: Skip test on Sparc64.

bfd	* elfcode.h (elf_write_relocs): Check for an empty howto field.


             reply	other threads:[~2017-12-08 10:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-08 10:27 sergiodj+buildbot [this message]
2017-12-08 10:27 ` Failures on Fedora-x86_64-native-gdbserver-m32, branch master sergiodj+buildbot
2017-12-08 10:43 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2017-12-08 10:45 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2017-12-08 10:57 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot
2017-12-08 10:57 ` Failures on Fedora-i686, " sergiodj+buildbot
2017-12-08 11:00 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2017-12-08 11:04 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2017-12-08 11:10 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot
2017-12-08 11:16 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot
2017-12-08 11:18 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d054e6bfdfb0f58fb9cc501c29327df34fec697@gdb-build \
    --to=sergiodj+buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).