From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id 550B63858D1E for ; Wed, 13 Mar 2024 05:50:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 550B63858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 550B63858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710309014; cv=none; b=pwv+KON1AHSCMCYZLlAhir95KC4+iiF7RMB+4pSn15wBzc6B0X8x5KkwgobnuQFJx4PCO7btRcJzAWs4sneYVHGW59hx0f1WHN6KqcOXig1KiVDcHXWB5Jlq0WUFRUgerLkqUIMFgXdTIJYZKnQNhw2Xgq9JwlnEknWC84SMwgw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710309014; c=relaxed/simple; bh=D4kIi/hXj2pEp9j9ImYK05Lo45Ys/I3fRPrgIYLm0AI=; h=DKIM-Signature:Mime-Version:Subject:From:Date:Message-Id:To; b=alospz7d0clCLCtBEYNSDx19B+cKiBS7939eXYwPQ2F+TGukMtARrcg3PprfBWbbctCGjTI0wwNL1AHoiJbui8aZwu+Z0Vqisg0IP/wQzBdUJF2meYTJD3Bsj6012G3b0Ztift48YskGFA13+WxAdwZcIHakorfE0+wQdkxrTcY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-5686dc3415cso705357a12.0 for ; Tue, 12 Mar 2024 22:50:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710309011; x=1710913811; darn=sourceware.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7q+WXisL48UPJ67GiBYcHZH3dc0VNrt9mNaqBA0EQv4=; b=tACllXL7dzf5ksJg99osktsGict08iqhizjFPWirXezXQgAbNkKNYRhz0Lnhe8wbg8 DnPVJNWhK/D3gsPLLVRD6XIlgDu8KFdit3L3CclXK7sGDm+6bzYhKxQGDBs4sST5oms1 yxFzw+Ld6rzpXWG2tN8E0CQ5s0XJig5xSv16x33dcv3no7Ev7qbbOiYVXyA6T7JMMsul YwogrQdS+usimq1RkOFPNkzQnjoXswEduRqPUQmyl76A0bWjPvZu1ip5ybbxCVRrU3dT fMT2lbvFzKKrrffzB8aYKI1bmlW9KT8K+w3NKdXiYUwhqHHCe0QmizLZsPhPHPKoaZEe 0bFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710309011; x=1710913811; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7q+WXisL48UPJ67GiBYcHZH3dc0VNrt9mNaqBA0EQv4=; b=PYsem303LHBTj2NL/xRQaZbid1T9E1zb0Vzb7yqpenH4rh2sZtekI0fsTkoO+Ubwbs YgFyUMRFIWi0b2iCiircQwYaz7lVlm8+jV2P+FXvV1JmzAyfpqnYbOkkJlqDLyTeQEZm z6qZTul1wOW8D7I2cRvuGuLmleCigCT1p5eJAfP2XqMsUyBsxisq1iDj4EgLfthMgUcd iu6AX/c1JEeHCRxaxPk9fsfm7NyICGmP4yyf0O/16VwAkbxBprLMuyP2UmDWUHSajd6v ZkoqtriZ0IoIEESX45M8qLkfyjDnM+Vq2qnH6ILKtrfTGdVh4scKL1VDSZhf1fHue7GO yECQ== X-Forwarded-Encrypted: i=1; AJvYcCXVKnNTpLqxRrNLF2DjFvoSrxUjF7pJlIL4lvSO6pQbwV9QsJqJ9mv7fvpi8f9skCUihn2B2h0a3Qbri5ifEmLQYLegmSX0kuDkcg== X-Gm-Message-State: AOJu0Yza0EyIO6rCrXA6nP0X84eA+3OORyN2Rpd4Ksk7WPnp9zxXt0B9 ypLBpiUgWQ6bj3Fe8L0q+Zi4MkrfOOsWjVcGrfXxgHyHVdrpi2sdijbn1XmNbw== X-Google-Smtp-Source: AGHT+IEi9NzbctbJf+3PaFFvBEmJ6vuCbpkXSSBOfUBS99sQhgfXiV2uhtQ1NrS0XjQ5YtvHqL0LPA== X-Received: by 2002:a17:907:78d6:b0:a46:3413:bbd3 with SMTP id kv22-20020a17090778d600b00a463413bbd3mr537432ejc.3.1710309010920; Tue, 12 Mar 2024 22:50:10 -0700 (PDT) Received: from smtpclient.apple ([37.252.94.180]) by smtp.gmail.com with ESMTPSA id n20-20020a1709061d1400b00a43fe2d3062sm4484753ejh.158.2024.03.12.22.50.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Mar 2024 22:50:09 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.300.61.1.2\)) Subject: Re: [Linaro-TCWG-CI] gdb-14-branchpoint-1411-g033bc67bdb0: FAIL: 2 regressions on arm From: Maxim Kuvyrkov In-Reply-To: Date: Wed, 13 Mar 2024 09:49:57 +0400 Cc: tom@tromey.com, gdb-testers@sourceware.org, Linaro Toolchain Working Group Content-Transfer-Encoding: quoted-printable Message-Id: <30E33AC9-E689-4BD9-B862-9A1F4C018A72@linaro.org> References: <578038658.1014.1706641415312@jenkins.jenkins> <74C444DC-7CEE-408D-822A-2DD63CF93C32@linaro.org> To: Jonathan Wakely X-Mailer: Apple Mail (2.3774.300.61.1.2) X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_ABUSEAT,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On Mar 11, 2024, at 20:52, Jonathan Wakely wrote: >=20 > On Mon, 11 Mar 2024 at 16:38, Maxim Kuvyrkov = wrote: >>=20 >>> On Jan 30, 2024, at 23:03, ci_notify@linaro.org wrote: >>>=20 >>> Dear contributor, our automatic CI has detected problems related to = your patch(es). Please find some details below. If you have any = questions, please follow up on linaro-toolchain@lists.linaro.org mailing = list, Libera's #linaro-tcwg channel, or ping your favourite Linaro = toolchain developer on the usual project channel. >>>=20 >>> We appreciate that it might be difficult to find the necessary logs = or reproduce the issue locally. If you can't get what you need from our = CI within minutes, let us know and we will be happy to help. >>>=20 >>> We track this report status in = https://linaro.atlassian.net/browse/GNU-1136 , please let us know if you = are looking at the problem and/or when you have a fix. >>>=20 >>> In master-arm after: >>>=20 >>> | commit gdb-14-branchpoint-1411-g033bc67bdb0 >>> | Author: Tom Tromey >>> | Date: Tue Sep 19 17:39:31 2023 -0600 >>> | >>> | Only search types in cp_lookup_rtti_type >>> | >>> | This changes cp_lookup_rtti_type to only search for types -- = not >>> | functions or variables. Due to the symbol-matching hack, this = could >>> | just use SEARCH_TYPE_DOMAIN, but I think it's better to be = clear; also >>> | I hold on to some hope that perhaps the hack can someday be = removed. >>>=20 >>> FAIL: 2 regressions >>>=20 >>> regressions.sum: >>> =3D=3D=3D libstdc++ tests =3D=3D=3D >>>=20 >>> Running libstdc++:libstdc++-prettyprinters/prettyprinters.exp ... >>> FAIL: libstdc++-prettyprinters/cxx11.cc print ecmiaow >>> FAIL: libstdc++-prettyprinters/cxx11.cc print emiaow >>=20 >> Hi Tom, >> Hi Jonathan, >>=20 >> After the above GDB patch I see 2 new failures both for = aarch64-linux-gnu and arm-linux-gnueabihf in GCC's libstdc++ testsuite. = The log [1] says: >> =3D=3D=3D >> $35 =3D warning: RTTI symbol not found for class 'main::custom_cat' >> warning: RTTI symbol not found for class 'main::custom_cat' >> got: $35 =3D warning: RTTI symbol not found for class = 'main::custom_cat' >> FAIL: libstdc++-prettyprinters/cxx11.cc print emiaow >> skipping: warning: RTTI symbol not found for class 'main::custom_cat' >> std::error_code =3D {std::_V2::error_category: 42} >> skipping: std::error_code =3D {std::_V2::error_category: 42} >> $36 =3D warning: RTTI symbol not found for class 'main::custom_cat' >> warning: RTTI symbol not found for class 'main::custom_cat' >> got: $36 =3D warning: RTTI symbol not found for class = 'main::custom_cat' >> FAIL: libstdc++-prettyprinters/cxx11.cc print ecmiaow >> =3D=3D=3D >>=20 >> Which way should I dig -- GDB or libstdc++? Does this look like = libstdc++ testcase needs an update? >=20 >=20 > Just a guess, but maybe making the type global instead of a local type > (with no linkage) will solve it: >=20 > --- a/libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx11.cc > +++ b/libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx11.cc > @@ -63,6 +63,11 @@ struct datum >=20 > std::unique_ptr global; >=20 > +struct custom_cat : std::error_category { > + const char* name() const noexcept { return "miaow"; } > + std::string message(int) const { return ""; } > +}; > + > int > main() > { > @@ -179,10 +184,7 @@ main() > std::error_condition ecinval =3D > std::make_error_condition(std::errc::invalid_argument); > // { dg-final { note-test ecinval {std::error_condition =3D > {"generic": EINVAL}} } } >=20 > - struct custom_cat : std::error_category { > - const char* name() const noexcept { return "miaow"; } > - std::string message(int) const { return ""; } > - } cat; > + custom_cat cat; > std::error_code emiaow(42, cat); > // { dg-final { note-test emiaow {std::error_code =3D {custom_cat: = 42}} } } > std::error_condition ecmiaow(42, cat); >=20 >=20 > If this works, I think this change to the test is reasonable. A local > type as an error_category probably doesn't make sense in real code. >=20 > But I don't know if this is revealing some issue with Tom's patch and > how it handles local types (or any types without linkage). Hi Jonathan, Your above change to cxx11.cc fixes the failures [1]. = Would you please commit it? Thanks! [1] = https://ci.linaro.org/job/tcwg_gnu_native_check_gcc--master-aarch64-precom= mit/1/artifact/artifacts/artifacts.precommit/notify/mail-body.txt/*view*/ -- Maxim Kuvyrkov https://www.linaro.org