public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] [gdb/testsuite] Use string_to_regexp on core filename in gdb_core_cmd
@ 2020-03-21  3:19 gdb-buildbot
  2020-03-21  3:19 ` Failures on Fedora-i686, branch master gdb-buildbot
                   ` (9 more replies)
  0 siblings, 10 replies; 11+ messages in thread
From: gdb-buildbot @ 2020-03-21  3:19 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3217502e1ba7409676e192100a0147a49dd5ae7a ***

commit 3217502e1ba7409676e192100a0147a49dd5ae7a
Author:     Tom de Vries <tdevries@suse.de>
AuthorDate: Thu Mar 12 11:03:07 2020 +0100
Commit:     Tom de Vries <tdevries@suse.de>
CommitDate: Thu Mar 12 11:03:07 2020 +0100

    [gdb/testsuite] Use string_to_regexp on core filename in gdb_core_cmd
    
    In commit 1281424ccf "[gdb/testsuite] Fix core file load FAIL in
    tls-core.exp", I've made this change:
    ...
    -       -re ": No such file or directory.*\r\n$gdb_prompt $" {
    +       -re "$core: No such file or directory.*\r\n$gdb_prompt $" {
    ...
    
    However, the $core variable contains a filename which needs to be matched
    as a literal string, not as a regexp.
    
    Fix this by using string_to_regexp.
    
    Tested on x86_64-linux.
    
    gdb/testsuite/ChangeLog:
    
    2020-03-12  Tom de Vries  <tdevries@suse.de>
    
            * lib/gdb.exp (gdb_core_cmd): Use string_to_regexp for regexp-matching
            $core.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 3d829b021f..77b3695b9a 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2020-03-12  Tom de Vries  <tdevries@suse.de>
+
+	* lib/gdb.exp (gdb_core_cmd): Use string_to_regexp for regexp-matching
+	$core.
+
 2020-03-12  Tom de Vries  <tdevries@suse.de>
 
 	* lib/gdb.exp (gdb_core_cmd): Make "No such file or directory" regexp
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index bb70ef13f2..ae2d810a1e 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -4648,7 +4648,7 @@ proc gdb_core_cmd { core test } {
 	    fail "$test (bad file format)"
 	    return -1
 	}
-	-re "$core: No such file or directory.*\r\n$gdb_prompt $" {
+	-re -wrap "[string_to_regexp $core]: No such file or directory.*" {
 	    fail "$test (file not found)"
 	    return -1
 	}


^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-03-24  3:28 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-21  3:19 [binutils-gdb] [gdb/testsuite] Use string_to_regexp on core filename in gdb_core_cmd gdb-buildbot
2020-03-21  3:19 ` Failures on Fedora-i686, branch master gdb-buildbot
2020-03-21  3:53 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2020-03-21  4:00 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2020-03-21  4:24 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2020-03-21  4:42 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2020-03-21  5:05 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2020-03-23 11:14 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
2020-03-23 22:18 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, " gdb-buildbot
2020-03-24  0:07 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, " gdb-buildbot
2020-03-24  3:28 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).