[binutils-gdb] Replace bsearch with a std::lower_bound-based search

[binutils-gdb] Replace bsearch with a std::lower_bound-based search

[gdb-buildbot]

*** TEST RESULTS FOR COMMIT 35e65c49df7d8fac3c0a32fa0d696988a9de675d ***

commit 35e65c49df7d8fac3c0a32fa0d696988a9de675d
Author:     Christian Biesinger <cbiesinger@google.com>
AuthorDate: Mon Oct 21 13:08:03 2019 -0500
Commit:     Christian Biesinger <cbiesinger@google.com>
CommitDate: Tue Oct 29 14:06:26 2019 -0500

    Replace bsearch with a std::lower_bound-based search
    
    This is more type-safe and can be faster due to inlining and
    avoiding overhead from calling through a function pointer.
    
    gdb/ChangeLog:
    
    2019-10-29  Christian Biesinger  <cbiesinger@google.com>
    
            * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
            * dwarf2-frame.c (bsearch_fde_cmp): Update.
            (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
            * gdbsupport/gdb_binary_search.h: New file.
    
    Change-Id: I07e0a0e333f4062b27fc68d3a3f24881ebc68fd4

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5cf1ae71af..c96b61a07e 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2019-10-29  Christian Biesinger  <cbiesinger@google.com>
+
+	* Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
+	* dwarf2-frame.c (bsearch_fde_cmp): Update.
+	(dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
+	* gdbsupport/gdb_binary_search.h: New file.
+
 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
 
 	* NEWS: Mention new --with-system-gdbinit-dir option.
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index c9243731aa..4f431c3c84 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -1469,6 +1469,7 @@ HFILES_NO_SRCDIR = \
 	gdbsupport/format.h \
 	gdbsupport/gdb-dlfcn.h \
 	gdbsupport/gdb_assert.h \
+	gdbsupport/gdb_binary_search.h \
 	gdbsupport/gdb_tilde_expand.h \
 	gdbsupport/gdb_locale.h \
 	gdbsupport/gdb_proc_service.h \
diff --git a/gdb/dwarf2-frame.c b/gdb/dwarf2-frame.c
index c41db791dc..719e06570d 100644
--- a/gdb/dwarf2-frame.c
+++ b/gdb/dwarf2-frame.c
@@ -39,6 +39,7 @@
 #include "ax.h"
 #include "dwarf2loc.h"
 #include "dwarf2-frame-tailcall.h"
+#include "gdbsupport/gdb_binary_search.h"
 #if GDB_SELF_TEST
 #include "gdbsupport/selftest.h"
 #include "selftest-arch.h"
@@ -1652,15 +1653,12 @@ find_cie (const dwarf2_cie_table &cie_table, ULONGEST cie_pointer)
   return NULL;
 }
 
-static int
-bsearch_fde_cmp (const void *key, const void *element)
+static inline int
+bsearch_fde_cmp (const dwarf2_fde *fde, CORE_ADDR seek_pc)
 {
-  CORE_ADDR seek_pc = *(CORE_ADDR *) key;
-  struct dwarf2_fde *fde = *(struct dwarf2_fde **) element;
-
-  if (seek_pc < fde->initial_location)
+  if (fde->initial_location + fde->address_range <= seek_pc)
     return -1;
-  if (seek_pc < fde->initial_location + fde->address_range)
+  if (fde->initial_location <= seek_pc)
     return 0;
   return 1;
 }
@@ -1674,7 +1672,6 @@ dwarf2_frame_find_fde (CORE_ADDR *pc, CORE_ADDR *out_offset)
   for (objfile *objfile : current_program_space->objfiles ())
     {
       struct dwarf2_fde_table *fde_table;
-      struct dwarf2_fde **p_fde;
       CORE_ADDR offset;
       CORE_ADDR seek_pc;
 
@@ -1697,15 +1694,14 @@ dwarf2_frame_find_fde (CORE_ADDR *pc, CORE_ADDR *out_offset)
         continue;
 
       seek_pc = *pc - offset;
-      p_fde = ((struct dwarf2_fde **)
-	       bsearch (&seek_pc, fde_table->entries, fde_table->num_entries,
-                        sizeof (fde_table->entries[0]), bsearch_fde_cmp));
-      if (p_fde != NULL)
+      auto end = fde_table->entries + fde_table->num_entries;
+      auto it = gdb::binary_search (fde_table->entries, end, seek_pc, bsearch_fde_cmp);
+      if (it != end)
         {
-          *pc = (*p_fde)->initial_location + offset;
+          *pc = (*it)->initial_location + offset;
 	  if (out_offset)
 	    *out_offset = offset;
-          return *p_fde;
+          return *it;
         }
     }
   return NULL;
diff --git a/gdb/gdbsupport/gdb_binary_search.h b/gdb/gdbsupport/gdb_binary_search.h
new file mode 100644
index 0000000000..0cb429e820
--- /dev/null
+++ b/gdb/gdbsupport/gdb_binary_search.h
@@ -0,0 +1,59 @@
+/* C++ implementation of a binary search.
+
+   Copyright (C) 2019 Free Software Foundation, Inc.
+
+   This file is part of GDB.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+
+#ifndef GDBSUPPORT_GDB_BINARY_SEARCH_H
+#define GDBSUPPORT_GDB_BINARY_SEARCH_H
+
+#include <algorithm>
+
+namespace gdb {
+
+/* Implements a binary search using C++ iterators.
+   This differs from std::binary_search in that it returns an interator for
+   the found element and in that the type of EL can be different from the
+   type of the elements in the countainer.
+
+   COMP is a C-style comparison function with signature:
+   int comp(const value_type& a, const T& b);
+   It should return -1, 0 or 1 if a is less than, equal to, or greater than
+   b, respectively.
+   [first, last) must be sorted.
+
+   The return value is an iterator pointing to the found element, or LAST if
+   no element was found.  */
+template<typename It, typename T, typename Comp>
+It binary_search (It first, It last, T el, Comp comp)
+{
+  auto lt = [&] (const typename std::iterator_traits<It>::value_type &a,
+		 const T &b)
+    { return comp (a, b) < 0; };
+
+  auto lb = std::lower_bound (first, last, el, lt);
+  if (lb != last)
+    {
+      if (comp (*lb, el) == 0)
+	return lb;
+    }
+  return last;
+}
+
+} /* namespace gdb */
+
+#endif /* GDBSUPPORT_GDB_BINARY_SEARCH_H */

Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Ubuntu-Aarch64-native-extended-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/5/builds/1051

Author:
        Christian Biesinger <cbiesinger@google.com>

Commit tested:
        35e65c49df7d8fac3c0a32fa0d696988a9de675d

Subject of commit:
        Replace bsearch with a std::lower_bound-based search

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/35/35e65c49df7d8fac3c0a32fa0d696988a9de675d/

*** Diff to previous build ***
==============================================
new KFAIL: gdb.xml/tdesc-arch.exp: set tdesc filename tdesc-arch.xml
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/35/35e65c49df7d8fac3c0a32fa0d696988a9de675d//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/35/35e65c49df7d8fac3c0a32fa0d696988a9de675d//xfail.table.gz>

Failures on Fedora-x86_64-cc-with-index, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-cc-with-index

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/20/builds/1143

Author:
        Christian Biesinger <cbiesinger@google.com>

Commit tested:
        35e65c49df7d8fac3c0a32fa0d696988a9de675d

Subject of commit:
        Replace bsearch with a std::lower_bound-based search

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/35/35e65c49df7d8fac3c0a32fa0d696988a9de675d/

*** Diff to previous build ***
==============================================
new KFAIL: gdb.ada/bad-task-bp-keyword.exp: break *break_me'address TASK Task TaSK 2
new FAIL: gdb.ada/interface.exp: print s
new FAIL: gdb.ada/iwide.exp: print My_Drawable
new FAIL: gdb.ada/iwide.exp: print d_access.all
new FAIL: gdb.ada/iwide.exp: print dp_access.all
new FAIL: gdb.ada/iwide.exp: print s_access.all
new FAIL: gdb.ada/iwide.exp: print sp_access.all
new FAIL: gdb.ada/mi_interface.exp: create ggg1 varobj
new FAIL: gdb.ada/mi_interface.exp: list ggg1's children
new FAIL: gdb.ada/ptype_tagged_param.exp: ptype s
new FAIL: gdb.ada/tagged.exp: print obj
new FAIL: gdb.ada/tagged.exp: ptype obj
new FAIL: gdb.ada/tagged_access.exp: ptype c.all
new FAIL: gdb.ada/tagged_access.exp: ptype c.menu_name
new KFAIL: gdb.base/argv0-symlink.exp: kept directory symbolic link name
new FAIL: gdb.base/async.exp: finish&
new FAIL: gdb.base/async.exp: nexti&
new FAIL: gdb.base/async.exp: stepi&
new FAIL: gdb.base/consecutive.exp: stopped at bp, 2nd instr
new KFAIL: gdb.base/macscp.exp: BEFORE_MACSCP1_2 defined/undefined when stopped at macscp4_1_from_macscp3
new KFAIL: gdb.base/macscp.exp: BEFORE_MACSCP1_2 defined/undefined when stopped at macscp4_2_from_macscp3
new KFAIL: gdb.base/macscp.exp: BEFORE_MACSCP2_2 defined/undefined when stopped at macscp4_1_from_macscp3
new KFAIL: gdb.base/macscp.exp: BEFORE_MACSCP2_2 defined/undefined when stopped at macscp4_2_from_macscp3
new KFAIL: gdb.base/macscp.exp: BEFORE_MACSCP3_1 defined/undefined when stopped at macscp4_1_from_macscp3
new KFAIL: gdb.base/macscp.exp: BEFORE_MACSCP3_1 defined/undefined when stopped at macscp4_2_from_macscp3
new KFAIL: gdb.base/macscp.exp: BEFORE_MACSCP4_1_FROM_MACSCP3 defined/undefined when stopped at macscp4_2_from_macscp3
new KFAIL: gdb.base/macscp.exp: BEFORE_MACSCP4_2_FROM_MACSCP2 defined/undefined when stopped at macscp4_1_from_macscp3
new KFAIL: gdb.base/macscp.exp: UNTIL_MACSCP1_2 defined/undefined when stopped at macscp4_1_from_macscp3
new KFAIL: gdb.base/macscp.exp: UNTIL_MACSCP1_2 defined/undefined when stopped at macscp4_2_from_macscp3
new KFAIL: gdb.base/macscp.exp: UNTIL_MACSCP2_2 defined/undefined when stopped at macscp4_1_from_macscp3
new KFAIL: gdb.base/macscp.exp: UNTIL_MACSCP2_2 defined/undefined when stopped at macscp4_2_from_macscp3
new KFAIL: gdb.base/macscp.exp: UNTIL_MACSCP3_1 defined/undefined when stopped at macscp4_1_from_macscp3
new KFAIL: gdb.base/macscp.exp: UNTIL_MACSCP3_1 defined/undefined when stopped at macscp4_2_from_macscp3
new KFAIL: gdb.base/macscp.exp: UNTIL_MACSCP4_1_FROM_MACSCP3 defined/undefined when stopped at macscp4_2_from_macscp3
new KFAIL: gdb.base/macscp.exp: UNTIL_MACSCP4_2_FROM_MACSCP2 defined/undefined when stopped at macscp4_1_from_macscp3
new KFAIL: gdb.base/macscp.exp: info macro WHERE after `list macscp_4_2_from_macscp3'
new KFAIL: gdb.base/macscp.exp: info macro WHERE stopped in macscp4_1_from_macscp3
new KFAIL: gdb.base/macscp.exp: info macro WHERE stopped in macscp4_2_from_macscp3
new KFAIL: gdb.base/radix.exp: print 20.; expect 14; output radix 16
new KFAIL: gdb.base/radix.exp: print 20.; expect 24; output radix 8
new FAIL: gdb.base/shlib-call.exp: step into mainshr1
new FAIL: gdb.base/shlib-call.exp: step out of shr2 epilogue to main
new KFAIL: gdb.base/sigbpt.exp: stepi bp at segv; stepi out of handler
new KFAIL: gdb.base/sigbpt.exp: stepi bp before and at segv; stepi out of handler
new KFAIL: gdb.base/sigbpt.exp: stepi bp before segv; stepi out of handler
new KFAIL: gdb.base/sigbpt.exp: stepi; stepi out of handler
new FAIL: gdb.base/skip.exp: step after disabling 3: step 3
new FAIL: gdb.base/skip.exp: step after disabling 3: step 5
new FAIL: gdb.base/skip.exp: step using -fu for baz: step 3
new FAIL: gdb.base/skip.exp: step using -fu for baz: step 5
new FAIL: gdb.base/skip.exp: step using -rfu for baz: step 3
new FAIL: gdb.base/skip.exp: step using -rfu for baz: step 5
new KFAIL: gdb.base/utf8-identifiers.exp: tab complete "break fun"
new FAIL: gdb.base/watchpoint-reuse-slot.exp: hw-watch: always-inserted off: watch x watch: : width 1, iter 0: base + 0: stepi advanced
new KFAIL: gdb.base/watchpoint-unaligned.exp: wpcount
new KFAIL: gdb.compile/compile-cplus-anonymous.exp: compile code
new KFAIL: gdb.compile/compile-cplus-anonymous.exp: compile print
new KFAIL: gdb.compile/compile-cplus-anonymous.exp: result of compile code
new FAIL: gdb.compile/compile-cplus-array-decay.exp: compile print strings
new FAIL: gdb.compile/compile-cplus-inherit.exp: compile print d.A::do_it
new FAIL: gdb.compile/compile-cplus-inherit.exp: compile print d.B::do_it
new FAIL: gdb.compile/compile-cplus-inherit.exp: compile print d.C::do_it
new FAIL: gdb.compile/compile-cplus-inherit.exp: compile print d.a_
new FAIL: gdb.compile/compile-cplus-inherit.exp: compile print d.b_
new FAIL: gdb.compile/compile-cplus-inherit.exp: compile print d.c_
new FAIL: gdb.compile/compile-cplus-inherit.exp: compile print d.d_
new FAIL: gdb.compile/compile-cplus-member.exp: compile code A::ATYPE i = 10; var = i;
new FAIL: gdb.compile/compile-cplus-member.exp: compile code A::s_private_
new FAIL: gdb.compile/compile-cplus-member.exp: compile code A::s_private_ = E_B; var = A::s_private_;
new FAIL: gdb.compile/compile-cplus-member.exp: compile code A::s_protected_
new FAIL: gdb.compile/compile-cplus-member.exp: compile code A::s_protected_ = N::NB; var = A::s_protected_;
new FAIL: gdb.compile/compile-cplus-member.exp: compile code A::s_public_
new FAIL: gdb.compile/compile-cplus-member.exp: compile code ATYPE i;
new FAIL: gdb.compile/compile-cplus-member.exp: compile code N::ANON_NE ae = N::ND; var = ae;
new FAIL: gdb.compile/compile-cplus-member.exp: compile code N::ANON_NE nse = E_A
new FAIL: gdb.compile/compile-cplus-member.exp: compile code a.*pmi
new FAIL: gdb.compile/compile-cplus-member.exp: compile code a.public_ = 2; var = a.*pmi; a.public_ = 1
new FAIL: gdb.compile/compile-cplus-member.exp: compile code a.s_public_ = E_B
new FAIL: gdb.compile/compile-cplus-member.exp: compile code g_e
new FAIL: gdb.compile/compile-cplus-member.exp: compile code get_values
new FAIL: gdb.compile/compile-cplus-member.exp: compile code myenum me = E_B; var = me;
new FAIL: gdb.compile/compile-cplus-member.exp: compile print A::s_private_
new FAIL: gdb.compile/compile-cplus-member.exp: compile print A::s_protected_
new FAIL: gdb.compile/compile-cplus-member.exp: compile print A::s_public_
new FAIL: gdb.compile/compile-cplus-member.exp: compile print a.*pmi
new FAIL: gdb.compile/compile-cplus-member.exp: compile print a.private_
new FAIL: gdb.compile/compile-cplus-member.exp: compile print a.protected_
new FAIL: gdb.compile/compile-cplus-member.exp: compile print a.public_
new FAIL: gdb.compile/compile-cplus-member.exp: compile print g_e
new FAIL: gdb.compile/compile-cplus-member.exp: compile print get_values
new FAIL: gdb.compile/compile-cplus-member.exp: result of compile code A::ATYPE i = 10; var = i;
new FAIL: gdb.compile/compile-cplus-member.exp: result of compile code A::s_private_
new FAIL: gdb.compile/compile-cplus-member.exp: result of compile code A::s_private_ = E_B; var = A::s_private_;
new FAIL: gdb.compile/compile-cplus-member.exp: result of compile code A::s_protected_
new FAIL: gdb.compile/compile-cplus-member.exp: result of compile code A::s_protected_ = N::NB; var = A::s_protected_;
new FAIL: gdb.compile/compile-cplus-member.exp: result of compile code A::s_public_
new FAIL: gdb.compile/compile-cplus-member.exp: result of compile code N::ANON_NE ae = N::ND; var = ae;
new FAIL: gdb.compile/compile-cplus-member.exp: result of compile code a.*pmi
new FAIL: gdb.compile/compile-cplus-member.exp: result of compile code a.public_ = 2; var = a.*pmi; a.public_ = 1
new FAIL: gdb.compile/compile-cplus-member.exp: result of compile code g_e
new FAIL: gdb.compile/compile-cplus-member.exp: result of compile code get_values
new FAIL: gdb.compile/compile-cplus-member.exp: result of compile code myenum me = E_B; var = me;
new FAIL: gdb.compile/compile-cplus-method.exp: compile code
new FAIL: gdb.compile/compile-cplus-method.exp: compile code A::get_1
new FAIL: gdb.compile/compile-cplus-method.exp: compile code a->get_var
new FAIL: gdb.compile/compile-cplus-method.exp: compile code a->get_var1
new FAIL: gdb.compile/compile-cplus-method.exp: compile code a->get_var2
new FAIL: gdb.compile/compile-cplus-method.exp: compile code pmf = &A::get_var1; var =
new FAIL: gdb.compile/compile-cplus-method.exp: compile print
new FAIL: gdb.compile/compile-cplus-method.exp: compile print A::get_1
new FAIL: gdb.compile/compile-cplus-method.exp: compile print A::get_2
new FAIL: gdb.compile/compile-cplus-method.exp: compile print a->get_var
new FAIL: gdb.compile/compile-cplus-method.exp: compile print a->get_var1
new FAIL: gdb.compile/compile-cplus-method.exp: compile print a->get_var2
new FAIL: gdb.compile/compile-cplus-method.exp: compile print get_value
new FAIL: gdb.compile/compile-cplus-method.exp: result of compile code
new FAIL: gdb.compile/compile-cplus-method.exp: result of compile code A::get_1
new FAIL: gdb.compile/compile-cplus-method.exp: result of compile code a->get_var
new FAIL: gdb.compile/compile-cplus-method.exp: result of compile code a->get_var1
new FAIL: gdb.compile/compile-cplus-method.exp: result of compile code a->get_var2
new FAIL: gdb.compile/compile-cplus-method.exp: result of compile code pmf = &A::get_var1; var =
new FAIL: gdb.compile/compile-cplus-namespace.exp: compile print N1::N2::N3::N4::S4::get_svar
new FAIL: gdb.compile/compile-cplus-namespace.exp: compile print N1::N2::N3::N4::S4::s4static
new FAIL: gdb.compile/compile-cplus-namespace.exp: compile print N1::N2::N3::N4::n4static
new FAIL: gdb.compile/compile-cplus-namespace.exp: compile print s4.get_var
new FAIL: gdb.compile/compile-cplus-namespace.exp: compile print s4.s4int_
new FAIL: gdb.compile/compile-cplus-nested.exp: compile print i1.a_
new FAIL: gdb.compile/compile-cplus-nested.exp: compile print i2.a_
new KFAIL: gdb.compile/compile-cplus-print.exp: compile print *vararray@3
new KFAIL: gdb.compile/compile-cplus-print.exp: compile print *vararrayp@3
new KFAIL: gdb.compile/compile-cplus-print.exp: compile print main
new FAIL: gdb.compile/compile-cplus-print.exp: compile print vararray
new FAIL: gdb.compile/compile-cplus-print.exp: compile print varint
new FAIL: gdb.compile/compile-cplus-print.exp: compile print varobject
new FAIL: gdb.compile/compile-cplus-print.exp: compile print/x 256
new FAIL: gdb.compile/compile-cplus-print.exp: print $
new FAIL: gdb.compile/compile-cplus-virtual.exp: compile code ap->doit
new FAIL: gdb.compile/compile-cplus-virtual.exp: compile code ap->doit2
new FAIL: gdb.compile/compile-cplus-virtual.exp: compile print ap->doit
new FAIL: gdb.compile/compile-cplus-virtual.exp: compile print ap->doit2
new FAIL: gdb.compile/compile-cplus-virtual.exp: compile print b.doit
new FAIL: gdb.compile/compile-cplus-virtual.exp: compile print b.doit2
new FAIL: gdb.compile/compile-cplus-virtual.exp: compile print b.doit3
new FAIL: gdb.compile/compile-cplus-virtual.exp: compile print c.doit
new FAIL: gdb.compile/compile-cplus-virtual.exp: compile print c.doit2
new FAIL: gdb.compile/compile-cplus-virtual.exp: compile print c.doit3
new FAIL: gdb.compile/compile-cplus-virtual.exp: compile print d.doit
new FAIL: gdb.compile/compile-cplus-virtual.exp: compile print d.doit2
new FAIL: gdb.compile/compile-cplus-virtual.exp: compile print d.doit3
new FAIL: gdb.compile/compile-cplus.exp: Test compile file and raw option without a filename
new FAIL: gdb.compile/compile-cplus.exp: Test compile file with unknown argument
new FAIL: gdb.compile/compile-cplus.exp: bt
new KFAIL: gdb.compile/compile-cplus.exp: call func_nodebug
new KFAIL: gdb.compile/compile-cplus.exp: call func_nodebug indirectly
new FAIL: gdb.compile/compile-cplus.exp: compile code -z
new FAIL: gdb.compile/compile-cplus.exp: compile code localvar =
new KFAIL: gdb.compile/compile-cplus.exp: expect -75
new KFAIL: gdb.compile/compile-cplus.exp: expect -76
new FAIL: gdb.compile/compile-cplus.exp: p localvar
new FAIL: gdb.compile/compile-cplus.exp: print 'compile-cplus.c'::globalshadow
new FAIL: gdb.compile/compile-cplus.exp: print globalshadow second time
new KFAIL: gdb.compile/compile-print.exp: compile print *vararray@3
new KFAIL: gdb.compile/compile-print.exp: compile print *vararrayp@3
new FAIL: gdb.compile/compile-print.exp: compile print vararray
new KPASS: gdb.cp/cpexprs.exp: p CV::m
new KFAIL: gdb.cp/local.exp: ptype InnerLocal::NestedInnerLocal
new FAIL: gdb.cp/no-dmgl-verbose.exp: setting breakpoint at 'f
new KFAIL: gdb.cp/oranking.exp: p foo0
new KFAIL: gdb.cp/oranking.exp: p foo10
new KFAIL: gdb.cp/oranking.exp: p foo11
new KFAIL: gdb.cp/oranking.exp: p foo13
new KFAIL: gdb.cp/oranking.exp: p foo14
new KFAIL: gdb.cp/oranking.exp: p foo2
new KFAIL: gdb.cp/rvalue-ref-overload.exp: rvalue reference overload
new KFAIL: gdb.cp/templates.exp: ptype fvpchar
new KFAIL: gdb.cp/virtfunc.exp: print pEe->D::vg
new FAIL: gdb.dwarf2/dup-psym.exp: info sources should contain only one reference to file1.txt
new KFAIL: gdb.dwarf2/dw2-simple-locdesc.exp: p &s.shl
new FAIL: gdb.gdb/unittest.exp: maintenance selftest
new FAIL: gdb.go/methods.exp: setting breakpoint at
new KFAIL: gdb.mi/mi-break.exp: mi-mode=main: list of breakpoints
new KFAIL: gdb.mi/mi-break.exp: mi-mode=separate: list of breakpoints
new KFAIL: gdb.mi/user-selected-context-sync.exp: mode=all-stop: test_mi_thread_select: thread 1.2 with --thread: thread-select, event on cli
new KFAIL: gdb.mi/user-selected-context-sync.exp: mode=non-stop: test_mi_thread_select: thread 1.2 with --thread: thread-select, event on cli
new KFAIL: gdb.opt/inline-cmds.exp: next to second func1
new KPASS: gdb.opt/inline-locals.exp: info locals above bar 2
new KPASS: gdb.opt/inline-locals.exp: info locals above bar 3
new KFAIL: gdb.pascal/types.exp: pt 'a simple string'
new FAIL: gdb.reverse/consecutive-precsave.exp: stopped at bp, 2nd instr
new FAIL: gdb.reverse/consecutive-reverse.exp: stopped at bp, 2nd instr
new KFAIL: gdb.reverse/getresuid-reverse.exp: continue to breakpoint: marker2
new KFAIL: gdb.reverse/recvmsg-reverse.exp: continue to breakpoint: marker2
new KFAIL: gdb.reverse/sigall-precsave.exp: run to end of main
new KFAIL: gdb.reverse/sigall-reverse.exp: sig-test-1: get signal ABRT
new KFAIL: gdb.reverse/solib-reverse.exp: run until end part one
new FAIL: gdb.reverse/step-precsave.exp: reverse next over call
new FAIL: gdb.reverse/step-precsave.exp: reverse next test 1
new FAIL: gdb.reverse/step-precsave.exp: reverse next test 2
new FAIL: gdb.reverse/step-precsave.exp: reverse step out of called fn
new FAIL: gdb.reverse/step-precsave.exp: reverse step test 1
new FAIL: gdb.reverse/step-precsave.exp: reverse step test 2
new FAIL: gdb.reverse/step-precsave.exp: reverse stepi from a function call
new KFAIL: gdb.reverse/step-precsave.exp: run to end of main
new FAIL: gdb.reverse/step-precsave.exp: simple reverse stepi
new KFAIL: gdb.reverse/until-reverse.exp: advance factorial
new FAIL: gdb.rust/generics.exp: print identity::< Hold<i32> >
new FAIL: gdb.rust/generics.exp: print identity::<Hold<i32>>
new FAIL: gdb.rust/generics.exp: print identity::<f64>
new FAIL: gdb.rust/generics.exp: print identity::<generics::Hold<i32> >
new FAIL: gdb.rust/generics.exp: print identity::<u32>
new FAIL: gdb.rust/generics.exp: ptype identity::<f64>
new FAIL: gdb.rust/generics.exp: ptype identity::<u32>
new FAIL: gdb.threads/create-fail.exp: iteration 10: run till end
new FAIL: gdb.threads/create-fail.exp: iteration 1: run till end
new FAIL: gdb.threads/create-fail.exp: iteration 2: run till end
new FAIL: gdb.threads/create-fail.exp: iteration 3: run till end
new FAIL: gdb.threads/create-fail.exp: iteration 4: run till end
new FAIL: gdb.threads/create-fail.exp: iteration 5: run till end
new FAIL: gdb.threads/create-fail.exp: iteration 6: run till end
new FAIL: gdb.threads/create-fail.exp: iteration 7: run till end
new FAIL: gdb.threads/create-fail.exp: iteration 8: run till end
new FAIL: gdb.threads/create-fail.exp: iteration 9: run till end
new FAIL: gdb.threads/fork-child-threads.exp: next over fork
new KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
new KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
new KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
new KFAIL: gdb.threads/watchthreads2.exp: gdb can drop watchpoints in multithreaded app
new KFAIL: gdb.xml/tdesc-arch.exp: set tdesc filename tdesc-arch.xml
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/35/35e65c49df7d8fac3c0a32fa0d696988a9de675d//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/35/35e65c49df7d8fac3c0a32fa0d696988a9de675d//xfail.table.gz>

Failures on Fedora-x86_64-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/17/builds/1197

Author:
        Christian Biesinger <cbiesinger@google.com>

Commit tested:
        35e65c49df7d8fac3c0a32fa0d696988a9de675d

Subject of commit:
        Replace bsearch with a std::lower_bound-based search

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/35/35e65c49df7d8fac3c0a32fa0d696988a9de675d/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/35/35e65c49df7d8fac3c0a32fa0d696988a9de675d//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/35/35e65c49df7d8fac3c0a32fa0d696988a9de675d//xfail.table.gz>

Failures on Fedora-x86_64-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/3/builds/1248

Author:
        Christian Biesinger <cbiesinger@google.com>

Commit tested:
        35e65c49df7d8fac3c0a32fa0d696988a9de675d

Subject of commit:
        Replace bsearch with a std::lower_bound-based search

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/35/35e65c49df7d8fac3c0a32fa0d696988a9de675d/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/35/35e65c49df7d8fac3c0a32fa0d696988a9de675d//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/35/35e65c49df7d8fac3c0a32fa0d696988a9de675d//xfail.table.gz>