[binutils-gdb/gdb-8.3-branch] Make TUI react to "set style enabled"

[binutils-gdb/gdb-8.3-branch] Make TUI react to "set style enabled"

[sergiodj+buildbot]

*** TEST RESULTS FOR COMMIT 3768f5bdec2ed46e7c3c07c863cebd99a5efe645 ***

Author: Tom Tromey <tromey@adacore.com>
Branch: gdb-8.3-branch
Commit: 3768f5bdec2ed46e7c3c07c863cebd99a5efe645

Make TUI react to "set style enabled"

When the user toggles "set style enabled", the TUI should react by
redrawing the source window, if necessary.  This patch implements this
behavior.

No test because the TUI is generally not tested.

This version of the patch incorporates Pedro's patch to provide a
clean way to force the TUI to update the source window's contents.

2019-03-14  Pedro Alves  <palves@redhat.com>
	    Tom Tromey  <tromey@adacore.com>

	* tui/tui-winsource.h (tui_refill_source_window): Declare.
	* tui/tui-winsource.c (tui_refill_source_window): New function,
	from...
	(tui_horizontal_source_scroll): ... here.  Move some logic.
	* cli/cli-style.c (set_style_enabled): Notify new observable.
	* tui/tui-hooks.c (tui_redisplay_source): New function.
	(tui_attach_detach_observers): Attach or detach
	tui_redisplay_source.
	* observable.h (source_styling_changed): New observable.
	* observable.c: Define source_styling_changed observable.

Failures on RHEL-s390x-m64, branch gdb-8.3-branch

[sergiodj+buildbot]

Buildslave:
	rhel-7_1-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/RHEL-s390x-m64/builds/9471>

Commit(s) tested:
	3768f5bdec2ed46e7c3c07c863cebd99a5efe645

Author(s) (in the same order as the commits):
	Tom Tromey <tromey@adacore.com>

Subject:
	Make TUI react to "set style enabled"

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/RHEL-s390x-m64/37/3768f5bdec2ed46e7c3c07c863cebd99a5efe645/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/siginfo-thread.exp: extract si_errno
new FAIL: gdb.python/python.exp: set the hook
PASS -> FAIL: gdb.python/python.exp: set the hook to default
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Debian-s390x-native-extended-gdbserver-m64, branch gdb-8.3-branch

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-native-extended-gdbserver-m64/builds/7774>

Commit(s) tested:
	3768f5bdec2ed46e7c3c07c863cebd99a5efe645

Author(s) (in the same order as the commits):
	Tom Tromey <tromey@adacore.com>

Subject:
	Make TUI react to "set style enabled"

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-native-extended-gdbserver-m64/37/3768f5bdec2ed46e7c3c07c863cebd99a5efe645/>

*** Diff to previous build ***
============================
PASS -> UNRESOLVED: gdb.dwarf2/multidictionary.exp: GDB is alive
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=12: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=13: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=2: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=3: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=5: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=6: wait for stops
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Debian-s390x-native-gdbserver-m64, branch gdb-8.3-branch

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-native-gdbserver-m64/builds/7631>

Commit(s) tested:
	3768f5bdec2ed46e7c3c07c863cebd99a5efe645

Author(s) (in the same order as the commits):
	Tom Tromey <tromey@adacore.com>

Subject:
	Make TUI react to "set style enabled"

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-native-gdbserver-m64/37/3768f5bdec2ed46e7c3c07c863cebd99a5efe645/>

*** Diff to previous build ***
============================
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=10: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=12: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=13: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=1: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=2: wait for stops
new FAIL: gdb.threads/interrupt-while-step-over.exp: displaced-stepping=off: iter=7: wait for stops
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Fedora-i686, branch gdb-8.3-branch

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/12283>

Commit(s) tested:
	3768f5bdec2ed46e7c3c07c863cebd99a5efe645

Author(s) (in the same order as the commits):
	Tom Tromey <tromey@adacore.com>

Subject:
	Make TUI react to "set style enabled"

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-i686/37/3768f5bdec2ed46e7c3c07c863cebd99a5efe645/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Fedora-x86_64-cc-with-index, branch gdb-8.3-branch

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/12197>

Commit(s) tested:
	3768f5bdec2ed46e7c3c07c863cebd99a5efe645

Author(s) (in the same order as the commits):
	Tom Tromey <tromey@adacore.com>

Subject:
	Make TUI react to "set style enabled"

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-cc-with-index/37/3768f5bdec2ed46e7c3c07c863cebd99a5efe645/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/step-over-syscall.exp: clone: displaced=off: single step over clone
PASS -> FAIL: gdb.multi/multi-term-settings.exp: inf1_how=attach: inf2_how=attach: stop with control-c
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch gdb-8.3-branch

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m64/builds/12240>

Commit(s) tested:
	3768f5bdec2ed46e7c3c07c863cebd99a5efe645

Author(s) (in the same order as the commits):
	Tom Tromey <tromey@adacore.com>

Subject:
	Make TUI react to "set style enabled"

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m64/37/3768f5bdec2ed46e7c3c07c863cebd99a5efe645/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/multi-forks.exp: run to exit 2
PASS -> FAIL: gdb.base/reread-readsym.exp: source reread-readsym.gdb 1
PASS -> FAIL: gdb.base/signals-state-child.exp: signals states are identical
PASS -> FAIL: gdb.go/strings.exp: print "abc" + "def"
UNRESOLVED -> FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: no threads left
PASS -> FAIL: gdb.threads/thread-unwindonsignal.exp: continue until exit
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Fedora-x86_64-native-gdbserver-m64, branch gdb-8.3-branch

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m64/builds/12203>

Commit(s) tested:
	3768f5bdec2ed46e7c3c07c863cebd99a5efe645

Author(s) (in the same order as the commits):
	Tom Tromey <tromey@adacore.com>

Subject:
	Make TUI react to "set style enabled"

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m64/37/3768f5bdec2ed46e7c3c07c863cebd99a5efe645/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/multi-forks.exp: run to exit 1
PASS -> UNRESOLVED: gdb.dwarf2/multidictionary.exp: GDB is alive
PASS -> FAIL: gdb.threads/process-dies-while-detaching.exp: single-process: continue: watchpoint: continue
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Fedora-x86_64-m64, branch gdb-8.3-branch

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/12376>

Commit(s) tested:
	3768f5bdec2ed46e7c3c07c863cebd99a5efe645

Author(s) (in the same order as the commits):
	Tom Tromey <tromey@adacore.com>

Subject:
	Make TUI react to "set style enabled"

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m64/37/3768f5bdec2ed46e7c3c07c863cebd99a5efe645/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/step-over-syscall.exp: clone: displaced=off: single step over clone
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch gdb-8.3-branch

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-2

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m32/builds/11965>

Commit(s) tested:
	3768f5bdec2ed46e7c3c07c863cebd99a5efe645

Author(s) (in the same order as the commits):
	Tom Tromey <tromey@adacore.com>

Subject:
	Make TUI react to "set style enabled"

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m32/37/3768f5bdec2ed46e7c3c07c863cebd99a5efe645/>

Failures on Fedora-x86_64-m32, branch gdb-8.3-branch

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/12037>

Commit(s) tested:
	3768f5bdec2ed46e7c3c07c863cebd99a5efe645

Author(s) (in the same order as the commits):
	Tom Tromey <tromey@adacore.com>

Subject:
	Make TUI react to "set style enabled"

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m32/37/3768f5bdec2ed46e7c3c07c863cebd99a5efe645/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.

Failures on Fedora-x86_64-native-gdbserver-m32, branch gdb-8.3-branch

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m32/builds/11973>

Commit(s) tested:
	3768f5bdec2ed46e7c3c07c863cebd99a5efe645

Author(s) (in the same order as the commits):
	Tom Tromey <tromey@adacore.com>

Subject:
	Make TUI react to "set style enabled"

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m32/37/3768f5bdec2ed46e7c3c07c863cebd99a5efe645/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.ada/O2_float_param.exp: frame
new FAIL: gdb.base/corefile.exp: core-file warning-free
FAIL -> UNRESOLVED: gdb.base/interrupt.exp: echo data
PASS -> FAIL: gdb.base/multi-forks.exp: info inferior 3
PASS -> FAIL: gdb.base/multi-forks.exp: run to exit 3
PASS -> FAIL: gdb.base/multi-forks.exp: run to exit 6
PASS -> FAIL: gdb.go/hello.exp: going to first breakpoint
new FAIL: gdb.go/hello.exp: setting breakpoint at hello.go:10
PASS -> FAIL: gdb.mi/mi-nsthrexec.exp: stop at main after exec
PASS -> FAIL: gdb.threads/non-ldr-exc-1.exp: lock-sched=off,non-stop=off: continue over exec
PASS -> FAIL: gdb.threads/non-ldr-exc-1.exp: lock-sched=on,non-stop=off: continue over exec
PASS -> FAIL: gdb.threads/non-ldr-exc-2.exp: lock-sched=on,non-stop=off: continue over exec
PASS -> FAIL: gdb.threads/non-ldr-exc-3.exp: lock-sched=off,non-stop=off: continue over exec
PASS -> FAIL: gdb.threads/non-ldr-exc-3.exp: lock-sched=off,non-stop=on: continue over exec
PASS -> FAIL: gdb.threads/non-ldr-exc-4.exp: lock-sched=off,non-stop=off: continue over exec
PASS -> FAIL: gdb.threads/non-ldr-exc-4.exp: lock-sched=off,non-stop=on: continue over exec
PASS -> FAIL: gdb.threads/non-ldr-exc-4.exp: lock-sched=on,non-stop=off: continue over exec
PASS -> FAIL: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: detach: continue
PASS -> FAIL: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: detach: continue to breakpoint: _exit
PASS -> FAIL: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: detach: detach child
PASS -> FAIL: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: detach: switch to parent
PASS -> FAIL: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: killed outside: continue to breakpoint: _exit
PASS -> FAIL: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: killed outside: get integer valueof "mypid"
PASS -> FAIL: gdb.threads/process-dies-while-detaching.exp: multi-process: detach: detach: continue to breakpoint: _exit
PASS -> FAIL: gdb.threads/process-dies-while-detaching.exp: multi-process: detach: killed outside: continue to breakpoint: _exit
PASS -> FAIL: gdb.threads/process-dies-while-detaching.exp: single-process: continue: watchpoint: continue
PASS -> FAIL: gdb.threads/thread-execl.exp: non-stop: get to main in new image
PASS -> FAIL: gdb.threads/thread-execl.exp: schedlock off: get to main in new image
PASS -> FAIL: gdb.threads/thread-execl.exp: schedlock on: get to main in new image
PASS -> FAIL: gdb.threads/thread-execl.exp: schedlock step: get to main in new image
PASS -> FAIL: gdb.trace/mi-tsv-changed.exp: create delete modify: tvariable $tvar3 modified
============================


*** Complete list of XFAILs for this builder ***

FAILURE TO OBTAIN THE COMMIT FOR THE XFAIL LIST.  PLEASE CONTACT THE BUILDBOT ADMIN.