From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115561 invoked by alias); 24 Jun 2019 10:40:43 -0000 Mailing-List: contact gdb-testers-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-testers-owner@sourceware.org Received: (qmail 115537 invoked by uid 89); 24 Jun 2019 10:40:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: kwanyin.sergiodj.net Received: from kwanyin.sergiodj.net (HELO kwanyin.sergiodj.net) (158.69.185.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Jun 2019 10:40:40 +0000 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [binutils-gdb] [gdb/testsuite] Fix inter-cu refs in inlined_subroutine-inheritance.exp From: gdb-buildbot@sergiodj.net To: gdb-testers@sourceware.org Message-Id: <385b97d3ac9c5c57a610d2e5b358ed888008ae31@gdb-build> Date: Mon, 24 Jun 2019 17:14:00 -0000 X-SW-Source: 2019-q2/txt/msg06581.txt.bz2 *** TEST RESULTS FOR COMMIT 385b97d3ac9c5c57a610d2e5b358ed888008ae31 *** commit 385b97d3ac9c5c57a610d2e5b358ed888008ae31 Author: Tom de Vries AuthorDate: Mon Jun 24 12:20:39 2019 +0200 Commit: Tom de Vries CommitDate: Mon Jun 24 12:20:39 2019 +0200 [gdb/testsuite] Fix inter-cu refs in inlined_subroutine-inheritance.exp When running gdb.dwarf2/inlined_subroutine-inheritance.exp with board cc-with-dwz, we run into: ... dwz: inlined_subroutine-inheritance: Couldn't find DIE referenced by \ DW_AT_abstract_origin ... The problem is that the DW_AT_abstract_origin attributes refer to DIEs in other CUs, while the references are encoded using the cu-relative encoding DW_FORM_ref4. Fix this by forcing the references to use DW_FORM_ref_addr. Tested on x86_64-linux. Tested with commit c24bdb023c "Introduce dwarf2_cu::get_builder" reverted, and verified that the test-case fails in the same way before and after this patch. gdb/testsuite/ChangeLog: 2019-06-24 Tom de Vries * gdb.dwarf2/inlined_subroutine-inheritance.exp: diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 8cd3c51194..4d48d2f63a 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2019-06-24 Tom de Vries + + * gdb.dwarf2/inlined_subroutine-inheritance.exp: + 2019-06-21 Tom de Vries * gdb.base/index-cache.exp: Add additional_flags=-Wl,--build-id. diff --git a/gdb/testsuite/gdb.dwarf2/inlined_subroutine-inheritance.exp b/gdb/testsuite/gdb.dwarf2/inlined_subroutine-inheritance.exp index 19b859492a..b51063c018 100644 --- a/gdb/testsuite/gdb.dwarf2/inlined_subroutine-inheritance.exp +++ b/gdb/testsuite/gdb.dwarf2/inlined_subroutine-inheritance.exp @@ -44,17 +44,17 @@ Dwarf::assemble $asm_file { {name ""} } { D72f8: subprogram { - {abstract_origin :$D272519} + {abstract_origin %$D272519} {low_pc 0xb9e20 addr} {high_pc 0x1f5 data4} } { D736e: inlined_subroutine { - {abstract_origin :$D26b227} + {abstract_origin %$D26b227} {low_pc 0xb9efc addr} {high_pc 0xc data4} } { formal_parameter { - {abstract_origin :$D274c42} + {abstract_origin %$D274c42} } } }