public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] Fix PR remote/19840: gdb crashes on reverse-stepi Date: Wed, 13 Apr 2016 14:46:00 -0000 [thread overview] Message-ID: <3a00c80277a54abe0b286a6e8babc8fe50120205@gdb-build> (raw) *** TEST RESULTS FOR COMMIT 3a00c80277a54abe0b286a6e8babc8fe50120205 *** Author: Pedro Alves <palves@redhat.com> Branch: master Commit: 3a00c80277a54abe0b286a6e8babc8fe50120205 Fix PR remote/19840: gdb crashes on reverse-stepi Reverse debugging against a remote target that does reverse debugging itself (with the bs/bc packets) always trips on: (gdb) target remote localhost:... (gdb) reverse-stepi ../../gdb/target.c:602: internal-error: default_execution_direction: to_execution_direction must be implemented for reverse async I missed adding a to_execution_direction method to remote.c in commit 3223143295b5 (Adds target_execution_direction to make record targets support async mode), GDB 7.4 time. Later, GDB 7.8 switched to target-async on by default, making the regression user-visible by default too. Fix is simply to add the missing to_execution_direction implementation to target remote. Tested by Andi Kleen against Simics. gdb/ChangeLog: 2016-04-13 Pedro Alves <palves@redhat.com> PR remote/19840 * remote.c (struct remote_state) <last_resume_exec_dir>: New field. (new_remote_state): Default last_resume_exec_dir to EXEC_FORWARD. (remote_open_1): Reset last_resume_exec_dir to EXEC_FORWARD. (remote_resume): Store the last execution direction. (remote_execution_direction): New function. (init_remote_ops): Install it as to_execution_direction target_ops method.
next reply other threads:[~2016-04-13 14:46 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-13 14:46 sergiodj+buildbot [this message] 2016-04-13 14:46 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master sergiodj+buildbot 2016-04-13 15:14 ` Failures on AIX-POWER7-plain, " sergiodj+buildbot 2016-04-13 15:37 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot 2016-04-14 7:39 ` Failures on Debian-i686, " sergiodj+buildbot 2016-04-14 8:11 ` Failures on Debian-i686-native-extended-gdbserver, " sergiodj+buildbot 2016-04-14 18:10 ` Failures on Fedora-ppc64be-cc-with-index, " sergiodj+buildbot 2016-04-14 19:04 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj+buildbot 2016-04-14 19:40 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot 2016-04-15 15:15 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj+buildbot 2016-04-15 15:47 ` Failures on Fedora-ppc64le-native-gdbserver-m64, " sergiodj+buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3a00c80277a54abe0b286a6e8babc8fe50120205@gdb-build \ --to=sergiodj+buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).