public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] gdb: remove discard_psymtab function Date: Sat, 11 Apr 2020 22:17:59 -0400 [thread overview] Message-ID: <3ad830466f440959b18b93c8361f9055fc135e54@gdb-build> (raw) *** TEST RESULTS FOR COMMIT 3ad830466f440959b18b93c8361f9055fc135e54 *** commit 3ad830466f440959b18b93c8361f9055fc135e54 Author: Simon Marchi <simon.marchi@polymtl.ca> AuthorDate: Sun Mar 29 15:23:31 2020 -0400 Commit: Simon Marchi <simon.marchi@polymtl.ca> CommitDate: Sun Mar 29 15:23:32 2020 -0400 gdb: remove discard_psymtab function This function does not add much value, compared to calling the method on the psymtab_storage object directly. gdb/ChangeLog: * psympriv.h (discard_psymtab): Remove. * dbxread.c (dbx_end_psymtab): Update. * xcoffread.c (xcoff_end_psymtab): Update. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 82ece13636..9e5c1cb3ae 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2020-03-29 Simon Marchi <simon.marchi@polymtl.ca> + + * psympriv.h (discard_psymtab): Remove. + * dbxread.c (dbx_end_psymtab): Update. + * xcoffread.c (xcoff_end_psymtab): Update. + 2020-03-28 Tom Tromey <tom@tromey.com> * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update diff --git a/gdb/dbxread.c b/gdb/dbxread.c index 99f47c0c91..ecc416e0b5 100644 --- a/gdb/dbxread.c +++ b/gdb/dbxread.c @@ -2057,7 +2057,7 @@ dbx_end_psymtab (struct objfile *objfile, legacy_psymtab *pst, is not empty, but we don't realize that. Fixing that without slowing things down might be tricky. */ - discard_psymtab (objfile, pst); + objfile->partial_symtabs->discard_psymtab (pst); /* Indicate that psymtab was thrown away. */ pst = NULL; diff --git a/gdb/psympriv.h b/gdb/psympriv.h index 0effedc4ec..79f83a4d6c 100644 --- a/gdb/psympriv.h +++ b/gdb/psympriv.h @@ -422,12 +422,6 @@ extern void init_psymbol_list (struct objfile *objfile, int total_symbols); extern void end_psymtab_common (struct objfile *, struct partial_symtab *); -static inline void -discard_psymtab (struct objfile *objfile, struct partial_symtab *pst) -{ - objfile->partial_symtabs->discard_psymtab (pst); -} - /* Used when recording partial symbol tables. On destruction, discards any partial symbol tables that have been built. However, the tables can be kept by calling the "keep" method. */ diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c index 735f8b0882..dca4c46fb1 100644 --- a/gdb/xcoffread.c +++ b/gdb/xcoffread.c @@ -2050,7 +2050,7 @@ xcoff_end_psymtab (struct objfile *objfile, legacy_psymtab *pst, /* Empty psymtabs happen as a result of header files which don't have any symbols in them. There can be a lot of them. */ - discard_psymtab (objfile, pst); + objfile->partial_symtabs->discard_psymtab (pst); /* Indicate that psymtab was thrown away. */ pst = NULL;
next reply other threads:[~2020-04-12 2:18 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-12 2:17 gdb-buildbot [this message] 2020-04-12 2:17 ` Failures on Fedora-i686, branch master gdb-buildbot 2020-04-12 2:59 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot 2020-04-12 3:07 ` Failures on Fedora-x86_64-m64, " gdb-buildbot 2020-04-12 3:48 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot 2020-04-12 3:58 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot 2020-04-15 8:13 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot 2020-04-16 2:37 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3ad830466f440959b18b93c8361f9055fc135e54@gdb-build \ --to=gdb-buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).