public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* Test results for commit 3b7a39661610038aad32563069b10fb2cfc55fab on branch gdb-7.9-branch
@ 2015-02-20  4:06 sergiodj
  2015-02-20  4:10 ` Failures on Fedora-ppc64be-cc-with-index, " sergiodj
                   ` (12 more replies)
  0 siblings, 13 replies; 14+ messages in thread
From: sergiodj @ 2015-02-20  4:06 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3b7a39661610038aad32563069b10fb2cfc55fab ***

Author: Andreas Arnez <arnez@linux.vnet.ibm.com>
Branch: gdb-7.9-branch
Commit: 3b7a39661610038aad32563069b10fb2cfc55fab

Fix internal error when core file section is too big
As reported in PR 17808, a test case with a forged (invalid) core file
can crash GDB with an assertion failure.  In that particular case the
prstatus of an i386 core file looks like that from an AMD64 core file.
Consequently the respective regset supply function i386_supply_gregset
is invoked with a larger buffer than usual.  But i386_supply_gregset
asserts a specific buffer size, and this assertion fails.

The patch relaxes all buffer size assertions in regset supply
functions such that they merely check for a sufficiently large buffer.
For consistency the regset collect functions are adjusted as well.

gdb/ChangeLog:

	PR corefiles/17808:
	* gdbarch.sh (iterate_over_regset_sections_cb): Document this
	function type, particularly its SIZE parameter.
	* gdbarch.h: Regenerate.
	* amd64-tdep.c (amd64_supply_fpregset): In gdb_assert, compare
	actual against required size using ">=" instead of "==".
	(amd64_collect_fpregset): Likewise.
	* i386-tdep.c (i386_supply_gregset): Likewise.
	(i386_collect_gregset): Likewise.
	(i386_supply_fpregset): Likewise.
	(i386_collect_fpregset): Likewise.
	* mips-linux-tdep.c (mips_supply_gregset_wrapper): Likewise.
	(mips_fill_gregset_wrapper): Likewise.
	(mips_supply_fpregset_wrapper): Likewise.
	(mips_fill_fpregset_wrapper): Likewise.
	(mips64_supply_gregset_wrapper): Likewise.
	(mips64_fill_gregset_wrapper): Likewise.
	(mips64_supply_fpregset_wrapper): Likewise.
	(mips64_fill_fpregset_wrapper): Likewise.
	* mn10300-linux-tdep.c (am33_supply_gregset_method): Likewise.
	(am33_supply_fpregset_method): Likewise.
	(am33_collect_gregset_method): Likewise.
	(am33_collect_fpregset_method): Likewise.


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2015-02-20  8:14 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-20  4:06 Test results for commit 3b7a39661610038aad32563069b10fb2cfc55fab on branch gdb-7.9-branch sergiodj
2015-02-20  4:10 ` Failures on Fedora-ppc64be-cc-with-index, " sergiodj
2015-02-20  4:52 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj
2015-02-20  5:54 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj
2015-02-20  6:21 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj
2015-02-20  7:01 ` Failures on Fedora-ppc64le-cc-with-index, " sergiodj
2015-02-20  7:18 ` Failures on Fedora-ppc64le-native-gdbserver-m64, " sergiodj
2015-02-20  7:31 ` Failures on Fedora-ppc64le-m64, " sergiodj
2015-02-20  8:02 ` Failures on Debian-i686, " sergiodj
2015-02-20  8:07 ` Failures on Fedora-i686, " sergiodj
2015-02-20  8:11 ` Failures on Fedora-x86_64-m32, " sergiodj
2015-02-20  8:50 ` Failures on Fedora-x86_64-m64, " sergiodj
2015-02-20  9:00 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj
2015-02-20  9:07 ` Failures on Debian-i686-native-extended-gdbserver, " sergiodj

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).