public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb: Add switch to disable DWARF stack unwinders
@ 2018-07-26  8:08 sergiodj+buildbot
  2018-07-26  8:08 ` Failures on RHEL-s390x-m64, branch master sergiodj+buildbot
                   ` (10 more replies)
  0 siblings, 11 replies; 12+ messages in thread
From: sergiodj+buildbot @ 2018-07-26  8:08 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 3c3bb0580be0027a1c7187b78c747af74dcfa884 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 3c3bb0580be0027a1c7187b78c747af74dcfa884

gdb: Add switch to disable DWARF stack unwinders

Add a maintenance command to disable the DWARF stack unwinders.
Normal users would not need this feature, but it is useful to allow
extended testing of fallback stack unwinding strategies, for example,
prologue scanners.

This is a partial implementation of the idea discussed in pr gdb/8434,
which talks about a generic ability to disable any frame unwinder.

Being able to arbitrarily disable any frame unwinder would be a more
complex patch, and I was unsure how useful such a feature would really
be, however, I can see (and have) a real need to disable DWARF
unwinders.  That's why this patch only targets that specific set of
unwinders.

If in the future we find ourselves adding more switches to disable
different unwinders, then we should probably move to a more generic
solution, and remove this patch.

gdb/ChangeLog:

	* dwarf2-frame-tailcall.c (tailcall_frame_sniffer): Exit early if
	DWARF unwinders are disabled.
	* dwarf2-frame.c: Add dwarf2read.h include.
	(dwarf2_frame_sniffer): Exit early if DWARF unwinders are
	disabled.
	(dwarf2_frame_unwinders_enabled_p): Define.
	(show_dwarf_unwinders_enabled_p): New function.
	(_initialize_dwarf2_frame): Register switch to control DWARF
	unwinder use.
	* dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Declare.
	* dwarf2read.c (set_dwarf_cmdlist): Remove static keyword.
	(show_dwarf_cmdlist): Remove static keyword.
	* dwarf2read.h (set_dwarf_cmdlist): Declare.
	(show_dwarf_cmdlist): Declare.
	* NEWS: Document new feature.

gdb/doc/ChangeLog:

	* gdb.texinfo (Maintenance Commands): Add description of
	maintenance command to control dwarf unwinders.

gdb/testsuite/ChangeLog:

	* gdb.base/maint.exp: Add check that dwarf unwinders control flag
	is visible.


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2018-07-26  9:46 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-26  8:08 [binutils-gdb] gdb: Add switch to disable DWARF stack unwinders sergiodj+buildbot
2018-07-26  8:08 ` Failures on RHEL-s390x-m64, branch master sergiodj+buildbot
2018-07-26  8:21 ` Failures on Fedora-i686, " sergiodj+buildbot
2018-07-26  8:25 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot
2018-07-26  8:34 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2018-07-26  8:40 ` Failures on Debian-s390x-m64, " sergiodj+buildbot
2018-07-26  8:51 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-w64-mingw32, branch master *** BREAKAGE *** sergiodj+buildbot
2018-07-26  8:51 ` Failures on Fedora-x86_64-cc-with-index, branch master sergiodj+buildbot
2018-07-26  9:06 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2018-07-26  9:09 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2018-07-26  9:40 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2018-07-26  9:46 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).