public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] Don't call gdbarch_pseudo_register_read_value in jit.c
Date: Mon, 22 Jan 2018 11:23:00 -0000 [thread overview]
Message-ID: <3f5a868b2277a3678f7eeb8fdf88935913b5918b@gdb-build> (raw)
*** TEST RESULTS FOR COMMIT 3f5a868b2277a3678f7eeb8fdf88935913b5918b ***
Author: Yao Qi <yao.qi@linaro.org>
Branch: master
Commit: 3f5a868b2277a3678f7eeb8fdf88935913b5918b
Don't call gdbarch_pseudo_register_read_value in jit.c
gdbarch_pseudo_register_read_value is not implemented in every gdbarch, so
the predicate gdbarch_pseudo_register_read_value_p is needed before
calling it. However, there is no such guard in jit_frame_prev_register, I
am wondering how does jit work on the arch without having gdbarch method
pseudo_register_read_value.
The proper way to get register value is to call cooked_read, and then
create the value object from the buffer.
gdb:
2018-01-22 Yao Qi <yao.qi@linaro.org>
* jit.c (jit_frame_prev_register): Call regcache::cooked_read
instead of gdbarch_pseudo_register_read_value.
next reply other threads:[~2018-01-22 11:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 11:23 sergiodj+buildbot [this message]
2018-01-22 11:23 ` Failures on RHEL-s390x-m64, branch master sergiodj+buildbot
2018-01-22 11:24 ` Failures on Debian-s390x-m64, " sergiodj+buildbot
2018-01-22 11:50 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2018-01-22 11:52 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2018-01-22 12:05 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2018-01-22 12:09 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2018-01-22 13:06 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f5a868b2277a3678f7eeb8fdf88935913b5918b@gdb-build \
--to=sergiodj+buildbot@sergiodj.net \
--cc=gdb-testers@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).