[binutils-gdb] Fix latent display bug in tui_data_window

[binutils-gdb] Fix latent display bug in tui_data_window

[gdb-buildbot]

*** TEST RESULTS FOR COMMIT 3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2 ***

commit 3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2
Author:     Tom Tromey <tom@tromey.com>
AuthorDate: Sat Feb 22 11:48:26 2020 -0700
Commit:     Tom Tromey <tom@tromey.com>
CommitDate: Sat Feb 22 11:48:28 2020 -0700

    Fix latent display bug in tui_data_window
    
    tui_data_window creates new curses windows, but does not pass in
    coordinates relative to the data window's origin.  This means that the
    data window could only ever be displayed as the topmost window in a
    layout.  This is not a currently problem, because all the existing
    layouts do this; but a subsequent patch will add user-defined layouts,
    which could do otherwise.
    
    gdb/ChangeLog
    2020-02-22  Tom Tromey  <tom@tromey.com>
    
            * tui/tui-regs.c (tui_data_window::display_registers_from): Use
            correct coordinates.
    
    Change-Id: I5101f2b2869557b87381ebdeebd9b7fd28687831

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 10a07df5d3..e35d5c5bc3 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-02-22  Tom Tromey  <tom@tromey.com>
+
+	* tui/tui-regs.c (tui_data_window::display_registers_from): Use
+	correct coordinates.
+
 2020-02-22  Tom Tromey  <tom@tromey.com>
 
 	* tui/tui-layout.h (tui_add_win_to_layout): Add comment.
diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index bedf55cab8..f0dfdefc80 100644
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -274,7 +274,7 @@ tui_data_window::display_registers_from (int start_element_no)
 	{
 	  /* Create the window if necessary.  */
 	  m_regs_content[i].resize (1, item_win_width,
-				    (item_win_width * j) + 1, cur_y);
+				    x + (item_win_width * j) + 1, y + cur_y);
 	  i++;		/* Next register.  */
 	}
       cur_y++;		/* Next row.  */

Failures on Fedora-x86_64-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/3/builds/2328

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2

Subject of commit:
        Fix latent display bug in tui_data_window

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/3f/3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i02
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i12
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i22
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 3rd stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 3rd stop: print j
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/3f/3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/3f/3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/4/builds/2163

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2

Subject of commit:
        Fix latent display bug in tui_data_window

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/3f/3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/corefile-buildid.exp: exec sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: exec: info files
new FAIL: gdb.base/corefile-buildid.exp: shared sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: shared: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink exec sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink exec: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink shared sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink shared: info files
new FAIL: gdb.base/corefile.exp: core-file warning-free
PASS -> UNRESOLVED: gdb.base/reread.exp: opts= "" "" : second pass: breakpoint foo in first file
PASS -> UNRESOLVED: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: breakpoint foo in first file
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
new FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: continue until exit
new FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: print re_run_var_2
PASS -> FAIL: gdb.python/py-events.exp: continue
PASS -> FAIL: gdb.python/py-events.exp: get address of do_nothing
PASS -> FAIL: gdb.python/py-events.exp: new objfile notification
new FAIL: gdb.python/py-events.exp: set detach-on-fork off
new FAIL: gdb.python/py-events.exp: setting breakpoint at do_nothing
new FAIL: gdb.python/py-events.exp: setting breakpoint at first
PASS -> FAIL: gdb.python/py-events.exp: step 3
PASS -> FAIL: gdb.python/py-events.exp: test-events
FAIL -> UNRESOLVED: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
PASS -> FAIL: gdb.threads/thread-unwindonsignal.exp: continue until exit
PASS -> FAIL: gdb.trace/mi-tsv-changed.exp: create delete modify: tvariable $tvar3 modified
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/3f/3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/3f/3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/2/builds/2163

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2

Subject of commit:
        Fix latent display bug in tui_data_window

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/3f/3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/break-interp.exp: LDprelinkNOdebugSEP: BINprelinkNOdebugNOpieNO: INNER: symbol-less: entry point reached
new FAIL: gdb.base/break-interp.exp: LDprelinkNOdebugSEP: BINprelinkNOdebugNOpieYES: INNER: symbol-less: entry point reached
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: print re_run_var_2
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 1st thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 1st thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 1st thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 3rd stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 3rd stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: second thread: print i3
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/3f/3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/3f/3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2//xfail.table.gz>

Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Ubuntu-Aarch64-native-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/19/builds/2079

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2

Subject of commit:
        Fix latent display bug in tui_data_window

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/3f/3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/step-over-syscall.exp: detach-on-fork=off: follow-fork=parent: break cond on target : fork: pc after stepi matches insn addr after syscall
PASS -> FAIL: gdb.base/step-over-syscall.exp: fork: displaced=off: check_pc_after_cross_syscall: single step over fork final pc
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/3f/3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/3f/3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m64

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/22/builds/2165

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2

Subject of commit:
        Fix latent display bug in tui_data_window

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/3f/3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/gdb-caching-proc.exp: set print elements unlimited
new FAIL: gdb.base/gdb-caching-proc.exp: set print repeats unlimited
new FAIL: gdb.base/gdb-caching-proc.exp: show print elements
new FAIL: gdb.base/gdb-caching-proc.exp: show print repeats
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: second thread: print i3
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/3f/3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/3f/3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m32

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/24/builds/2166

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2

Subject of commit:
        Fix latent display bug in tui_data_window

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/3f/3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/signals-state-child.exp: signals states are identical
PASS -> FAIL: gdb.threads/thread-unwindonsignal.exp: continue until exit
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/3f/3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/3f/3fe12b6d67182a81d2ffabbfe405fb5ffc0694b2//xfail.table.gz>