public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Make demangled_name_entry::language not a bitfield
@ 2019-10-24  1:37 gdb-buildbot
  2019-10-24  1:37 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: gdb-buildbot @ 2019-10-24  1:37 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 403772ef6112b909826f8d7446fb4ceaf6f98a1e ***

commit 403772ef6112b909826f8d7446fb4ceaf6f98a1e
Author:     Christian Biesinger <cbiesinger@google.com>
AuthorDate: Tue Oct 22 14:58:45 2019 -0500
Commit:     Christian Biesinger <cbiesinger@google.com>
CommitDate: Tue Oct 22 15:36:37 2019 -0500

    Make demangled_name_entry::language not a bitfield
    
    Having it as a bitfield causes extra work, and this is not memory-sensitive.
    Furthermore, once https://sourceware.org/ml/gdb-patches/2019-10/msg00812.html
    lands, the bitfield won't even save any memory at all.
    
    gdb/ChangeLog:
    
    2019-10-22  Christian Biesinger  <cbiesinger@google.com>
    
            * symtab.c (struct demangled_name_entry) <language>: Change from
            bitfield to regular variable.
    
    Change-Id: I4ea31d1cfcbe0f09a09bd058cd304862308dc388

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 8255a8540c..9cd38a3258 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-10-22  Christian Biesinger  <cbiesinger@google.com>
+
+	* symtab.c (struct demangled_name_entry) <language>: Change from
+	bitfield to regular variable.
+
 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 
 	* symtab.c (struct demangled_name_entry): Add a constructor.
diff --git a/gdb/symtab.c b/gdb/symtab.c
index ed55cecc73..0a87fec764 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -719,7 +719,7 @@ struct demangled_name_entry
     : mangled (mangled_name) {}
 
   gdb::string_view mangled;
-  ENUM_BITFIELD(language) language : LANGUAGE_BITS;
+  enum language language;
   char demangled[1];
 };
 


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-11-10  3:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24  1:37 [binutils-gdb] Make demangled_name_entry::language not a bitfield gdb-buildbot
2019-10-24  1:37 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot
2019-11-10  1:02 ` Failures on Fedora-i686, " gdb-buildbot
2019-11-10  1:47 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2019-11-10  1:54 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2019-11-10  3:37 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).