public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] Fix gdb segv when objfile can't be opened Date: Wed, 17 Jan 2018 18:49:00 -0000 [thread overview] Message-ID: <416675305692976aca45860e24b963982a2e682a@gdb-build> (raw) *** TEST RESULTS FOR COMMIT 416675305692976aca45860e24b963982a2e682a *** Author: Mike Gulick <mike.gulick@mathworks.com> Branch: master Commit: 416675305692976aca45860e24b963982a2e682a Fix gdb segv when objfile can't be opened This fixes PR 16577. This patch changes gdb_bfd_map_section to issue a warning rather than an error if it is unable to read the object file, and sets the size of the section/frame that it attempted to read to 0 on error. The description of gdb_bfd_map_section states that it will try to read or map the contents of the section SECT, and if successful, the section data is returned and *SIZE is set to the size of the section data. This function was throwing an error and leaving *SIZE as-is. Setting the section size to 0 indicates to dwarf2_build_frame_info that there is no data to read, otherwise it will try to read from an invalid frame pointer. Changing the error to a warning allows this to be handled gracefully. Additionally, the error was clobbering the breakpoint output indicating the current frame (function name, arguments, source file, and line number). E.g. Thread 3 "foo" hit Breakpoint 1, BFD: reopening /tmp/jna-1013829440/jna2973250704389291330.tmp: No such file or directory BFD: reopening /tmp/jna-1013829440/jna2973250704389291330.tmp: No such file or directory (gdb) While the "BFD: reopening ..." messages will still appear interspersed in the breakpoint output, the current frame info is now displayed: Thread 3 "foo" hit Breakpoint 1, BFD: reopening /tmp/jna-1013829440/jna1875755897659885075.tmp: No such file or directory BFD: reopening /tmp/jna-1013829440/jna1875755897659885075.tmp: No such file or directory warning: Can't read data for section '.eh_frame' in file '/tmp/jna-1013829440/jna1875755897659885075.tmp' do_something () at file.cpp:80 80 { (gdb)
next reply other threads:[~2018-01-17 18:49 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-17 18:49 sergiodj+buildbot [this message] 2018-01-17 18:49 ` Failures on RHEL-s390x-m64, branch master sergiodj+buildbot 2018-01-17 18:51 ` Failures on Debian-s390x-m64, " sergiodj+buildbot 2018-01-17 18:54 ` Failures on Fedora-i686, " sergiodj+buildbot 2018-01-17 18:57 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot 2018-01-17 19:06 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot 2018-01-17 19:11 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot 2018-01-17 19:19 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot 2018-01-17 19:27 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot 2018-01-17 19:43 ` Failures on Fedora-s390x-m64, " sergiodj+buildbot 2018-01-17 19:52 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot 2018-01-18 1:21 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, " sergiodj+buildbot 2018-01-18 1:57 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot 2018-01-18 9:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot 2018-01-18 10:53 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot 2018-01-18 11:42 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=416675305692976aca45860e24b963982a2e682a@gdb-build \ --to=sergiodj+buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).