From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29961 invoked by alias); 26 Mar 2015 21:04:43 -0000 Mailing-List: contact gdb-testers-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-testers-owner@sourceware.org Received: (qmail 29941 invoked by uid 89); 26 Mar 2015 21:04:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: kwanyin.sergiodj.net Received: from kwanyin.sergiodj.net (HELO kwanyin.sergiodj.net) (176.31.208.32) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 26 Mar 2015 21:04:41 +0000 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [binutils-gdb] dtrace-probe: Handle error while parsing probe argument. From: sergiodj+buildbot@redhat.com To: gdb-testers@sourceware.org Message-Id: <429e1e811b400f07b5a514ea6b8a70b28e2d7ee9@kwanyin> Date: Thu, 26 Mar 2015 22:17:00 -0000 X-SW-Source: 2015-q1/txt/msg06805.txt.bz2 *** TEST RESULTS FOR COMMIT 429e1e811b400f07b5a514ea6b8a70b28e2d7ee9 *** Author: Joel Brobecker Branch: master Commit: 429e1e811b400f07b5a514ea6b8a70b28e2d7ee9 dtrace-probe: Handle error while parsing probe argument. The debugger on Solaris has been broken since the introduction of DTrace probe support: (gdb) start Temporary breakpoint 1 at 0x80593bc: file simple_main.adb, line 4. Starting program: /[...]/simple_main [Thread debugging using libthread_db enabled] No definition of "mutex_t" in current context. The problem occurs while trying to parse a probe's argument, and the exception propagates all the way to the top. This patch fixes the issue by containing the exception and falling back on using the "long" builtin type if the argument's type could not be determined. Also, the parsing should be done using the C language parser. gdb/ChangeLog: * dtrace-probe.c (dtrace_process_dof_probe): Contain any exception raised while parsing the probe arguments. Force parsing to be done using the C language parser. * expression.h (parse_expression_with_language): Declare. * parse.c (parse_expression_with_language): New function.