public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Rearrange tui-regs.c some more
@ 2019-08-21 7:53 gdb-buildbot
2019-08-21 8:22 ` Failures on Fedora-i686, branch master gdb-buildbot
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: gdb-buildbot @ 2019-08-21 7:53 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2 ***
commit 42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2
Author: Tom Tromey <tom@tromey.com>
AuthorDate: Sat Jul 13 16:08:33 2019 -0600
Commit: Tom Tromey <tom@tromey.com>
CommitDate: Tue Aug 20 16:45:50 2019 -0600
Rearrange tui-regs.c some more
This moves tui_reg_layout later in tui-regs.c, closer to where it is
used.
It also changes tui_show_registers not to enable the TUI or change the
layout -- this is already done by this point by all the callers.
2019-08-20 Tom Tromey <tom@tromey.com>
* tui/tui-regs.c (tui_reg_layout): Move later.
(tui_show_registers): Don't enable TUI mode or change layout.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index fd3c8489a8..27fcb35a55 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2019-08-20 Tom Tromey <tom@tromey.com>
+
+ * tui/tui-regs.c (tui_reg_layout): Move later.
+ (tui_show_registers): Don't enable TUI mode or change layout.
+
2019-08-20 Tom Tromey <tom@tromey.com>
* tui/tui-regs.h (struct tui_data_item_window)
diff --git a/gdb/tui/tui-regs.c b/gdb/tui/tui-regs.c
index a899b1df69..147f57a13a 100644
--- a/gdb/tui/tui-regs.c
+++ b/gdb/tui/tui-regs.c
@@ -149,34 +149,11 @@ tui_data_window::first_reg_element_no_inline (int line_no) const
return (-1);
}
-/* A helper function to display the register window in the appropriate
- way. */
-
-static void
-tui_reg_layout ()
-{
- enum tui_layout_type cur_layout = tui_current_layout ();
- enum tui_layout_type new_layout;
- if (cur_layout == SRC_COMMAND || cur_layout == SRC_DATA_COMMAND)
- new_layout = SRC_DATA_COMMAND;
- else
- new_layout = DISASSEM_DATA_COMMAND;
- tui_set_layout (new_layout);
-}
-
/* Show the registers of the given group in the data window
and refresh the window. */
void
tui_show_registers (struct reggroup *group)
{
- /* Make sure the curses mode is enabled. */
- tui_enable ();
-
- /* Make sure the register window is visible. If not, select an
- appropriate layout. */
- if (TUI_DATA_WIN == NULL || !TUI_DATA_WIN->is_visible ())
- tui_reg_layout ();
-
if (group == 0)
group = general_reggroup;
@@ -676,6 +653,21 @@ tui_reg_prev (struct reggroup *current_group, struct gdbarch *gdbarch)
return group;
}
+/* A helper function to display the register window in the appropriate
+ way. */
+
+static void
+tui_reg_layout ()
+{
+ enum tui_layout_type cur_layout = tui_current_layout ();
+ enum tui_layout_type new_layout;
+ if (cur_layout == SRC_COMMAND || cur_layout == SRC_DATA_COMMAND)
+ new_layout = SRC_DATA_COMMAND;
+ else
+ new_layout = DISASSEM_DATA_COMMAND;
+ tui_set_layout (new_layout);
+}
+
/* Implement the 'tui reg' command. Changes the register group displayed
in the tui register window. Displays the tui register window if it is
not already on display. */
^ permalink raw reply [flat|nested] 6+ messages in thread
* Failures on Fedora-i686, branch master
2019-08-21 7:53 [binutils-gdb] Rearrange tui-regs.c some more gdb-buildbot
@ 2019-08-21 8:22 ` gdb-buildbot
2019-08-21 8:28 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: gdb-buildbot @ 2019-08-21 8:22 UTC (permalink / raw)
To: gdb-testers
Buildername:
Fedora-i686
Worker:
fedora-x86-64-1
Full Build URL:
https://gdb-buildbot.osci.io/#builders/18/builds/626
Author:
Tom Tromey <tom@tromey.com>
Commit tested:
42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2
Subject of commit:
Rearrange tui-regs.c some more
Testsuite logs (gdb.sum, gdb.log and others):
https://gdb-buildbot.osci.io/results/Fedora-i686/42/42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2/
*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "faas "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "faas -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "faas -s "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "frame apply 1 "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "frame apply 1 -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "frame apply 1 -s "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "frame apply all "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "frame apply all -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "frame apply all -s "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "frame apply level 0 "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "frame apply level 0 -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "frame apply level 0 -s "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "tfaas "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "tfaas -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "tfaas -s "
PASS -> UNRESOLVED: gdb.base/options.exp: test-frame-apply: frame apply 1 -- -
PASS -> UNRESOLVED: gdb.base/options.exp: test-frame-apply: frame apply all -- -
PASS -> UNRESOLVED: gdb.base/options.exp: test-frame-apply: frame apply level 0 -- -
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "faas "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "faas -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "faas -s "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply 1 "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply 1 -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply 1 -s "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply all "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply all -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply all -s "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply level 0 "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply level 0 -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply level 0 -s "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "tfaas "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "tfaas -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "tfaas -s "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: cmd complete "faas -- "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: cmd complete "frame apply 1 -- "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: cmd complete "frame apply all -- "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: cmd complete "frame apply level 0 -- "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: cmd complete "tfaas -- "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: tab complete "faas -- "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: tab complete "frame apply 1 -- "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: tab complete "frame apply all -- "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: tab complete "frame apply level 0 -- "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: tab complete "tfaas -- "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: cmd complete "taas "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: cmd complete "taas -- -"
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: cmd complete "taas -c "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: cmd complete "thread apply 1 "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: cmd complete "thread apply 1 -- -"
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: cmd complete "thread apply 1 -c "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: cmd complete "thread apply all "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: cmd complete "thread apply all -- -"
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: cmd complete "thread apply all -c "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: tab complete "taas "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: tab complete "taas -- -"
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: tab complete "taas -c "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: tab complete "thread apply 1 "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: tab complete "thread apply 1 -- -"
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: tab complete "thread apply 1 -c "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: tab complete "thread apply all "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: tab complete "thread apply all -- -"
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: tab complete "thread apply all -c "
PASS -> UNRESOLVED: gdb.base/options.exp: test-thread-apply: thread apply 1 -- -
PASS -> UNRESOLVED: gdb.base/options.exp: test-thread-apply: thread apply all -- -
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: trailing-space: cmd complete "taas -- "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: trailing-space: cmd complete "thread apply 1 -- "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: trailing-space: cmd complete "thread apply all -- "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: trailing-space: tab complete "taas -- "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: trailing-space: tab complete "thread apply 1 -- "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: trailing-space: tab complete "thread apply all -- "
PASS -> FAIL: gdb.base/style.exp: set width 30
PASS -> FAIL: gdb.base/with.exp: completion: cmd complete "with print elements unlimited -- "
PASS -> FAIL: gdb.base/with.exp: completion: tab complete "with print elements unlimited -- "
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
PASS -> FAIL: gdb.tui/basic.exp: asm box
PASS -> FAIL: gdb.tui/basic.exp: asm box in split layout
PASS -> FAIL: gdb.tui/basic.exp: asm window shows main
PASS -> FAIL: gdb.tui/basic.exp: list main
PASS -> FAIL: gdb.tui/basic.exp: split layout contents
PASS -> FAIL: gdb.tui/empty.exp: src: 80x24: box 1
PASS -> FAIL: gdb.tui/list.exp: asm window shows main
PASS -> FAIL: gdb.tui/list.exp: initial source listing
PASS -> FAIL: gdb.tui/list.exp: list main
PASS -> FAIL: gdb.tui/main.exp: show main after file
PASS -> FAIL: gdb.tui/regs.exp: register box
PASS -> FAIL: gdb.tui/regs.exp: source at startup
PASS -> FAIL: gdb.tui/resize.exp: source at startup
==============================================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<https://gdb-buildbot.osci.io/results/Fedora-i686/42/42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2//xfail.gz>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<https://gdb-buildbot.osci.io/results/Fedora-i686/42/42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2//xfail.table.gz>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Failures on Fedora-x86_64-cc-with-index, branch master
2019-08-21 7:53 [binutils-gdb] Rearrange tui-regs.c some more gdb-buildbot
2019-08-21 8:22 ` Failures on Fedora-i686, branch master gdb-buildbot
@ 2019-08-21 8:28 ` gdb-buildbot
2019-08-21 9:01 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: gdb-buildbot @ 2019-08-21 8:28 UTC (permalink / raw)
To: gdb-testers
Buildername:
Fedora-x86_64-cc-with-index
Worker:
fedora-x86-64-4
Full Build URL:
https://gdb-buildbot.osci.io/#builders/20/builds/626
Author:
Tom Tromey <tom@tromey.com>
Commit tested:
42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2
Subject of commit:
Rearrange tui-regs.c some more
Testsuite logs (gdb.sum, gdb.log and others):
https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/42/42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2/
*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/42/42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2//xfail.gz>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/42/42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2//xfail.table.gz>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Failures on Fedora-x86_64-m64, branch master
2019-08-21 7:53 [binutils-gdb] Rearrange tui-regs.c some more gdb-buildbot
2019-08-21 8:22 ` Failures on Fedora-i686, branch master gdb-buildbot
2019-08-21 8:28 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
@ 2019-08-21 9:01 ` gdb-buildbot
2019-08-21 9:18 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2019-08-21 9:46 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
4 siblings, 0 replies; 6+ messages in thread
From: gdb-buildbot @ 2019-08-21 9:01 UTC (permalink / raw)
To: gdb-testers
Buildername:
Fedora-x86_64-m64
Worker:
fedora-x86-64-2
Full Build URL:
https://gdb-buildbot.osci.io/#builders/3/builds/648
Author:
Tom Tromey <tom@tromey.com>
Commit tested:
42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2
Subject of commit:
Rearrange tui-regs.c some more
Testsuite logs (gdb.sum, gdb.log and others):
https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/42/42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2/
*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/42/42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2//xfail.gz>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/42/42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2//xfail.table.gz>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master
2019-08-21 7:53 [binutils-gdb] Rearrange tui-regs.c some more gdb-buildbot
` (2 preceding siblings ...)
2019-08-21 9:01 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
@ 2019-08-21 9:18 ` gdb-buildbot
2019-08-21 9:46 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
4 siblings, 0 replies; 6+ messages in thread
From: gdb-buildbot @ 2019-08-21 9:18 UTC (permalink / raw)
To: gdb-testers
Buildername:
Fedora-x86_64-native-extended-gdbserver-m32
Worker:
fedora-x86-64-1
Full Build URL:
https://gdb-buildbot.osci.io/#builders/4/builds/623
Author:
Tom Tromey <tom@tromey.com>
Commit tested:
42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2
Subject of commit:
Rearrange tui-regs.c some more
Testsuite logs (gdb.sum, gdb.log and others):
https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/42/42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2/
*** Diff to previous build ***
==============================================
new FAIL: gdb.base/corefile.exp: core-file warning-free
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
==============================================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/42/42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2//xfail.gz>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/42/42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2//xfail.table.gz>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Failures on Fedora-x86_64-native-gdbserver-m32, branch master
2019-08-21 7:53 [binutils-gdb] Rearrange tui-regs.c some more gdb-buildbot
` (3 preceding siblings ...)
2019-08-21 9:18 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
@ 2019-08-21 9:46 ` gdb-buildbot
4 siblings, 0 replies; 6+ messages in thread
From: gdb-buildbot @ 2019-08-21 9:46 UTC (permalink / raw)
To: gdb-testers
Buildername:
Fedora-x86_64-native-gdbserver-m32
Worker:
fedora-x86-64-3
Full Build URL:
https://gdb-buildbot.osci.io/#builders/24/builds/623
Author:
Tom Tromey <tom@tromey.com>
Commit tested:
42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2
Subject of commit:
Rearrange tui-regs.c some more
Testsuite logs (gdb.sum, gdb.log and others):
https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/42/42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2/
*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/options.exp: test-print: cmd complete "thread apply 1 frame apply 1 print xxx"
PASS -> FAIL: gdb.base/options.exp: test-print: tab complete "thread apply 1 frame apply 1 print xxx"
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================
*** Complete list of XFAILs for this builder ***
To obtain the list of XFAIL tests for this builder, go to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/42/42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2//xfail.gz>
You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:
<https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/42/42cc14a753e6edbcd43cdaa2dc2ee614a27aeeb2//xfail.table.gz>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-21 8:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-21 7:53 [binutils-gdb] Rearrange tui-regs.c some more gdb-buildbot
2019-08-21 8:22 ` Failures on Fedora-i686, branch master gdb-buildbot
2019-08-21 8:28 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2019-08-21 9:01 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2019-08-21 9:18 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2019-08-21 9:46 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).