public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Get rid of "gdb_dirbuf" and use "getcwd (NULL, 0)"
@ 2017-09-22 18:25 sergiodj+buildbot
  2017-09-22 18:26 ` Failures on Fedora-s390x-m64, branch master sergiodj+buildbot
                   ` (12 more replies)
  0 siblings, 13 replies; 14+ messages in thread
From: sergiodj+buildbot @ 2017-09-22 18:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 43573013c9836f2b91b74b9b29dac35fdb41e06b ***

Author: Sergio Durigan Junior <sergiodj@redhat.com>
Branch: master
Commit: 43573013c9836f2b91b74b9b29dac35fdb41e06b

Get rid of "gdb_dirbuf" and use "getcwd (NULL, 0)"

Currently we have "current_directory" and "gdb_dirbuf" globals, which
means that we basically have two possible places to consult when we
want to know GDB's current working directory.

This is not ideal and can lead to confusion.  Moreover, the way we're
using "gdb_difbuf" along with "getcwd" is problematic because we
declare the buffer with "1024" elements hardcoded, which does not take
into account longer pathnames that are possible in many filesystems.
Using "PATH_MAX" would also not be a solution because of portability
problems.  Therefore, the best solution is to rely on the fact that
"getcwd (NULL, 0)" will "do the right thing" and return a
heap-allocated string containing the full path.  With the new "getcwd"
module from gnulib, it is now possible to do that without worrying
about breaking some host.

With this patch "current_directory" is now the only place to check for
GDB's cwd.

Reviewed-by: Pedro Alves <palves@redhat.com>

gdb/ChangeLog:
2017-09-22  Sergio Durigan Junior  <sergiodj@redhat.com>

	* cli/cli-cmds.c (pwd_command): Use "getcwd (NULL, 0)".
	(cd_command): Likewise.  Free "current_directory" before
	assigning to it.
	* main.c (captured_main_1): Use "getcwd (NULL, 0)".
	* mi/mi-cmd-env.c (mi_cmd_env_pwd): Likewise.
	* top.c (gdb_dirbuf): Remove global declaration.
	* top.h (gdb_dirbuf): Likewise.


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2017-09-22 21:05 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-22 18:25 [binutils-gdb] Get rid of "gdb_dirbuf" and use "getcwd (NULL, 0)" sergiodj+buildbot
2017-09-22 18:26 ` Failures on Fedora-s390x-m64, branch master sergiodj+buildbot
2017-09-22 18:42 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
2017-09-22 18:42 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2017-09-22 18:43 ` Failures on Fedora-i686, " sergiodj+buildbot
2017-09-22 18:47 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2017-09-22 18:59 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2017-09-22 19:30 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2017-09-22 20:01 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot
2017-09-22 20:18 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2017-09-22 20:41 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot
2017-09-22 20:51 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot
2017-09-22 20:58 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2017-09-22 21:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).