public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] gdb: Restore selected frame in print_frame_local_vars
Date: Thu, 24 May 2018 18:01:00 -0000	[thread overview]
Message-ID: <45f25d6c83c31a48a01ef8293bb3978f5e58e653@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 45f25d6c83c31a48a01ef8293bb3978f5e58e653 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 45f25d6c83c31a48a01ef8293bb3978f5e58e653

gdb: Restore selected frame in print_frame_local_vars

PR gdb/23203 reports 'bt full' causing the currently selected frame to
change, this issue is fixed in this commit.

Add a new class scoped_restore_selected_frame that saves and restores
the selected frame.  Make use of this in print_frame_local_vars to
restore the selected frame on exit.

gdb/ChangeLog:

	PR gdb/23203
	* frame.c
	(scoped_restore_selected_frame::scoped_restore_selected_frame):
	Define.
	(scoped_restore_selected_frame::~scoped_restore_selected_frame):
	Define.
	* frame.h (class scoped_restore_selected_frame): New class.
	* stack.c (print_frame_local_vars): Remove catching and rethrowing
	of any exception, use scoped_restore_selected_frame to restore the
	frame instead.

gdb/testsuite/ChangeLog:

	PR gdb/23203
	* gdb.base/bt-selected-frame.c: New file.
	* gdb.base/bt-selected-frame.exp: New file.
	* lib/gdb.exp (get_current_frame_number): New function.


             reply	other threads:[~2018-05-24 17:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-24 18:01 sergiodj+buildbot [this message]
2018-05-24 18:41 ` Failures on Fedora-s390x-m64, branch master sergiodj+buildbot
2018-05-25 11:44 ` Failures on Debian-s390x-m64, " sergiodj+buildbot
2018-06-02  5:44 ` Failures on Fedora-i686, " sergiodj+buildbot
2018-06-02  5:58 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2018-06-02  6:19 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-w64-mingw32, branch master *** BREAKAGE *** sergiodj+buildbot
2018-06-02  6:40 ` Failures on Fedora-x86_64-cc-with-index, branch master sergiodj+buildbot
2018-09-01  7:51 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2018-09-02  0:55 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45f25d6c83c31a48a01ef8293bb3978f5e58e653@gdb-build \
    --to=sergiodj+buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).