[binutils-gdb] Fix a memory leak and remove an unused member

[binutils-gdb] Fix a memory leak and remove an unused member

[gdb-buildbot]

*** TEST RESULTS FOR COMMIT 4ac9383206032dd0357602136af1e05e7701142b ***

commit 4ac9383206032dd0357602136af1e05e7701142b
Author:     Tom Tromey <tom@tromey.com>
AuthorDate: Mon Feb 24 15:50:57 2020 -0700
Commit:     Tom Tromey <tom@tromey.com>
CommitDate: Mon Feb 24 15:50:58 2020 -0700

    Fix a memory leak and remove an unused member
    
    I noticed that setup_type_unit_groups leaks the symtab vector -- it
    allocates this with XNEWVEC, but from what I can tell, nothing frees
    it.  This patch changes it to use XOBNEWVEC.
    
    Also, the type_unit_unshareable::num_symtabs member is assigned but
    never read.  So, this removes it.
    
    gdb/ChangeLog
    2020-02-24  Tom Tromey  <tom@tromey.com>
    
            * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
            Remove.
            * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
            XOBNEWVEC.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2507b9c7dd..1a159470e6 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2020-02-24  Tom Tromey  <tom@tromey.com>
+
+	* dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
+	Remove.
+	* dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
+	XOBNEWVEC.
+
 2020-02-24  Tom Tromey  <tom@tromey.com>
 
 	* dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 0f514eafe8..d97956ecb6 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -589,10 +589,6 @@ struct type_unit_group
   /* The data used to construct the hash key.  */
   struct stmt_list_hash hash;
 
-  /* The number of symtabs from the line header.
-     The value here must match line_header.num_file_names.  */
-  unsigned int num_symtabs;
-
   /* The symbol tables for this TU (obtained from the files listed in
      DW_AT_stmt_list).
      WARNING: The order of entries here must match the order of entries
@@ -10854,9 +10850,9 @@ dwarf2_cu::setup_type_unit_groups (struct die_info *die)
 	 process_full_type_unit still needs to know if this is the first
 	 time.  */
 
-      tu_group->num_symtabs = line_header->file_names_size ();
-      tu_group->symtabs = XNEWVEC (struct symtab *,
-				   line_header->file_names_size ());
+      tu_group->symtabs
+	= XOBNEWVEC (&COMPUNIT_OBJFILE (cust)->objfile_obstack,
+		     struct symtab *, line_header->file_names_size ());
 
       auto &file_names = line_header->file_names ();
       for (i = 0; i < file_names.size (); ++i)

Failures on Fedora-x86_64-cc-with-index, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-cc-with-index

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/20/builds/2249

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        4ac9383206032dd0357602136af1e05e7701142b

Subject of commit:
        Fix a memory leak and remove an unused member

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/4a/4ac9383206032dd0357602136af1e05e7701142b/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: run to foo
new KFAIL: gdb.mi/mi-break.exp: mi-mode=main: break-insert -r operation
new KFAIL: gdb.mi/mi-break.exp: mi-mode=main: insert breakpoint with regexp .*llee
new KFAIL: gdb.mi/mi-break.exp: mi-mode=main: insert breakpoint with regexp callee
new KFAIL: gdb.mi/mi-break.exp: mi-mode=main: insert breakpoint with regexp callee2
new KFAIL: gdb.mi/mi-break.exp: mi-mode=main: list of breakpoints
new KFAIL: gdb.mi/mi-break.exp: mi-mode=separate: break-insert -r operation
new KFAIL: gdb.mi/mi-break.exp: mi-mode=separate: insert breakpoint with regexp .*llee
new KFAIL: gdb.mi/mi-break.exp: mi-mode=separate: insert breakpoint with regexp callee
new KFAIL: gdb.mi/mi-break.exp: mi-mode=separate: insert breakpoint with regexp callee2
new KFAIL: gdb.mi/mi-break.exp: mi-mode=separate: list of breakpoints
new KFAIL: gdb.reverse/recvmsg-reverse.exp: continue to breakpoint: marker2
new KFAIL: gdb.reverse/solib-precsave.exp: run to end of main
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 1st thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 1st thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 1st thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: first thread: print i3
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/4a/4ac9383206032dd0357602136af1e05e7701142b//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/4a/4ac9383206032dd0357602136af1e05e7701142b//xfail.table.gz>

Failures on Fedora-x86_64-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/3/builds/2359

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        4ac9383206032dd0357602136af1e05e7701142b

Subject of commit:
        Fix a memory leak and remove an unused member

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/4a/4ac9383206032dd0357602136af1e05e7701142b/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i02
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i12
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i22
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 3rd stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 3rd stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: second thread: print i3
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/4a/4ac9383206032dd0357602136af1e05e7701142b//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/4a/4ac9383206032dd0357602136af1e05e7701142b//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/4/builds/2194

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        4ac9383206032dd0357602136af1e05e7701142b

Subject of commit:
        Fix a memory leak and remove an unused member

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/4a/4ac9383206032dd0357602136af1e05e7701142b/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/corefile-buildid.exp: exec sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: exec: info files
new FAIL: gdb.base/corefile-buildid.exp: shared sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: shared: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink exec sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink exec: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink shared sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink shared: info files
new FAIL: gdb.base/corefile.exp: core-file warning-free
PASS -> UNRESOLVED: gdb.base/reread.exp: opts= "" "" : second pass: breakpoint foo in first file
PASS -> UNRESOLVED: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: breakpoint foo in first file
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=1: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=1: print re_run_var_2
new UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: delete all breakpoints in delete_breakpoints
PASS -> UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: setting breakpoint at all_started
PASS -> UNRESOLVED: gdb.threads/attach-into-signal.exp: threaded: attach
new FAIL: gdb.threads/attach-into-signal.exp: threaded: thread apply 2 print $_siginfo.si_signo
FAIL -> UNRESOLVED: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: inferior 1 exited
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> FAIL: gdb.trace/mi-tsv-changed.exp: create delete modify: tvariable $tvar3 modified
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/4a/4ac9383206032dd0357602136af1e05e7701142b//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/4a/4ac9383206032dd0357602136af1e05e7701142b//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/2/builds/2194

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        4ac9383206032dd0357602136af1e05e7701142b

Subject of commit:
        Fix a memory leak and remove an unused member

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/4a/4ac9383206032dd0357602136af1e05e7701142b/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/break-interp.exp: LDprelinkNOdebugSEP: BINprelinkNOdebugNOpieNO: INNER: symbol-less: entry point reached
new FAIL: gdb.base/break-interp.exp: LDprelinkNOdebugSEP: BINprelinkNOdebugNOpieYES: INNER: symbol-less: entry point reached
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: inferior 1 exited
new FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: only inferior 1 left
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 1st thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 1st thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 1st thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print j
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/4a/4ac9383206032dd0357602136af1e05e7701142b//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/4a/4ac9383206032dd0357602136af1e05e7701142b//xfail.table.gz>

Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Ubuntu-Aarch64-native-extended-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/5/builds/2079

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        4ac9383206032dd0357602136af1e05e7701142b

Subject of commit:
        Fix a memory leak and remove an unused member

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/4a/4ac9383206032dd0357602136af1e05e7701142b/

*** Diff to previous build ***
==============================================
PASS -> UNRESOLVED: gdb.threads/attach-into-signal.exp: threaded: attach
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/4a/4ac9383206032dd0357602136af1e05e7701142b//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/4a/4ac9383206032dd0357602136af1e05e7701142b//xfail.table.gz>

Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Ubuntu-Aarch64-native-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/19/builds/2110

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        4ac9383206032dd0357602136af1e05e7701142b

Subject of commit:
        Fix a memory leak and remove an unused member

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/4a/4ac9383206032dd0357602136af1e05e7701142b/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/step-over-syscall.exp: detach-on-fork=off: follow-fork=parent: break cond on target : fork: pc after stepi matches insn addr after syscall
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/4a/4ac9383206032dd0357602136af1e05e7701142b//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/4a/4ac9383206032dd0357602136af1e05e7701142b//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m64

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/22/builds/2195

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        4ac9383206032dd0357602136af1e05e7701142b

Subject of commit:
        Fix a memory leak and remove an unused member

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/4a/4ac9383206032dd0357602136af1e05e7701142b/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 1st stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 1st stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: second thread: print i3
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
PASS -> FAIL: gdb.threads/thread-unwindonsignal.exp: continue until exit
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/4a/4ac9383206032dd0357602136af1e05e7701142b//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/4a/4ac9383206032dd0357602136af1e05e7701142b//xfail.table.gz>