From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62914 invoked by alias); 5 Jan 2016 22:29:43 -0000 Mailing-List: contact gdb-testers-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-testers-owner@sourceware.org Received: (qmail 62884 invoked by uid 89); 5 Jan 2016 22:29:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy= X-HELO: kwanyin.sergiodj.net Received: from kwanyin.sergiodj.net (HELO kwanyin.sergiodj.net) (176.31.208.32) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 05 Jan 2016 22:29:42 +0000 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [binutils-gdb] libiberty: Tweak the documentation of libiberty's xcrc32 function From: sergiodj+buildbot@redhat.com To: gdb-testers@sourceware.org Message-Id: <4bec0ef03e91506caf60d8842786b29c2d2ff049@gdb-build> Date: Tue, 05 Jan 2016 22:29:00 -0000 X-SW-Source: 2016-q1/txt/msg00462.txt.bz2 *** TEST RESULTS FOR COMMIT 4bec0ef03e91506caf60d8842786b29c2d2ff049 *** Author: Patrick Palka Branch: master Commit: 4bec0ef03e91506caf60d8842786b29c2d2ff049 libiberty: Tweak the documentation of libiberty's xcrc32 function In some places the xcrc32 documentation refers to GDB's own crc32 implementation, but GDB no longer has its own crc32 implementation. It now uses libiberty's xcrc32 throughout. So this patch removes these references to GDB's now-nonexistent crc32 implementation. Also, there appears to be a bug in the table-generation program embedded within the documentation. When the variable "int i" is >= 128, the computation "i << 24" shifts a one bit into the sign bit (assuming a 32-bit int), which is UB. To avoid this UB, I think it is sufficient to make the induction variables i and j have type unsigned int. This bug seems latent, however. I ran the program before and after this change and the table output is the same.