[binutils-gdb] Fix comment in dwarf2/attribute.h

[binutils-gdb] Fix comment in dwarf2/attribute.h

[gdb-buildbot]

*** TEST RESULTS FOR COMMIT 4d1b9ab645d9ce72aad15011264dd9b2e52a57e8 ***

commit 4d1b9ab645d9ce72aad15011264dd9b2e52a57e8
Author:     Tom Tromey <tom@tromey.com>
AuthorDate: Sat Mar 28 09:25:41 2020 -0600
Commit:     Tom Tromey <tom@tromey.com>
CommitDate: Sat Mar 28 09:25:41 2020 -0600

    Fix comment in dwarf2/attribute.h
    
    I noticed that a comment in dwarf2/attribute.h still referred to
    dwarf2_get_attr_constant_value.  However, this is now a method on
    struct attribute.
    
    gdb/ChangeLog
    2020-03-28  Tom Tromey  <tom@tromey.com>
    
            * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
            comment.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index bc4451ec0c..82ece13636 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-03-28  Tom Tromey  <tom@tromey.com>
+
+	* dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
+	comment.
+
 2020-03-28  Tom Tromey  <tom@tromey.com>
 
 	* dwarf2/read.c (read_attribute_reprocess): Fix formatting.
diff --git a/gdb/dwarf2/attribute.h b/gdb/dwarf2/attribute.h
index 483b805433..69b33513ad 100644
--- a/gdb/dwarf2/attribute.h
+++ b/gdb/dwarf2/attribute.h
@@ -59,7 +59,7 @@ struct attribute
 
   /* Return non-zero if ATTR's value falls in the 'constant' class, or
      zero otherwise.  When this function returns true, you can apply
-     dwarf2_get_attr_constant_value to it.
+     the constant_value method to it.
 
      However, note that for some attributes you must check
      attr_form_is_section_offset before using this test.  DW_FORM_data4
@@ -70,8 +70,8 @@ struct attribute
      section offset classes, DW_FORM_data4 and DW_FORM_data8 should be
      taken as section offsets, not constants.
 
-     DW_FORM_data16 is not considered as dwarf2_get_attr_constant_value
-     cannot handle that.  */
+     DW_FORM_data16 is not considered as constant_value cannot handle
+     that.  */
 
   bool form_is_constant () const;
 

Failures on Fedora-i686, branch master

[gdb-buildbot]

Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/18/builds/2692

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        4d1b9ab645d9ce72aad15011264dd9b2e52a57e8

Subject of commit:
        Fix comment in dwarf2/attribute.h

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.cp/cpcompletion.exp: expression with namespace: cmd complete "p Test_NS"
PASS -> FAIL: gdb.cp/cpcompletion.exp: expression with namespace: tab complete "p Test_NS"
PASS -> FAIL: gdb.threads/gcore-stale-thread.exp: save a corefile
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8//xfail.table.gz>

Failures on Fedora-x86_64-cc-with-index, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-cc-with-index

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/20/builds/2639

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        4d1b9ab645d9ce72aad15011264dd9b2e52a57e8

Subject of commit:
        Fix comment in dwarf2/attribute.h

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.linespec/explicit.exp: complete non-unique label name: cmd complete "b -function myfunction -label "
PASS -> FAIL: gdb.linespec/explicit.exp: complete non-unique label name: tab complete "b -function myfunction -label "
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: first thread: print i02
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: first thread: print i12
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: first thread: print i22
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8//xfail.table.gz>

Failures on Fedora-x86_64-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/17/builds/2688

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        4d1b9ab645d9ce72aad15011264dd9b2e52a57e8

Subject of commit:
        Fix comment in dwarf2/attribute.h

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: run to foo
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8//xfail.table.gz>

Failures on Fedora-x86_64-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/3/builds/2748

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        4d1b9ab645d9ce72aad15011264dd9b2e52a57e8

Subject of commit:
        Fix comment in dwarf2/attribute.h

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/options.exp: test-print: cmd complete "frame apply 1 print -"
PASS -> FAIL: gdb.base/options.exp: test-print: tab complete "frame apply 1 print -"
PASS -> FAIL: gdb.base/step-over-syscall.exp: clone: displaced=off: single step over clone
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/4/builds/2584

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        4d1b9ab645d9ce72aad15011264dd9b2e52a57e8

Subject of commit:
        Fix comment in dwarf2/attribute.h

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/attach.exp: do_call_attach_tests: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: print re_run_var_1
new KFAIL: gdb.threads/watchthreads2.exp: gdb can drop watchpoints in multithreaded app
PASS -> FAIL: gdb.trace/mi-tsv-changed.exp: create delete modify: tvariable $tvar3 modified
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/2/builds/2585

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        4d1b9ab645d9ce72aad15011264dd9b2e52a57e8

Subject of commit:
        Fix comment in dwarf2/attribute.h

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=1: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=1: print re_run_var_1
new UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: delete all breakpoints in delete_breakpoints
PASS -> UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: setting breakpoint at all_started
new FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: continue until exit
new FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: print re_run_var_2
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 1st stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 1st stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: first thread: print i3
PASS -> FAIL: gdb.threads/thread-unwindonsignal.exp: continue until exit
PASS -> FAIL: gdb.trace/ftrace.exp: advance through tracing
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m64

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/22/builds/2585

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        4d1b9ab645d9ce72aad15011264dd9b2e52a57e8

Subject of commit:
        Fix comment in dwarf2/attribute.h

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/gdb-caching-proc.exp: show print elements
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 1st thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 1st thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 1st thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print z
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8//xfail.table.gz>

Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Ubuntu-Aarch64-native-extended-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/5/builds/2468

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        4d1b9ab645d9ce72aad15011264dd9b2e52a57e8

Subject of commit:
        Fix comment in dwarf2/attribute.h

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8//xfail.table.gz>

Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Ubuntu-Aarch64-native-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/19/builds/2501

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        4d1b9ab645d9ce72aad15011264dd9b2e52a57e8

Subject of commit:
        Fix comment in dwarf2/attribute.h

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/step-over-syscall.exp: fork: displaced=off: pc after stepi matches insn addr after syscall
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/4d/4d1b9ab645d9ce72aad15011264dd9b2e52a57e8//xfail.table.gz>