public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb/gdb-7.12-branch] Fix PR gdb/19187 (process record over a fork causes internal error) Date: Thu, 11 Aug 2016 04:18:00 -0000 [thread overview] Message-ID: <4dfacf706adacbefbc38d7ba59212566f77bd051@gdb-build> (raw) *** TEST RESULTS FOR COMMIT 4dfacf706adacbefbc38d7ba59212566f77bd051 *** Author: Pedro Alves <palves@redhat.com> Branch: gdb-7.12-branch Commit: 4dfacf706adacbefbc38d7ba59212566f77bd051 Fix PR gdb/19187 (process record over a fork causes internal error) Right after a fork is detected, we detach breakpoints from the child (detach_breakpoints), which calls into target_remove_breakpoint with inferior_ptid pointing at the child process, but leaves the breakpoint marked inserted (in the parent). The problem is that record-full.c always deletes all knowledge of the breakpoint. Then when we later really delete the breakpoint from the parent, we fail the assertion, since the breakpoint is unexpectedly not found in the record-full.c breakpoint table. The fix is simply to not forget about the breakpoint if we're detaching it from a fork child. gdb/ChangeLog: 2016-08-10 Pedro Alves <palves@redhat.com> PR gdb/19187 * record-full.c (record_full_remove_breakpoint): Don't remove the breakpoint from the record_full_breakpoints VEC if we're detaching the breakpoint from a fork child. gdb/testsuite/ChangeLog: 2016-08-10 Pedro Alves <palves@redhat.com> PR gdb/19187 * gdb.reverse/waitpid-reverse.exp: Add comment and remove setup_kfails.
next reply other threads:[~2016-08-11 1:15 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-08-11 4:18 sergiodj+buildbot [this message] 2016-08-11 4:19 ` Failures on Fedora-x86_64-native-gdbserver-m32, branch gdb-7.12-branch sergiodj+buildbot 2016-08-11 4:32 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot 2016-08-11 4:57 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot 2016-08-11 5:20 ` Failures on Fedora-i686, " sergiodj+buildbot 2016-08-11 5:25 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot 2016-08-11 5:32 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot 2016-08-11 6:43 ` Failures on Debian-s390x-m64, " sergiodj+buildbot 2016-08-11 6:44 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot 2016-08-11 10:17 ` Failures on Debian-i686, " sergiodj+buildbot 2016-08-11 11:15 ` Failures on Debian-i686-native-extended-gdbserver, " sergiodj+buildbot 2016-08-11 12:56 ` Failures on Fedora-s390x-m64, " sergiodj+buildbot 2016-08-12 1:47 ` Failures on Debian-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot 2016-08-12 2:04 ` Failures on Fedora-ppc64be-m64, " sergiodj+buildbot 2016-08-12 2:31 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj+buildbot 2016-08-12 2:33 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj+buildbot 2016-08-12 2:56 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot 2016-08-12 3:11 ` Failures on Fedora-ppc64le-native-gdbserver-m64, " sergiodj+buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4dfacf706adacbefbc38d7ba59212566f77bd051@gdb-build \ --to=sergiodj+buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).