public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] Remove last traces of discard_all_inferiors
Date: Sun, 12 Jan 2020 01:45:00 -0000	[thread overview]
Message-ID: <4ec89149dd83efecea15300bf425c9988f4cd5c0@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 4ec89149dd83efecea15300bf425c9988f4cd5c0 ***

commit 4ec89149dd83efecea15300bf425c9988f4cd5c0
Author:     Pedro Alves <palves@redhat.com>
AuthorDate: Sun Jan 12 00:40:02 2020 +0000
Commit:     Pedro Alves <palves@redhat.com>
CommitDate: Sun Jan 12 00:40:02 2020 +0000

    Remove last traces of discard_all_inferiors
    
    The multi-target patch should have removed all traces of
    discard_all_inferiors, but somehow one use stayed behind along with
    the definition of the function.
    
    discard_all_inferiors is bad now because it blindly exits inferiors of
    all target connections.  It's best to remove it.
    
    gdb/ChangeLog:
    2020-01-12  Pedro Alves  <palves@redhat.com>
    
            * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
            directly for the current inferior instead of
            discard_all_inferiors.
            (discard_all_inferiors): Delete.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 735c46bf70..980114919d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2020-01-12  Pedro Alves  <palves@redhat.com>
+
+	* bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
+	directly for the current inferior instead of
+	discard_all_inferiors.
+	(discard_all_inferiors): Delete.
+
 2020-01-11  Tom Tromey  <tom@tromey.com>
 
 	* tui/tui-wingeneral.c (box_win): Check cli_styling.
diff --git a/gdb/bsd-kvm.c b/gdb/bsd-kvm.c
index f864ba8b41..b1b1fee5f4 100644
--- a/gdb/bsd-kvm.c
+++ b/gdb/bsd-kvm.c
@@ -156,7 +156,7 @@ bsd_kvm_target::close ()
     }
 
   inferior_ptid = null_ptid;
-  discard_all_inferiors ();
+  exit_inferior_silent (current_inferior ());
 }
 
 static LONGEST
diff --git a/gdb/inferior.c b/gdb/inferior.c
index eb090dfde1..c2e9da3d3d 100644
--- a/gdb/inferior.c
+++ b/gdb/inferior.c
@@ -260,13 +260,6 @@ inferior_appeared (struct inferior *inf, int pid)
   gdb::observers::inferior_appeared.notify (inf);
 }
 
-void
-discard_all_inferiors (void)
-{
-  for (inferior *inf : all_non_exited_inferiors ())
-    exit_inferior_silent (inf);
-}
-
 struct inferior *
 find_inferior_id (int num)
 {


             reply	other threads:[~2020-01-12  1:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-12  1:45 gdb-buildbot [this message]
2020-01-12  1:13 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot
2020-01-12  3:19 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, " gdb-buildbot
2020-01-14  5:42 ` Failures on Fedora-i686, " gdb-buildbot
2020-01-14  5:48 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2020-01-14  5:53 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2020-01-14  5:53 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2020-01-14  6:22 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2020-01-14  6:32 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2020-01-14  6:41 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
2020-01-14  6:41 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ec89149dd83efecea15300bf425c9988f4cd5c0@gdb-build \
    --to=gdb-buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).