public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] Fix gdb.base/testenv.exp against --target_board=native-extended-gdbserver Date: Fri, 13 Oct 2017 18:20:00 -0000 [thread overview] Message-ID: <50500caf810fcc6c05e3fd89bc37fe8f9e4adb07@gdb-build> (raw) *** TEST RESULTS FOR COMMIT 50500caf810fcc6c05e3fd89bc37fe8f9e4adb07 *** Author: Pedro Alves <palves@redhat.com> Branch: master Commit: 50500caf810fcc6c05e3fd89bc37fe8f9e4adb07 Fix gdb.base/testenv.exp against --target_board=native-extended-gdbserver Currently we get: Running ..../src/gdb/testsuite/gdb.base/testenv.exp ... FAIL: gdb.base/testenv.exp: test no TEST_GDB var FAIL: gdb.base/testenv.exp: test with one TEST_GDB var FAIL: gdb.base/testenv.exp: test with two TEST_GDB var FAIL: gdb.base/testenv.exp: test with one TEST_GDB var, after unset FAIL: gdb.base/testenv.exp: test with TEST_GDB_GLOBAL FAIL: gdb.base/testenv.exp: test with TEST_GDB_GLOBAL unset The problem is that the testcase relies on stdio. While we could fix this for gdbserver by read output from inferior_spawn_id, a better fix it to not rely on stdio at all. That's what this commit does. Instead, it reads variables off of the inferior to extract the necessary information. Along the way, most of the .exp file is reimplemented/cleaned up using more modern mechanisms. E.g., with_test_prefix, proc_with_prefix, save_vars, etc. Also, a missing check for "is_remote host" is added. gdb/testsuite/ChangeLog: 2017-10-13 Pedro Alves <palves@redhat.com> * gdb.base/testenv.exp: Check use_gdb_stub instead of is_remote. (test_num_test_vars, run_and_count_vars, find_env) (test_set_unset_env, test_inherit_env_var): New procedures. (top level): Use them.
next reply other threads:[~2017-10-13 18:20 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-13 18:20 sergiodj+buildbot [this message] 2017-10-13 18:20 ` Failures on Fedora-s390x-m64, branch master sergiodj+buildbot 2017-10-14 6:00 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, " sergiodj+buildbot 2017-10-14 6:29 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot 2017-10-14 13:14 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot 2017-10-14 13:38 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot 2017-10-15 8:22 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot 2017-10-15 9:03 ` Failures on Fedora-i686, " sergiodj+buildbot 2017-10-15 9:17 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=50500caf810fcc6c05e3fd89bc37fe8f9e4adb07@gdb-build \ --to=sergiodj+buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).