[binutils-gdb] gdbserver does not need xstrdup

[binutils-gdb] gdbserver does not need xstrdup

[gdb-buildbot]

*** TEST RESULTS FOR COMMIT 52c64cf72d40aace2d2fedca32e5c0373cd9a484 ***

commit 52c64cf72d40aace2d2fedca32e5c0373cd9a484
Author:     Tom Tromey <tromey@adacore.com>
AuthorDate: Thu Aug 29 10:45:06 2019 -0400
Commit:     Tom Tromey <tromey@adacore.com>
CommitDate: Fri Oct 25 08:22:44 2019 -0600

    gdbserver does not need xstrdup
    
    gdbserver has its own implementation of xstrdup.  However, because
    gdbserver links against libiberty now, I think this is not needed.
    This patch removes it.
    
    gdb/gdbserver/ChangeLog
    2019-10-25  Tom Tromey  <tromey@adacore.com>
    
            * utils.c (xstrdup): Remove.
    
    Change-Id: I2aa56d18d0f9af8e70a00dff431d2fda5705a5d5

diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index dcd62380b1..55394797dd 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,7 @@
+2019-10-25  Tom Tromey  <tromey@adacore.com>
+
+	* utils.c (xstrdup): Remove.
+
 2019-10-23  Tom Tromey  <tom@tromey.com>
 
 	* configure, config.in: Rebuild.
diff --git a/gdb/gdbserver/utils.c b/gdb/gdbserver/utils.c
index 79a7e80f62..6a0e7a7a0f 100644
--- a/gdb/gdbserver/utils.c
+++ b/gdb/gdbserver/utils.c
@@ -37,18 +37,6 @@ malloc_failure (long size)
   exit (1);
 }
 
-/* Copy a string into a memory buffer.
-   If malloc fails, this will print a message to stderr and exit.  */
-
-char *
-xstrdup (const char *s)
-{
-  char *ret = strdup (s);
-  if (ret == NULL)
-    malloc_failure (strlen (s) + 1);
-  return ret;
-}
-
 /* Print the system error message for errno, and also mention STRING
    as the file name for which the error was encountered.
    Then return to command level.  */

Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Ubuntu-Aarch64-native-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/19/builds/1029

Author:
        Tom Tromey <tromey@adacore.com>

Commit tested:
        52c64cf72d40aace2d2fedca32e5c0373cd9a484

Subject of commit:
        gdbserver does not need xstrdup

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/52/52c64cf72d40aace2d2fedca32e5c0373cd9a484/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/52/52c64cf72d40aace2d2fedca32e5c0373cd9a484//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-gdbserver-m64/52/52c64cf72d40aace2d2fedca32e5c0373cd9a484//xfail.table.gz>

Failures on Fedora-x86_64-cc-with-index, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-cc-with-index

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/20/builds/1122

Author:
        Tom Tromey <tromey@adacore.com>

Commit tested:
        52c64cf72d40aace2d2fedca32e5c0373cd9a484

Subject of commit:
        gdbserver does not need xstrdup

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/52/52c64cf72d40aace2d2fedca32e5c0373cd9a484/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/52/52c64cf72d40aace2d2fedca32e5c0373cd9a484//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/52/52c64cf72d40aace2d2fedca32e5c0373cd9a484//xfail.table.gz>

Failures on Fedora-x86_64-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/17/builds/1176

Author:
        Tom Tromey <tromey@adacore.com>

Commit tested:
        52c64cf72d40aace2d2fedca32e5c0373cd9a484

Subject of commit:
        gdbserver does not need xstrdup

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/52/52c64cf72d40aace2d2fedca32e5c0373cd9a484/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/52/52c64cf72d40aace2d2fedca32e5c0373cd9a484//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/52/52c64cf72d40aace2d2fedca32e5c0373cd9a484//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/2/builds/1173

Author:
        Tom Tromey <tromey@adacore.com>

Commit tested:
        52c64cf72d40aace2d2fedca32e5c0373cd9a484

Subject of commit:
        gdbserver does not need xstrdup

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/52/52c64cf72d40aace2d2fedca32e5c0373cd9a484/

*** Diff to previous build ***
==============================================
PASS -> UNRESOLVED: gdb.threads/attach-into-signal.exp: threaded: attach
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/52/52c64cf72d40aace2d2fedca32e5c0373cd9a484//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/52/52c64cf72d40aace2d2fedca32e5c0373cd9a484//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m32

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/24/builds/1168

Author:
        Tom Tromey <tromey@adacore.com>

Commit tested:
        52c64cf72d40aace2d2fedca32e5c0373cd9a484

Subject of commit:
        gdbserver does not need xstrdup

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/52/52c64cf72d40aace2d2fedca32e5c0373cd9a484/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/52/52c64cf72d40aace2d2fedca32e5c0373cd9a484//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/52/52c64cf72d40aace2d2fedca32e5c0373cd9a484//xfail.table.gz>