[binutils-gdb] Modify AArch64 Assembly and disassembly functions to be able to fail and report why.

[binutils-gdb] Modify AArch64 Assembly and disassembly functions to be able to fail and report why.

[sergiodj+buildbot]

*** TEST RESULTS FOR COMMIT 561a72d4ddf825ffaf8e88551e9bd6707cd6c59f ***

Author: Tamar Christina <tamar.christina@arm.com>
Branch: master
Commit: 561a72d4ddf825ffaf8e88551e9bd6707cd6c59f

Modify AArch64 Assembly and disassembly functions to be able to fail and report why.

This patch if the first patch in a series to add the ability to add constraints
to system registers that an instruction must adhere to in order for the register
to be usable with that instruction.

These constraints can also be used to disambiguate between registers with the
same encoding during disassembly.

This patch adds a new flags entry in the sysreg structures and ensures it is
filled in and read out during assembly/disassembly. It also adds the ability for
the assemble and disassemble functions to be able to gracefully fail and re-use
the existing error reporting infrastructure.

The return type of these functions are changed to a boolean to denote success or
failure and the error structure is passed around to them. This requires
aarch64-gen changes so a lot of the changes here are just mechanical.

gas/

	PR binutils/21446
	* config/tc-aarch64.c (parse_sys_reg): Return register flags.
	(parse_operands): Fill in register flags.

gdb/

	PR binutils/21446
	* aarch64-tdep.c (aarch64_analyze_prologue,
	aarch64_software_single_step, aarch64_displaced_step_copy_insn):
	Indicate not interested in errors.

include/

	PR binutils/21446
	* opcode/aarch64.h (aarch64_opnd_info): Change sysreg to struct.
	(aarch64_decode_insn): Accept error struct.

opcodes/

	PR binutils/21446
	* aarch64-asm.h (aarch64_insert_operand, aarch64_##x): Return boolean
	and take error struct.
	* aarch64-asm.c (aarch64_ext_regno, aarch64_ins_reglane,
	aarch64_ins_reglist, aarch64_ins_ldst_reglist,
	aarch64_ins_ldst_reglist_r, aarch64_ins_ldst_elemlist,
	aarch64_ins_advsimd_imm_shift, aarch64_ins_imm, aarch64_ins_imm_half,
	aarch64_ins_advsimd_imm_modified, aarch64_ins_fpimm,
	aarch64_ins_imm_rotate1, aarch64_ins_imm_rotate2, aarch64_ins_fbits,
	aarch64_ins_aimm, aarch64_ins_limm_1, aarch64_ins_limm,
	aarch64_ins_inv_limm, aarch64_ins_ft, aarch64_ins_addr_simple,
	aarch64_ins_addr_regoff, aarch64_ins_addr_offset, aarch64_ins_addr_simm,
	aarch64_ins_addr_simm10, aarch64_ins_addr_uimm12,
	aarch64_ins_simd_addr_post, aarch64_ins_cond, aarch64_ins_sysreg,
	aarch64_ins_pstatefield, aarch64_ins_sysins_op, aarch64_ins_barrier,
	aarch64_ins_prfop, aarch64_ins_hint, aarch64_ins_reg_extended,
	aarch64_ins_reg_shifted, aarch64_ins_sve_addr_ri_s4xvl,
	aarch64_ins_sve_addr_ri_s6xvl, aarch64_ins_sve_addr_ri_s9xvl,
	aarch64_ins_sve_addr_ri_s4, aarch64_ins_sve_addr_ri_u6,
	aarch64_ins_sve_addr_rr_lsl, aarch64_ins_sve_addr_rz_xtw,
	aarch64_ins_sve_addr_zi_u5, aarch64_ext_sve_addr_zz,
	aarch64_ins_sve_addr_zz_lsl, aarch64_ins_sve_addr_zz_sxtw,
	aarch64_ins_sve_addr_zz_uxtw, aarch64_ins_sve_aimm,
	aarch64_ins_sve_asimm, aarch64_ins_sve_index, aarch64_ins_sve_limm_mov,
	aarch64_ins_sve_quad_index, aarch64_ins_sve_reglist,
	aarch64_ins_sve_scale, aarch64_ins_sve_shlimm, aarch64_ins_sve_shrimm,
	aarch64_ins_sve_float_half_one, aarch64_ins_sve_float_half_two,
	aarch64_ins_sve_float_zero_one, aarch64_opcode_encode): Likewise.
	* aarch64-dis.h (aarch64_extract_operand, aarch64_##x): Likewise.
	* aarch64-dis.c (aarch64_ext_regno, aarch64_ext_reglane,
	aarch64_ext_reglist, aarch64_ext_ldst_reglist,
	aarch64_ext_ldst_reglist_r, aarch64_ext_ldst_elemlist,
	aarch64_ext_advsimd_imm_shift, aarch64_ext_imm, aarch64_ext_imm_half,
	aarch64_ext_advsimd_imm_modified, aarch64_ext_fpimm,
	aarch64_ext_imm_rotate1, aarch64_ext_imm_rotate2, aarch64_ext_fbits,
	aarch64_ext_aimm, aarch64_ext_limm_1, aarch64_ext_limm, decode_limm,
	aarch64_ext_inv_limm, aarch64_ext_ft, aarch64_ext_addr_simple,
	aarch64_ext_addr_regoff, aarch64_ext_addr_offset, aarch64_ext_addr_simm,
	aarch64_ext_addr_simm10, aarch64_ext_addr_uimm12,
	aarch64_ext_simd_addr_post, aarch64_ext_cond, aarch64_ext_sysreg,
	aarch64_ext_pstatefield, aarch64_ext_sysins_op, aarch64_ext_barrier,
	aarch64_ext_prfop, aarch64_ext_hint, aarch64_ext_reg_extended,
	aarch64_ext_reg_shifted, aarch64_ext_sve_addr_ri_s4xvl,
	aarch64_ext_sve_addr_ri_s6xvl, aarch64_ext_sve_addr_ri_s9xvl,
	aarch64_ext_sve_addr_ri_s4, aarch64_ext_sve_addr_ri_u6,
	aarch64_ext_sve_addr_rr_lsl, aarch64_ext_sve_addr_rz_xtw,
	aarch64_ext_sve_addr_zi_u5, aarch64_ext_sve_addr_zz,
	aarch64_ext_sve_addr_zz_lsl, aarch64_ext_sve_addr_zz_sxtw,
	aarch64_ext_sve_addr_zz_uxtw, aarch64_ext_sve_aimm,
	aarch64_ext_sve_asimm, aarch64_ext_sve_index, aarch64_ext_sve_limm_mov,
	aarch64_ext_sve_quad_index, aarch64_ext_sve_reglist,
	aarch64_ext_sve_scale, aarch64_ext_sve_shlimm, aarch64_ext_sve_shrimm,
	aarch64_ext_sve_float_half_one, aarch64_ext_sve_float_half_two,
	aarch64_ext_sve_float_zero_one, aarch64_opcode_decode): Likewise.
	(determine_disassembling_preference, aarch64_decode_insn,
	print_insn_aarch64_word, print_insn_data): Take errors struct.
	(print_insn_aarch64): Use errors.
	* aarch64-asm-2.c: Regenerate.
	* aarch64-dis-2.c: Regenerate.
	* aarch64-gen.c (print_operand_inserter): Use errors and change type to
	boolean in aarch64_insert_operan.
	(print_operand_extractor): Likewise.
	* aarch64-opc.c (aarch64_print_operand): Use sysreg struct.

Failures on Fedora-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	marist-fedora-s390x

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-s390x-m64/builds/8499>

Commit(s) tested:
	561a72d4ddf825ffaf8e88551e9bd6707cd6c59f

Author(s) (in the same order as the commits):
	Tamar Christina <tamar.christina@arm.com>

Subject:
	Modify AArch64 Assembly and disassembly functions to be able to fail and report why.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-s390x-m64/56/561a72d4ddf825ffaf8e88551e9bd6707cd6c59f/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.gdb/unittest.exp: maintenance check xml-descriptions ${srcdir}/../features
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-s390x-m64/xfails/master/xfail?id=d48b9f4>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-s390x-m64/xfails/master/xfail.table?id=d48b9f4>

Failures on Debian-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-m64/builds/5299>

Commit(s) tested:
	561a72d4ddf825ffaf8e88551e9bd6707cd6c59f

Author(s) (in the same order as the commits):
	Tamar Christina <tamar.christina@arm.com>

Subject:
	Modify AArch64 Assembly and disassembly functions to be able to fail and report why.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-m64/56/561a72d4ddf825ffaf8e88551e9bd6707cd6c59f/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-m64/xfails/master/xfail?id=ceb3c6c>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-m64/xfails/master/xfail.table?id=ceb3c6c>

Failures on Debian-s390x-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-native-gdbserver-m64/builds/5349>

Commit(s) tested:
	561a72d4ddf825ffaf8e88551e9bd6707cd6c59f

Author(s) (in the same order as the commits):
	Tamar Christina <tamar.christina@arm.com>

Subject:
	Modify AArch64 Assembly and disassembly functions to be able to fail and report why.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-native-gdbserver-m64/56/561a72d4ddf825ffaf8e88551e9bd6707cd6c59f/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-native-gdbserver-m64/xfails/master/xfail?id=2794f01>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-native-gdbserver-m64/xfails/master/xfail.table?id=2794f01>

Failures on Fedora-x86_64-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/9711>

Commit(s) tested:
	561a72d4ddf825ffaf8e88551e9bd6707cd6c59f

Author(s) (in the same order as the commits):
	Tamar Christina <tamar.christina@arm.com>

Subject:
	Modify AArch64 Assembly and disassembly functions to be able to fail and report why.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m64/56/561a72d4ddf825ffaf8e88551e9bd6707cd6c59f/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m64/xfails/master/xfail?id=370beeb>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m64/xfails/master/xfail.table?id=370beeb>

Failures on Fedora-x86_64-cc-with-index, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/9607>

Commit(s) tested:
	561a72d4ddf825ffaf8e88551e9bd6707cd6c59f

Author(s) (in the same order as the commits):
	Tamar Christina <tamar.christina@arm.com>

Subject:
	Modify AArch64 Assembly and disassembly functions to be able to fail and report why.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-cc-with-index/56/561a72d4ddf825ffaf8e88551e9bd6707cd6c59f/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail?id=6ab5eec>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail.table?id=6ab5eec>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m64/builds/9698>

Commit(s) tested:
	561a72d4ddf825ffaf8e88551e9bd6707cd6c59f

Author(s) (in the same order as the commits):
	Tamar Christina <tamar.christina@arm.com>

Subject:
	Modify AArch64 Assembly and disassembly functions to be able to fail and report why.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m64/56/561a72d4ddf825ffaf8e88551e9bd6707cd6c59f/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail?id=72a6aac>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail.table?id=72a6aac>

*** COMPILATION FAILED *** Failures on Fedora-x86_64-w64-mingw32, branch master *** BREAKAGE ***

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-w64-mingw32/builds/1619>

Commit(s) tested:
	561a72d4ddf825ffaf8e88551e9bd6707cd6c59f

Author(s) (in the same order as the commits):
	Tamar Christina <tamar.christina@arm.com>

Subject:
	Modify AArch64 Assembly and disassembly functions to be able to fail and report why.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-w64-mingw32/56/561a72d4ddf825ffaf8e88551e9bd6707cd6c59f/>

*** Failed to compiled GDB.  ***
============================

+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

  CXX    s390-linux-tdep.o
  CXX    s390-tdep.o
  CXX    score-tdep.o
  CXX    sh-linux-tdep.o
  CXX    sh-nbsd-tdep.o
  CXX    sh-tdep.o
  CXX    sol2-tdep.o
  CXX    solib-aix.o
  CXX    solib-darwin.o
  CXX    solib-dsbt.o
  CXX    solib-frv.o
  CXX    solib-spu.o
  CXX    solib-svr4.o
  CXX    sparc-linux-tdep.o
  CXX    sparc-nbsd-tdep.o
  CXX    sparc-obsd-tdep.o
  CXX    sparc-ravenscar-thread.o
  CXX    sparc-sol2-tdep.o
  CXX    sparc-tdep.o
  CXX    spu-multiarch.o
  CXX    spu-tdep.o
  CXX    symfile-mem.o
  CXX    tic6x-linux-tdep.o
  CXX    tic6x-tdep.o
  CXX    tilegx-linux-tdep.o
  CXX    tilegx-tdep.o
  CXX    v850-tdep.o
  CXX    vax-nbsd-tdep.o
  CXX    vax-tdep.o
  CXX    windows-tdep.o
  CXX    x86-tdep.o
  CXX    xcoffread.o
  CXX    xstormy16-tdep.o
  CXX    xtensa-config.o
  CXX    xtensa-linux-tdep.o
  CXX    xtensa-tdep.o
  CXX    aarch64-fbsd-tdep.o
  CXX    aarch64-linux-tdep.o
  CXX    aarch64-newlib-tdep.o
  CXX    aarch64-tdep.o
  CXX    alpha-bsd-tdep.o
  CXX    alpha-linux-tdep.o
  CXX    alpha-mdebug-tdep.o
  CXX    alpha-nbsd-tdep.o
  CXX    alpha-obsd-tdep.o
  CXX    alpha-tdep.o
  CXX    amd64-darwin-tdep.o
  CXX    amd64-dicos-tdep.o
  CXX    amd64-fbsd-tdep.o
  CXX    amd64-linux-tdep.o
  CXX    amd64-nbsd-tdep.o
  CXX    amd64-obsd-tdep.o
  CXX    amd64-sol2-tdep.o
  CXX    amd64-tdep.o
  CXX    amd64-windows-tdep.o
  CXX    arch/aarch64.o
  CXX    arch/aarch64-insn.o
  CXX    arch/amd64.o
  CXX    ia64-linux-tdep.o
  CXX    ia64-tdep.o
  CXX    ia64-vms-tdep.o
  CXX    mips64-obsd-tdep.o
  CXX    sparc64-fbsd-tdep.o
  CXX    sparc64-linux-tdep.o
  CXX    sparc64-nbsd-tdep.o
  CXX    sparc64-obsd-tdep.o
  CXX    sparc64-sol2-tdep.o
  CXX    sparc64-tdep.o
  CXX    ser-base.o
  CXX    ser-tcp.o
  CXX    ser-mingw.o
  CXX    x86-nat.o
  CXX    x86-dregs.o
  CXX    windows-nat.o
  CXX    amd64-windows-nat.o
  CXX    cli/cli-cmds.o
  CXX    cli/cli-decode.o
  CXX    cli/cli-dump.o
  CXX    cli/cli-interp.o
../../binutils-gdb/gdb/windows-nat.c: In function 'handle_exception_result handle_exception(target_waitstatus*)':
../../binutils-gdb/gdb/windows-nat.c:1255:2: error: this statement may fall through [-Werror=implicit-fallthrough=]
  }
  ^
../../binutils-gdb/gdb/windows-nat.c:1257:5: note: here
     default:
     ^~~~~~~
  CXX    cli/cli-logging.o
../../binutils-gdb/gdb/windows-nat.c: In member function 'virtual void windows_nat_target::create_inferior(const char*, const string&, char**, int)':
../../binutils-gdb/gdb/windows-nat.c:2795:26: warning: 'shell[0]' may be used uninitialized in this function [-Wmaybe-uninitialized]
   if (useshell && shell[0] != '\0')
                   ~~~~~~~^
cc1plus: all warnings being treated as errors
  CXX    cli/cli-script.o
make[2]: *** [Makefile:1610: windows-nat.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-mingw32/build/gdb'
make[1]: Leaving directory '/home/gdb-buildbot/fedora-x86-64-3/fedora-x86-64-mingw32/build'
make[1]: *** [Makefile:8800: all-gdb] Error 2
make: *** [Makefile:857: all] Error 2
============================

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m64/builds/9652>

Commit(s) tested:
	561a72d4ddf825ffaf8e88551e9bd6707cd6c59f

Author(s) (in the same order as the commits):
	Tamar Christina <tamar.christina@arm.com>

Subject:
	Modify AArch64 Assembly and disassembly functions to be able to fail and report why.

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m64/56/561a72d4ddf825ffaf8e88551e9bd6707cd6c59f/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail?id=e410651>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-gdbserver-m64/xfails/master/xfail.table?id=e410651>