public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] Remove gdb workaround from readline/complete.c Date: Mon, 12 Aug 2019 19:04:00 -0000 [thread overview] Message-ID: <57a2fe070226852b84eff8f37e49b367daa2a32f@gdb-build> (raw) *** TEST RESULTS FOR COMMIT 57a2fe070226852b84eff8f37e49b367daa2a32f *** commit 57a2fe070226852b84eff8f37e49b367daa2a32f Author: Tom Tromey <tom@tromey.com> AuthorDate: Sun Oct 7 15:24:12 2018 -0600 Commit: Tom Tromey <tom@tromey.com> CommitDate: Mon Aug 12 10:57:56 2019 -0600 Remove gdb workaround from readline/complete.c This removes a gdb-local patch from readline's get_y_or_n. The code references a gdb test that continues to work when I remove this patch. So, I think it is not needed any more. readline/ChangeLog.gdb 2018-10-07 Tom Tromey <tom@tromey.com> * complete.c (get_y_or_n): Remove gdb workaround. diff --git a/readline/ChangeLog.gdb b/readline/ChangeLog.gdb index fb53dc604c..7125d4d43f 100644 --- a/readline/ChangeLog.gdb +++ b/readline/ChangeLog.gdb @@ -1,5 +1,9 @@ 2019-08-12 Tom Tromey <tom@tromey.com> + * complete.c (get_y_or_n): Remove gdb workaround. + +2018-08-12 Tom Tromey <tom@tromey.com> + * Imported readline 7.0 patch 5. 2019-07-12 Tom de Vries <tdevries@suse.de> diff --git a/readline/complete.c b/readline/complete.c index ac54d76a25..0a81129b87 100644 --- a/readline/complete.c +++ b/readline/complete.c @@ -528,17 +528,12 @@ get_y_or_n (for_pager) { int c; -/* Disabled for GDB due to the gdb.base/readline-ask.exp regression. - [patch] testsuite: Test readline-6.2 "ask" regression - http://sourceware.org/ml/gdb-patches/2011-05/msg00002.html */ -#if 0 /* For now, disable pager in callback mode, until we later convert to state driven functions. Have to wait until next major version to add new state definition, since it will change value of RL_STATE_DONE. */ #if defined (READLINE_CALLBACKS) if (RL_ISSTATE (RL_STATE_CALLBACK)) return 1; -#endif #endif for (;;)
next reply other threads:[~2019-08-12 18:49 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-12 19:04 gdb-buildbot [this message] 2019-08-12 19:12 ` Failures on Fedora-i686, branch master gdb-buildbot 2019-08-12 19:23 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot 2019-08-12 19:23 ` Failures on Fedora-x86_64-m32, " gdb-buildbot 2019-08-12 19:49 ` Failures on Fedora-x86_64-m64, " gdb-buildbot 2019-08-12 20:16 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot 2019-08-12 20:34 ` *** COMPILATION FAILED *** Failures on Fedora-x86_64-w64-mingw32, branch master *** BREAKAGE *** gdb-buildbot 2019-08-12 20:44 ` Failures on Fedora-x86_64-native-gdbserver-m32, branch master gdb-buildbot 2019-08-12 20:44 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot 2019-08-12 21:12 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=57a2fe070226852b84eff8f37e49b367daa2a32f@gdb-build \ --to=gdb-buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).