[binutils-gdb] Remove ALL_OBJFILE_COMPUNITS

[binutils-gdb] Remove ALL_OBJFILE_COMPUNITS

[sergiodj+buildbot]

*** TEST RESULTS FOR COMMIT 592553c46959c98bf5981ad245d0fbb97f373d2a ***

Author: Tom Tromey <tom@tromey.com>
Branch: master
Commit: 592553c46959c98bf5981ad245d0fbb97f373d2a

Remove ALL_OBJFILE_COMPUNITS

This removes ALL_OBJFILE_COMPUNITS, replacing its uses with ranged for
loops.  Because ALL_COMPUNITS is also updated, in some places a
declaration must be deleted to avoid shadowing.

gdb/ChangeLog
2019-01-09  Tom Tromey  <tom@tromey.com>

	* source.c (select_source_symtab)
	(forget_cached_source_info_for_objfile): Remove declaration.
	* mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
	declaration.
	* maint.c (count_symtabs_and_blocks): Remove declaration.
	* cp-support.c (add_symbol_overload_list_qualified): Remove
	declaration.
	* coffread.c (coff_symtab_read): Remove declaration.
	* symtab.c (lookup_symbol_in_objfile_symtabs)
	(basic_lookup_transparent_type_1): Use objfile_compunits.
	(lookup_objfile_from_block, find_pc_sect_compunit_symtab)
	(info_sources_command, search_symbols)
	(default_collect_symbol_completion_matches_break_on)
	(make_source_files_completion_list): Remove declaration.
	* ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
	(ada_collect_symbol_completion_matches)
	(ada_add_global_exceptions): Remove declaration.
	* linespec.c (iterate_over_all_matching_symtabs): Use
	objfile_compunits.
	* objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
	(class objfile_compunits): New.
	(ALL_COMPUNITS): Use objfile_compunits.
	* symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
	(maintenance_check_symtabs, maintenance_info_line_tables): Use
	objfile_compunits.
	* objfiles.c (objfile_relocate1): Use objfile_compunits.

Failures on RHEL-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	rhel-7_1-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/RHEL-s390x-m64/builds/9069>

Commit(s) tested:
	592553c46959c98bf5981ad245d0fbb97f373d2a

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	Remove ALL_OBJFILE_COMPUNITS

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/RHEL-s390x-m64/59/592553c46959c98bf5981ad245d0fbb97f373d2a/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.threads/watchpoint-fork.exp: parent: multithreaded: watchpoint B after the second fork
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/RHEL-s390x-m64/xfails/master/xfail?id=0f95abf1>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/RHEL-s390x-m64/xfails/master/xfail.table?id=0f95abf1>

Failures on Debian-s390x-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-native-extended-gdbserver-m64/builds/7375>

Commit(s) tested:
	592553c46959c98bf5981ad245d0fbb97f373d2a

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	Remove ALL_OBJFILE_COMPUNITS

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-native-extended-gdbserver-m64/59/592553c46959c98bf5981ad245d0fbb97f373d2a/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-native-extended-gdbserver-m64/xfails/master/xfail?id=80f3ecfc>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-native-extended-gdbserver-m64/xfails/master/xfail.table?id=80f3ecfc>

Failures on Debian-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	debian-jessie-s390x-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-s390x-m64/builds/7188>

Commit(s) tested:
	592553c46959c98bf5981ad245d0fbb97f373d2a

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	Remove ALL_OBJFILE_COMPUNITS

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Debian-s390x-m64/59/592553c46959c98bf5981ad245d0fbb97f373d2a/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-m64/xfails/master/xfail?id=628a9f58>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Debian-s390x-m64/xfails/master/xfail.table?id=628a9f58>

Failures on Fedora-i686, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/11817>

Commit(s) tested:
	592553c46959c98bf5981ad245d0fbb97f373d2a

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	Remove ALL_OBJFILE_COMPUNITS

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-i686/59/592553c46959c98bf5981ad245d0fbb97f373d2a/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-i686/xfails/master/xfail?id=a7b926fb>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-i686/xfails/master/xfail.table?id=a7b926fb>

Failures on Fedora-x86_64-cc-with-index, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-2

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/11731>

Commit(s) tested:
	592553c46959c98bf5981ad245d0fbb97f373d2a

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	Remove ALL_OBJFILE_COMPUNITS

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-cc-with-index/59/592553c46959c98bf5981ad245d0fbb97f373d2a/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail?id=a75e482e>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail.table?id=a75e482e>

Failures on Fedora-x86_64-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-2

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m64/builds/11880>

Commit(s) tested:
	592553c46959c98bf5981ad245d0fbb97f373d2a

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	Remove ALL_OBJFILE_COMPUNITS

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m64/59/592553c46959c98bf5981ad245d0fbb97f373d2a/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m64/xfails/master/xfail?id=08dc9573>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m64/xfails/master/xfail.table?id=08dc9573>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-extended-gdbserver-m64/builds/11768>

Commit(s) tested:
	592553c46959c98bf5981ad245d0fbb97f373d2a

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	Remove ALL_OBJFILE_COMPUNITS

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-extended-gdbserver-m64/59/592553c46959c98bf5981ad245d0fbb97f373d2a/>

*** Diff to previous build ***
============================
new UNRESOLVED: gdb.ada/packed_array.exp: delete all breakpoints in delete_breakpoints
PASS -> FAIL: gdb.ada/packed_array.exp: print &var
PASS -> FAIL: gdb.ada/packed_array.exp: print u_var
PASS -> UNRESOLVED: gdb.ada/packed_array.exp: print var
PASS -> FAIL: gdb.ada/packed_array.exp: ptype &var
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> UNRESOLVED: gdb.trace/tspeed.exp: print iters = init_iters
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail?id=31f6afe2>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-extended-gdbserver-m64/xfails/master/xfail.table?id=31f6afe2>

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m32/builds/11502>

Commit(s) tested:
	592553c46959c98bf5981ad245d0fbb97f373d2a

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	Remove ALL_OBJFILE_COMPUNITS

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-native-gdbserver-m32/59/592553c46959c98bf5981ad245d0fbb97f373d2a/>

*** Diff to previous build ***
============================
new FAIL: gdb.base/corefile.exp: core-file warning-free
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-gdbserver-m32/xfails/master/xfail?id=a174b03e>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-native-gdbserver-m32/xfails/master/xfail.table?id=a174b03e>

Failures on Fedora-x86_64-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-2

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-m32/builds/11569>

Commit(s) tested:
	592553c46959c98bf5981ad245d0fbb97f373d2a

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	Remove ALL_OBJFILE_COMPUNITS

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-x86_64-m32/59/592553c46959c98bf5981ad245d0fbb97f373d2a/>

*** Diff to previous build ***
============================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m32/xfails/master/xfail?id=da29ec11>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Fedora-x86_64-m32/xfails/master/xfail.table?id=da29ec11>

Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu16-aarch64

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-Aarch64-native-extended-gdbserver-m64/builds/422>

Commit(s) tested:
	592553c46959c98bf5981ad245d0fbb97f373d2a

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	Remove ALL_OBJFILE_COMPUNITS

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/59/592553c46959c98bf5981ad245d0fbb97f373d2a/>

Failures on Ubuntu-Aarch64-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	ubuntu16-aarch64

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Ubuntu-Aarch64-native-gdbserver-m64/builds/4791>

Commit(s) tested:
	592553c46959c98bf5981ad245d0fbb97f373d2a

Author(s) (in the same order as the commits):
	Tom Tromey <tom@tromey.com>

Subject:
	Remove ALL_OBJFILE_COMPUNITS

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Ubuntu-Aarch64-native-gdbserver-m64/59/592553c46959c98bf5981ad245d0fbb97f373d2a/>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.ada/packed_tagged.exp: ptype x
PASS -> FAIL: gdb.base/break.exp: run until breakpoint set at a line number
PASS -> FAIL: gdb.base/ena-dis-br.exp: prepare to continue with ignore count
PASS -> FAIL: gdb.base/find.exp: pattern found at end of range
PASS -> UNRESOLVED: gdb.base/hbreak2.exp: hardware breakpoint line number
new UNRESOLVED: gdb.base/sepdebug.exp: next over recursive call
PASS -> FAIL: gdb.base/sigstep.exp: displaced=off: step on breakpoint, to handler: set itimer = itimer_real
PASS -> FAIL: gdb.base/sigstep.exp: displaced=off: stepi on breakpoint, skip handler, with sw-watchpoint, no handler: set no_handler
PASS -> FAIL: gdb.base/sigstep.exp: displaced=on: continue on breakpoint, skip handler, with sw-watchpoint: set itimer = itimer_real
PASS -> FAIL: gdb.base/sigstep.exp: displaced=on: step on breakpoint, skip handler, with sw-watchpoint: set itimer = itimer_real
PASS -> FAIL: gdb.base/solib-weak.exp: run to breakpoint - lib1 nodebug, lib2 nodebug, lib1 first
PASS -> FAIL: gdb.base/step-bt.exp: backtrace after second instruction step
PASS -> FAIL: gdb.cp/rvalue-ref-params.exp: print mf2
PASS -> FAIL: gdb.mi/gdb669.exp: -thread-list-ids
PASS -> FAIL: gdb.mi/gdb669.exp: -thread_list_ids
PASS -> FAIL: gdb.mi/gdb669.exp: MI and console have same threads
PASS -> FAIL: gdb.mi/gdb669.exp: console and MI have same number of threads
PASS -> FAIL: gdb.mi/gdb669.exp: finding MI result string
PASS -> FAIL: gdb.mi/gdb669.exp: finding number of threads in MI output
PASS -> FAIL: gdb.mi/gdb669.exp: finding threads in MI output
PASS -> FAIL: gdb.mi/gdb669.exp: info threads
PASS -> FAIL: gdb.mi/gdb669.exp: next, try 1
PASS -> FAIL: gdb.mi/gdb669.exp: next, try 2
PASS -> FAIL: gdb.mi/gdb669.exp: next, try 3
PASS -> FAIL: gdb.mi/mi-breakpoint-location-ena-dis.exp: dis 2.2
PASS -> FAIL: gdb.mi/mi-breakpoint-location-ena-dis.exp: en 2.2
PASS -> FAIL: gdb.mi/mi-condbreak-call-thr-state.exp: st: no spurious *running notifications
PASS -> FAIL: gdb.mi/mi-dprintf.exp: call: mi 2nd dprintf
PASS -> FAIL: gdb.mi/mi-dprintf.exp: call: mi 2nd dprintf stop
PASS -> FAIL: gdb.mi/mi-dprintf.exp: fprintf: mi 2nd dprintf
PASS -> FAIL: gdb.mi/mi-dprintf.exp: fprintf: mi 2nd dprintf stop
PASS -> FAIL: gdb.mi/mi-read-memory.exp: expression in quotes
PASS -> FAIL: gdb.mi/mi-threads-interrupt.exp: interrupt reported
PASS -> FAIL: gdb.mi/mi-var-cmd.exp: in-and-out-of-scope: in scope now
PASS -> FAIL: gdb.mi/mi-var-cmd.exp: in-and-out-of-scope: in scope now, not changed
new UNRESOLVED: gdb.python/py-type.exp: lang_cpp: setting breakpoint at 117
new FAIL: gdb.reverse/consecutive-reverse.exp: setting breakpoint at foo
PASS -> FAIL: gdb.reverse/machinestate-precsave.exp: breakpoint at end of main
new FAIL: gdb.reverse/machinestate.exp: break 100
PASS -> FAIL: gdb.reverse/pipe-reverse.exp: set breakpoint at marker2
PASS -> FAIL: gdb.reverse/recvmsg-reverse.exp: reverse to marker1
PASS -> FAIL: gdb.reverse/recvmsg-reverse.exp: set breakpoint at marker2
PASS -> FAIL: gdb.reverse/sigall-precsave.exp: breakpoint at end of main
PASS -> FAIL: gdb.reverse/solib-precsave.exp: breakpoint at end of main
PASS -> FAIL: gdb.reverse/solib-reverse.exp: forward to end part one
PASS -> FAIL: gdb.reverse/solib-reverse.exp: reverse-next first shr1
PASS -> FAIL: gdb.reverse/solib-reverse.exp: reverse-next generic
PASS -> FAIL: gdb.reverse/solib-reverse.exp: reverse-next second shr1
PASS -> FAIL: gdb.reverse/solib-reverse.exp: reverse-next third shr1
PASS -> FAIL: gdb.reverse/solib-reverse.exp: reverse-step first shr1
PASS -> FAIL: gdb.reverse/solib-reverse.exp: reverse-step generic
PASS -> FAIL: gdb.reverse/solib-reverse.exp: reverse-step second shr1
PASS -> FAIL: gdb.reverse/solib-reverse.exp: reverse-step third shr1
PASS -> FAIL: gdb.reverse/solib-reverse.exp: run until end part one
PASS -> FAIL: gdb.reverse/until-precsave.exp: breakpoint at end of main
PASS -> FAIL: gdb.reverse/until-reverse.exp: until line number
PASS -> FAIL: gdb.threads/execl.exp: set breakpoint at execl
PASS -> FAIL: gdb.threads/linux-dp.exp: info threads 1
new FAIL: gdb.threads/linux-dp.exp: setting breakpoint at 192
PASS -> FAIL: gdb.threads/manythreads.exp: first continue
PASS -> FAIL: gdb.threads/manythreads.exp: shell stty intr '^C'
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr3: queue-signal SIGUSR1
PASS -> FAIL: gdb.threads/print-threads.exp: break thread_function
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Ubuntu-Aarch64-native-gdbserver-m64/xfails/master/xfail?id=22175446>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<https://git.sergiodj.net/gdb-xfails.git/tree/xfails/Ubuntu-Aarch64-native-gdbserver-m64/xfails/master/xfail.table?id=22175446>