public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Remove "show" command completers, "set" command completers for string commands
@ 2019-06-13  2:25 sergiodj+buildbot
  2019-06-13  2:27 ` Failures on RHEL-s390x-m64, branch master sergiodj+buildbot
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: sergiodj+buildbot @ 2019-06-13  2:25 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 597bf39df91c9a2e27cf1966dd4c942ac645ae33 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 597bf39df91c9a2e27cf1966dd4c942ac645ae33

Remove "show" command completers, "set" command completers for string commands

The default command completer is symbol_completer, but it makes no
sense for a "show" command to complete on symbols, or anything else,
really.

I wonder whether we should instead make the default be no completer.
That seems like a much larger/complicated audit/change, so I'd like to
move forward with this version, as it'll be covered by tests.  I
noticed this because a following patch will add a new
gdb.base/settings.exp testcase that exercises all sorts of details of
settings commands, including completing the show commands, using new
representative "maint test-settings <type or settings command>"
commands.

Also remove the completer for var_string and var_string_noescape
commands.  No point in completing symbols when GDB is expecting a
string.

gdb/ChangeLog:
2019-06-13  Pedro Alves  <palves@redhat.com>

	* cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
	completer.
	(add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
	"set" completers.


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-06-13  7:52 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-13  2:25 [binutils-gdb] Remove "show" command completers, "set" command completers for string commands sergiodj+buildbot
2019-06-13  2:27 ` Failures on RHEL-s390x-m64, branch master sergiodj+buildbot
2019-06-13  8:40 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
2019-06-13  9:01 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2019-06-13  9:11 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot
2019-06-13  9:27 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2019-06-13  9:27 ` Failures on Fedora-i686, " sergiodj+buildbot
2019-06-13  9:30 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot
2019-06-13  9:54 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).