public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] [gdb/testsuite] Fix stepi pattern in gdb.btrace/reconnect.exp
Date: Fri, 20 Mar 2020 07:07:59 -0400 [thread overview]
Message-ID: <5a13315d1c6993ab84075ff94797eb8c6da1f20b@gdb-build> (raw)
*** TEST RESULTS FOR COMMIT 5a13315d1c6993ab84075ff94797eb8c6da1f20b ***
commit 5a13315d1c6993ab84075ff94797eb8c6da1f20b
Author: Tom de Vries <tdevries@suse.de>
AuthorDate: Wed Mar 11 16:51:54 2020 +0100
Commit: Tom de Vries <tdevries@suse.de>
CommitDate: Wed Mar 11 16:51:54 2020 +0100
[gdb/testsuite] Fix stepi pattern in gdb.btrace/reconnect.exp
When running gdb.btrace/reconnect.exp, I run into the follow FAIL:
...
(gdb) stepi 19^M
0x00007ffff7dd8b67 59 return (ElfW(Addr)) &_DYNAMIC - \
elf_machine_dynamic ();^M
(gdb) FAIL: gdb.btrace/reconnect.exp: first: stepi 19
...
The corresponding test looks like:
...
gdb_test "stepi 19" "0x.* in .* from .*"
...
which matches the usual:
...
(gdb) stepi 19^M
0x00007ffff7dd8b67 in _dl_start () from target:/lib64/ld-linux-x86-64.so.2^M
(gdb) PASS: gdb.btrace/reconnect.exp: first: stepi 19
...
which I also get when removing configure flag
--with-separate-debug-dir=/usr/lib/debug.
Fix this by allowing the source line pattern in the test regexp.
Tested on x86_64-linux.
gdb/testsuite/ChangeLog:
2020-03-11 Tom de Vries <tdevries@suse.de>
* gdb.btrace/reconnect.exp: Allow source line pattern after stepi.
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 78505f1169..5613e86261 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2020-03-11 Tom de Vries <tdevries@suse.de>
+
+ * gdb.btrace/reconnect.exp: Allow source line pattern after stepi.
+
2020-03-11 Tom Tromey <tromey@adacore.com>
* gdb.dwarf2/variant.exp: Mark discriminants as artificial.
diff --git a/gdb/testsuite/gdb.btrace/reconnect.exp b/gdb/testsuite/gdb.btrace/reconnect.exp
index 4c31577eef..26d04c38a9 100644
--- a/gdb/testsuite/gdb.btrace/reconnect.exp
+++ b/gdb/testsuite/gdb.btrace/reconnect.exp
@@ -51,7 +51,7 @@ gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport
# Create a record, check, reconnect
with_test_prefix "first" {
gdb_test_no_output "record btrace" "record btrace enable"
- gdb_test "stepi 19" "0x.* in .* from .*"
+ gdb_test "stepi 19" "($hex in .* from .*|$hex\t$decimal.*)"
gdb_test "info record" [multi_line \
"Active record target: .*" \
next reply other threads:[~2020-03-20 11:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 11:07 gdb-buildbot [this message]
2020-03-20 11:08 ` Failures on Fedora-i686, branch master gdb-buildbot
2020-03-20 11:36 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2020-03-20 11:39 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2020-03-20 12:18 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2020-03-20 15:04 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2020-03-22 20:00 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot
2020-03-23 13:05 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a13315d1c6993ab84075ff94797eb8c6da1f20b@gdb-build \
--to=gdb-buildbot@sergiodj.net \
--cc=gdb-testers@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).