[binutils-gdb] Rewrite ada_value_print_inner

[binutils-gdb] Rewrite ada_value_print_inner

[gdb-buildbot]

*** TEST RESULTS FOR COMMIT 5b5e15ecddafc43de2da632aa68f935a879d9a91 ***

commit 5b5e15ecddafc43de2da632aa68f935a879d9a91
Author:     Tom Tromey <tom@tromey.com>
AuthorDate: Fri Mar 13 17:39:52 2020 -0600
Commit:     Tom Tromey <tom@tromey.com>
CommitDate: Fri Mar 13 18:03:41 2020 -0600

    Rewrite ada_value_print_inner
    
    This rewrites ada_value_print_inner, introducing a new
    ada_value_print_1, an analogue of ada_val_print_1.  Because it was
    simple to do, this also converts ada_val_print_gnat_array to be
    valued-based and updates the uses.
    
    gdb/ChangeLog
    2020-03-13  Tom Tromey  <tom@tromey.com>
    
            * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
            call common_val_print.
            (ada_val_print_1): Update.
            (ada_value_print_1): New function.
            (ada_value_print_inner): Rewrite.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index dea6a8d286..74146ef03b 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,11 @@
+2020-03-13  Tom Tromey  <tom@tromey.com>
+
+	* ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
+	call common_val_print.
+	(ada_val_print_1): Update.
+	(ada_value_print_1): New function.
+	(ada_value_print_inner): Rewrite.
+
 2020-03-13  Tom Tromey  <tom@tromey.com>
 
 	* cp-valprint.c (cp_print_value_fields): Update.
diff --git a/gdb/ada-valprint.c b/gdb/ada-valprint.c
index c983cbbab7..3c389d6353 100644
--- a/gdb/ada-valprint.c
+++ b/gdb/ada-valprint.c
@@ -762,16 +762,14 @@ ada_val_print_string (struct type *type, const gdb_byte *valaddr,
    thin pointers, etc).  */
 
 static void
-ada_val_print_gnat_array (struct type *type, const gdb_byte *valaddr,
-			  int offset, CORE_ADDR address,
+ada_val_print_gnat_array (struct value *val,
 			  struct ui_file *stream, int recurse,
-			  struct value *original_value,
 			  const struct value_print_options *options)
 {
-  struct value *mark = value_mark ();
-  struct value *val;
+  scoped_value_mark free_values;
+
+  struct type *type = ada_check_typedef (value_type (val));
 
-  val = value_from_contents_and_address (type, valaddr + offset, address);
   /* If this is a reference, coerce it now.  This helps taking care
      of the case where ADDRESS is meaningless because original_value
      was not an lval.  */
@@ -786,11 +784,8 @@ ada_val_print_gnat_array (struct type *type, const gdb_byte *valaddr,
       fprintf_filtered (stream, "0x0");
     }
   else
-    val_print (value_type (val),
-	       value_embedded_offset (val), value_address (val),
-	       stream, recurse, val, options,
-	       language_def (language_ada));
-  value_free_to_mark (mark);
+    common_val_print (val, stream, recurse, options,
+		      language_def (language_ada));
 }
 
 /* Implement Ada val_print'ing for the case where TYPE is
@@ -1135,9 +1130,10 @@ ada_val_print_1 (struct type *type,
       || (ada_is_constrained_packed_array_type (type)
 	  && TYPE_CODE (type) != TYPE_CODE_PTR))
     {
-      ada_val_print_gnat_array (type, valaddr, offset, address,
-				stream, recurse, original_value,
-				options);
+      struct value *val = value_from_contents_and_address (type,
+							   valaddr + offset,
+							   address);
+      ada_val_print_gnat_array (val, stream, recurse, options);
       return;
     }
 
@@ -1222,6 +1218,90 @@ ada_val_print (struct type *type,
     }
 }
 
+/* See the comment on ada_value_print.  This function differs in that
+   it does not catch evaluation errors (leaving that to
+   ada_value_print).  */
+
+static void
+ada_value_print_1 (struct value *val, struct ui_file *stream, int recurse,
+		   const struct value_print_options *options)
+{
+  struct type *type = ada_check_typedef (value_type (val));
+
+  if (ada_is_array_descriptor_type (type)
+      || (ada_is_constrained_packed_array_type (type)
+	  && TYPE_CODE (type) != TYPE_CODE_PTR))
+    {
+      ada_val_print_gnat_array (val, stream, recurse, options);
+      return;
+    }
+
+  val = ada_to_fixed_value (val);
+  type = value_type (val);
+  struct type *saved_type = type;
+
+  const gdb_byte *valaddr = value_contents_for_printing (val);
+  CORE_ADDR address = value_address (val);
+  type = ada_check_typedef (resolve_dynamic_type (type, valaddr, address));
+  if (type != saved_type)
+    {
+      val = value_copy (val);
+      deprecated_set_value_type (val, type);
+    }
+
+  switch (TYPE_CODE (type))
+    {
+    default:
+      common_val_print (val, stream, recurse, options,
+			language_def (language_c));
+      break;
+
+    case TYPE_CODE_PTR:
+      ada_val_print_ptr (type, valaddr, 0, 0,
+			 address, stream, recurse, val,
+			 options);
+      break;
+
+    case TYPE_CODE_INT:
+    case TYPE_CODE_RANGE:
+      ada_val_print_num (type, valaddr, 0, 0,
+			 address, stream, recurse, val,
+			 options);
+      break;
+
+    case TYPE_CODE_ENUM:
+      ada_val_print_enum (type, valaddr, 0, 0,
+			  address, stream, recurse, val,
+			  options);
+      break;
+
+    case TYPE_CODE_FLT:
+      ada_val_print_flt (type, valaddr, 0, 0,
+			 address, stream, recurse, val,
+			 options);
+      break;
+
+    case TYPE_CODE_UNION:
+    case TYPE_CODE_STRUCT:
+      ada_val_print_struct_union (type, valaddr, 0, 0,
+				  address, stream, recurse,
+				  val, options);
+      break;
+
+    case TYPE_CODE_ARRAY:
+      ada_val_print_array (type, valaddr, 0, 0,
+			   address, stream, recurse, val,
+			   options);
+      return;
+
+    case TYPE_CODE_REF:
+      ada_val_print_ref (type, valaddr, 0, 0,
+			 address, stream, recurse, val,
+			 options);
+      break;
+    }
+}
+
 /* See ada-lang.h.  */
 
 void
@@ -1229,8 +1309,16 @@ ada_value_print_inner (struct value *val, struct ui_file *stream,
 		       int recurse,
 		       const struct value_print_options *options)
 {
-  ada_val_print (value_type (val), value_embedded_offset (val),
-		 value_address (val), stream, recurse, val, options);
+  try
+    {
+      ada_value_print_1 (val, stream, recurse, options);
+    }
+  catch (const gdb_exception_error &except)
+    {
+      fprintf_styled (stream, metadata_style.style (),
+		      _("<error reading variable: %s>"),
+		      except.what ());
+    }
 }
 
 void

Failures on Fedora-i686, branch master

[gdb-buildbot]

Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/18/builds/2530

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        5b5e15ecddafc43de2da632aa68f935a879d9a91

Subject of commit:
        Rewrite ada_value_print_inner

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91/

*** Diff to previous build ***
==============================================
new UNRESOLVED: gdb.base/corefile.exp: attach: core file is cleared
new FAIL: gdb.base/corefile.exp: attach: with core
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "faas "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "faas -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "faas -s "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "frame apply 1 "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "frame apply 1 -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "frame apply 1 -s "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "frame apply all "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "frame apply all -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "frame apply all -s "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "frame apply level 0 "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "frame apply level 0 -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "frame apply level 0 -s "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "tfaas "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "tfaas -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: cmd complete "tfaas -s "
PASS -> UNRESOLVED: gdb.base/options.exp: test-frame-apply: frame apply 1 -- -
PASS -> UNRESOLVED: gdb.base/options.exp: test-frame-apply: frame apply all -- -
PASS -> UNRESOLVED: gdb.base/options.exp: test-frame-apply: frame apply level 0 -- -
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "faas "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "faas -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "faas -s "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply 1 "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply 1 -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply 1 -s "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply all "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply all -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply all -s "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply level 0 "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply level 0 -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "frame apply level 0 -s "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "tfaas "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "tfaas -- -"
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: tab complete "tfaas -s "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: cmd complete "faas -- "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: cmd complete "frame apply 1 -- "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: cmd complete "frame apply all -- "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: cmd complete "frame apply level 0 -- "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: cmd complete "tfaas -- "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: tab complete "faas -- "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: tab complete "frame apply 1 -- "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: tab complete "frame apply all -- "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: tab complete "frame apply level 0 -- "
PASS -> FAIL: gdb.base/options.exp: test-frame-apply: trailing-space: tab complete "tfaas -- "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: cmd complete "taas "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: cmd complete "taas -- -"
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: cmd complete "taas -c "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: cmd complete "thread apply 1 "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: cmd complete "thread apply 1 -- -"
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: cmd complete "thread apply 1 -c "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: cmd complete "thread apply all "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: cmd complete "thread apply all -- -"
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: cmd complete "thread apply all -c "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: tab complete "taas "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: tab complete "taas -- -"
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: tab complete "taas -c "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: tab complete "thread apply 1 "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: tab complete "thread apply 1 -- -"
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: tab complete "thread apply 1 -c "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: tab complete "thread apply all "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: tab complete "thread apply all -- -"
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: tab complete "thread apply all -c "
PASS -> UNRESOLVED: gdb.base/options.exp: test-thread-apply: thread apply 1 -- -
PASS -> UNRESOLVED: gdb.base/options.exp: test-thread-apply: thread apply all -- -
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: trailing-space: cmd complete "taas -- "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: trailing-space: cmd complete "thread apply 1 -- "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: trailing-space: cmd complete "thread apply all -- "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: trailing-space: tab complete "taas -- "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: trailing-space: tab complete "thread apply 1 -- "
PASS -> FAIL: gdb.base/options.exp: test-thread-apply: trailing-space: tab complete "thread apply all -- "
PASS -> UNRESOLVED: gdb.base/reread.exp: opts= "" "" : second pass: breakpoint foo in first file
PASS -> UNRESOLVED: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: breakpoint foo in first file
PASS -> FAIL: gdb.base/shell.exp: cmd complete "pipe "
PASS -> FAIL: gdb.base/shell.exp: cmd complete "| "
PASS -> FAIL: gdb.base/shell.exp: cmd complete "|"
PASS -> FAIL: gdb.base/shell.exp: tab complete "pipe "
PASS -> FAIL: gdb.base/shell.exp: tab complete "| "
PASS -> FAIL: gdb.base/shell.exp: tab complete "|"
PASS -> FAIL: gdb.base/style.exp: set width 30
PASS -> FAIL: gdb.base/with.exp: completion: cmd complete "with print elements unlimited -- "
PASS -> FAIL: gdb.base/with.exp: completion: tab complete "with print elements unlimited -- "
PASS -> FAIL: gdb.threads/gcore-stale-thread.exp: save a corefile
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
PASS -> FAIL: gdb.tui/basic.exp: asm box
PASS -> FAIL: gdb.tui/basic.exp: asm box in split layout
PASS -> FAIL: gdb.tui/basic.exp: asm window shows main
PASS -> FAIL: gdb.tui/basic.exp: check main is where we expect on the screen
PASS -> FAIL: gdb.tui/basic.exp: list main
PASS -> FAIL: gdb.tui/basic.exp: scroll down
PASS -> FAIL: gdb.tui/basic.exp: scroll right
PASS -> FAIL: gdb.tui/basic.exp: scroll up
PASS -> FAIL: gdb.tui/basic.exp: source box
PASS -> FAIL: gdb.tui/basic.exp: source box in split layout
PASS -> FAIL: gdb.tui/basic.exp: split layout contents
PASS -> FAIL: gdb.tui/corefile-run.exp: load corefile
PASS -> FAIL: gdb.tui/empty.exp: asm-regs: 80x24: box 1
PASS -> FAIL: gdb.tui/empty.exp: asm-regs: 80x24: box 2
PASS -> FAIL: gdb.tui/empty.exp: asm-regs: 80x24: no asm
PASS -> FAIL: gdb.tui/empty.exp: asm-regs: 80x24: no regs
PASS -> FAIL: gdb.tui/empty.exp: asm-regs: 90x40: box 1
PASS -> FAIL: gdb.tui/empty.exp: asm-regs: 90x40: box 2
PASS -> FAIL: gdb.tui/empty.exp: asm-regs: 90x40: no asm
PASS -> FAIL: gdb.tui/empty.exp: asm-regs: 90x40: no regs
PASS -> FAIL: gdb.tui/empty.exp: asm: 80x24: box 1
PASS -> FAIL: gdb.tui/empty.exp: asm: 80x24: no asm
PASS -> FAIL: gdb.tui/empty.exp: asm: 90x40: box 1
PASS -> FAIL: gdb.tui/empty.exp: asm: 90x40: no asm
PASS -> FAIL: gdb.tui/empty.exp: split-regs: 80x24: box 1
PASS -> FAIL: gdb.tui/empty.exp: split-regs: 80x24: box 2
PASS -> FAIL: gdb.tui/empty.exp: split-regs: 80x24: no asm
PASS -> FAIL: gdb.tui/empty.exp: split-regs: 80x24: no regs
PASS -> FAIL: gdb.tui/empty.exp: split-regs: 90x40: box 1
PASS -> FAIL: gdb.tui/empty.exp: split-regs: 90x40: box 2
PASS -> FAIL: gdb.tui/empty.exp: split-regs: 90x40: no asm
PASS -> FAIL: gdb.tui/empty.exp: split-regs: 90x40: no regs
PASS -> FAIL: gdb.tui/empty.exp: split: 80x24: box 1
PASS -> FAIL: gdb.tui/empty.exp: split: 80x24: box 2
PASS -> FAIL: gdb.tui/empty.exp: split: 80x24: no asm
PASS -> FAIL: gdb.tui/empty.exp: split: 80x24: no source
PASS -> FAIL: gdb.tui/empty.exp: split: 90x40: box 1
PASS -> FAIL: gdb.tui/empty.exp: split: 90x40: box 2
PASS -> FAIL: gdb.tui/empty.exp: split: 90x40: no asm
PASS -> FAIL: gdb.tui/empty.exp: split: 90x40: no source
PASS -> FAIL: gdb.tui/empty.exp: src-regs: 80x24: box 1
PASS -> FAIL: gdb.tui/empty.exp: src-regs: 80x24: box 2
PASS -> FAIL: gdb.tui/empty.exp: src-regs: 80x24: no regs
PASS -> FAIL: gdb.tui/empty.exp: src-regs: 80x24: no source
PASS -> FAIL: gdb.tui/empty.exp: src-regs: 90x40: box 1
PASS -> FAIL: gdb.tui/empty.exp: src-regs: 90x40: box 2
PASS -> FAIL: gdb.tui/empty.exp: src-regs: 90x40: no regs
PASS -> FAIL: gdb.tui/empty.exp: src-regs: 90x40: no source
PASS -> FAIL: gdb.tui/empty.exp: src: 80x24: box 1
PASS -> FAIL: gdb.tui/empty.exp: src: 80x24: no source
PASS -> FAIL: gdb.tui/empty.exp: src: 90x40: box 1
PASS -> FAIL: gdb.tui/empty.exp: src: 90x40: no source
PASS -> FAIL: gdb.tui/list-before.exp: initial source listing
PASS -> FAIL: gdb.tui/list.exp: asm window shows main
PASS -> FAIL: gdb.tui/list.exp: initial source listing
PASS -> FAIL: gdb.tui/list.exp: list main
PASS -> FAIL: gdb.tui/main.exp: file clears window
PASS -> FAIL: gdb.tui/main.exp: show main after file
PASS -> FAIL: gdb.tui/new-layout.exp: example layout shows assembly
PASS -> UNRESOLVED: gdb.tui/new-layout.exp: help layout example
PASS -> UNRESOLVED: gdb.tui/new-layout.exp: help layout example2
PASS -> UNRESOLVED: gdb.tui/new-layout.exp: help layout h
PASS -> FAIL: gdb.tui/new-layout.exp: horizontal display
PASS -> FAIL: gdb.tui/new-layout.exp: left window box
PASS -> FAIL: gdb.tui/new-layout.exp: left window box after grow
PASS -> FAIL: gdb.tui/new-layout.exp: left window box after shrink
PASS -> FAIL: gdb.tui/new-layout.exp: right window box
PASS -> FAIL: gdb.tui/new-layout.exp: right window box after grow
PASS -> FAIL: gdb.tui/new-layout.exp: right window box after shrink
PASS -> UNRESOLVED: gdb.tui/new-layout.exp: tui new-layout
PASS -> UNRESOLVED: gdb.tui/new-layout.exp: tui new-layout example
PASS -> UNRESOLVED: gdb.tui/new-layout.exp: tui new-layout example asm 1 status 0 cmd 1
PASS -> UNRESOLVED: gdb.tui/new-layout.exp: tui new-layout example src 1
PASS -> UNRESOLVED: gdb.tui/new-layout.exp: tui new-layout example src 1 src 1
PASS -> UNRESOLVED: gdb.tui/new-layout.exp: tui new-layout example src 1}
PASS -> UNRESOLVED: gdb.tui/new-layout.exp: tui new-layout example zzq
PASS -> UNRESOLVED: gdb.tui/new-layout.exp: tui new-layout example {src 1
PASS -> UNRESOLVED: gdb.tui/new-layout.exp: tui new-layout example {src 1} 1}
PASS -> UNRESOLVED: gdb.tui/new-layout.exp: tui new-layout example2 {asm 1 status 0} 1 cmd 1
PASS -> UNRESOLVED: gdb.tui/new-layout.exp: tui new-layout h {-horizontal asm 1 src 1} 1 status 0 cmd 1
PASS -> FAIL: gdb.tui/regs.exp: any register contents
PASS -> FAIL: gdb.tui/regs.exp: register box
PASS -> FAIL: gdb.tui/regs.exp: source at startup
PASS -> FAIL: gdb.tui/regs.exp: source box in regs layout
PASS -> FAIL: gdb.tui/resize.exp: source at startup
PASS -> FAIL: gdb.tui/resize.exp: source box after resize
PASS -> FAIL: gdb.tui/tui-layout-asm-short-prog.exp: check asm box contents
PASS -> FAIL: gdb.tui/tui-layout-asm-short-prog.exp: check asm box contents again
PASS -> FAIL: gdb.tui/tui-layout-asm.exp: check asm box contents
PASS -> FAIL: gdb.tui/tui-missing-src.exp: Back in main
PASS -> FAIL: gdb.tui/tui-missing-src.exp: check source box is empty
PASS -> UNRESOLVED: gdb.tui/tui-missing-src.exp: check source box is empty after return
PASS -> FAIL: gdb.tui/tui-missing-src.exp: f2.c must be displayed in source window
PASS -> FAIL: gdb.tui/winheight.exp: larger source box
PASS -> FAIL: gdb.tui/winheight.exp: smaller source box
PASS -> FAIL: gdb.tui/winheight.exp: source box
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91//xfail.table.gz>

Failures on Fedora-x86_64-cc-with-index, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-cc-with-index

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/20/builds/2476

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        5b5e15ecddafc43de2da632aa68f935a879d9a91

Subject of commit:
        Rewrite ada_value_print_inner

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i02
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i12
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: multi_scope: second thread: print i22
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 3rd stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 3rd stop: print j
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91//xfail.table.gz>

Failures on Fedora-x86_64-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/3/builds/2586

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        5b5e15ecddafc43de2da632aa68f935a879d9a91

Subject of commit:
        Rewrite ada_value_print_inner

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 1st thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 1st thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 1st thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 1st thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 1st thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 1st thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: second thread: print i3
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91//xfail.table.gz>

Failures on Fedora-x86_64-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m32

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/17/builds/2525

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        5b5e15ecddafc43de2da632aa68f935a879d9a91

Subject of commit:
        Rewrite ada_value_print_inner

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/coredump-filter.exp: disassembling function main for non-Private-Anonymous: no binary: loading /home/gdb-buildbot/fedora-x86-64-1/fedora-x86-64-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-private-anon.gcore
new FAIL: gdb.base/coredump-filter.exp: disassembling function main for non-Shared-Anonymous: no binary: loading /home/gdb-buildbot/fedora-x86-64-1/fedora-x86-64-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-shared-anon.gcore
new FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for DoNotDump: loading /home/gdb-buildbot/fedora-x86-64-1/fedora-x86-64-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/dont-dump.gcore
new FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for non-Shared-Anonymous: loading /home/gdb-buildbot/fedora-x86-64-1/fedora-x86-64-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-shared-anon.gcore
new FAIL: gdb.base/corefile-buildid.exp: exec sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: exec: info files
new FAIL: gdb.base/corefile-buildid.exp: shared sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: shared: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink exec sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink exec: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink shared sepdebug: info files
new FAIL: gdb.base/corefile-buildid.exp: symlink shared: info files
new UNRESOLVED: gdb.base/corefile.exp: attach: core file is cleared
new FAIL: gdb.base/corefile.exp: attach: with core
new FAIL: gdb.base/corefile.exp: core-file warning-free
PASS -> UNRESOLVED: gdb.base/reread.exp: opts= "" "" : second pass: breakpoint foo in first file
PASS -> UNRESOLVED: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: breakpoint foo in first file
PASS -> FAIL: gdb.multi/multi-term-settings.exp: inf1_how=attach: inf2_how=attach: stop with control-c
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m32/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-1

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/2/builds/2423

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        5b5e15ecddafc43de2da632aa68f935a879d9a91

Subject of commit:
        Rewrite ada_value_print_inner

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/break-interp.exp: ldprelink=NO: ldsepdebug=IN: binprelink=NO: binsepdebug=NO: binpie=NO: INNER: symbol-less: entry point reached
new FAIL: gdb.base/break-interp.exp: ldprelink=NO: ldsepdebug=IN: binprelink=NO: binsepdebug=NO: binpie=YES: INNER: symbol-less: entry point reached
PASS -> UNRESOLVED: gdb.base/reread.exp: opts= "" "" : second pass: breakpoint foo in first file
PASS -> UNRESOLVED: gdb.base/reread.exp: opts= "-fPIE" "ldflags=-pie" : second pass: breakpoint foo in first file
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
FAIL -> UNRESOLVED: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
PASS -> UNRESOLVED: gdb.threads/attach-into-signal.exp: threaded: attach
new FAIL: gdb.threads/attach-into-signal.exp: threaded: thread apply 2 print $_siginfo.si_signo
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 6: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 6: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 6: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 6: detach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 6: reset timer in the inferior
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 7: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 7: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 7: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 7: detach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 7: reset timer in the inferior
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 8: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 8: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 8: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 8: detach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 8: reset timer in the inferior
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 9: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 9: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 9: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 9: detach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 9: reset timer in the inferior
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: first thread: print i3
PASS -> FAIL: gdb.threads/thread-unwindonsignal.exp: continue until exit
new KFAIL: gdb.threads/watchthreads2.exp: gdb can drop watchpoints in multithreaded app
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/4/builds/2422

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        5b5e15ecddafc43de2da632aa68f935a879d9a91

Subject of commit:
        Rewrite ada_value_print_inner

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/coredump-filter.exp: disassembling function main for non-Private-Anonymous: no binary: loading /home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64-native-extended-gdbserver-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-private-anon.gcore
new FAIL: gdb.base/coredump-filter.exp: disassembling function main for non-Shared-Anonymous: no binary: loading /home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64-native-extended-gdbserver-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-shared-anon.gcore
new FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for DoNotDump: loading /home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64-native-extended-gdbserver-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/dont-dump.gcore
new FAIL: gdb.base/coredump-filter.exp: loading and testing corefile for non-Shared-Anonymous: loading /home/gdb-buildbot-2/fedora-x86-64-4/fedora-x86-64-native-extended-gdbserver-m32/build/gdb/testsuite/outputs/gdb.base/coredump-filter/non-shared-anon.gcore
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=main: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=main: mi=separate: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=main: force-fail=1: run failure detected
UNRESOLVED -> FAIL: gdb.mi/mi-exec-run.exp: inferior-tty=separate: mi=separate: force-fail=1: run failure detected
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=1: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=1: print re_run_var_1
new UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: delete all breakpoints in delete_breakpoints
PASS -> UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: setting breakpoint at all_started
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m64

Worker:
        fedora-x86-64-2

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/22/builds/2424

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        5b5e15ecddafc43de2da632aa68f935a879d9a91

Subject of commit:
        Rewrite ada_value_print_inner

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91/

*** Diff to previous build ***
==============================================
new FAIL: gdb.base/gdb-caching-proc.exp: set print elements unlimited
new FAIL: gdb.base/gdb-caching-proc.exp: set print repeats unlimited
new FAIL: gdb.base/gdb-caching-proc.exp: show print repeats
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 2nd call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 3rd stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 3rd stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print j
PASS -> FAIL: gdb.trace/ftrace.exp: advance through tracing
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91//xfail.table.gz>

Failures on Ubuntu-Aarch64-m64, branch master

[gdb-buildbot]

Buildername:
        Ubuntu-Aarch64-m64

Worker:
        ubuntu-aarch64

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/8/builds/2410

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        5b5e15ecddafc43de2da632aa68f935a879d9a91

Subject of commit:
        Rewrite ada_value_print_inner

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-m64/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-m64/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-m64/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91//xfail.table.gz>

Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Ubuntu-Aarch64-native-extended-gdbserver-m64

Worker:
        ubuntu-aarch64

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/5/builds/2309

Author:
        Tom Tromey <tom@tromey.com>

Commit tested:
        5b5e15ecddafc43de2da632aa68f935a879d9a91

Subject of commit:
        Rewrite ada_value_print_inner

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Ubuntu-Aarch64-native-extended-gdbserver-m64/5b/5b5e15ecddafc43de2da632aa68f935a879d9a91//xfail.table.gz>