public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Revert PR16467 change
@ 2016-06-02  3:32 sergiodj+buildbot
  2016-06-02  3:39 ` Failures on Fedora-ppc64be-cc-with-index, branch master sergiodj+buildbot
                   ` (12 more replies)
  0 siblings, 13 replies; 14+ messages in thread
From: sergiodj+buildbot @ 2016-06-02  3:32 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5b677558bc6c7b2477bb33c709e6017e68e7ae8c ***

Author: Alan Modra <amodra@gmail.com>
Branch: master
Commit: 5b677558bc6c7b2477bb33c709e6017e68e7ae8c

Revert PR16467 change

This reverts the pr16467 change, which was incorrect due to faulty
analysis of the pr16467 testcase.  The failure was not due to a
mismatch in symbol type (ifunc/non-ifunc) but due to a symbol loop
being set up.

See https://sourceware.org/ml/binutils/2016-06/msg00013.html for some
rambling on versioned symbols and ELF shared library symbol overriding
that explain this patch.

bfd/
	PR ld/20159
	PR ld/16467
	* elflink.c (_bfd_elf_merge_symbol): Revert PR16467 change.
	(_bfd_elf_add_default_symbol): Don't indirect to/from defined
	symbol given a version by a script different to the version
	of the symbol being added.
	(elf_link_add_object_symbols): Use _bfd_elf_strtab_save and
	_bfd_elf_strtab_restore.  Don't fudge dynstr references.
	* elf-strtab.c (_bfd_elf_strtab_restore_size): Delete.
	(struct strtab_save): New.
	(_bfd_elf_strtab_save, _bfd_elf_strtab_restore): New functions.
	* elf-bfd.h (_bfd_elf_strtab_restore_size): Delete.
	(_bfd_elf_strtab_save, _bfd_elf_strtab_restore): Declare.


^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2016-06-02  4:15 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-02  3:32 [binutils-gdb] Revert PR16467 change sergiodj+buildbot
2016-06-02  3:39 ` Failures on Fedora-ppc64be-cc-with-index, branch master sergiodj+buildbot
2016-06-02  3:40 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-06-02  3:42 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2016-06-02  3:46 ` *** COMPILATION FAILED *** Failures on AIX-POWER7-plain, branch master *** BREAKAGE *** sergiodj+buildbot
2016-06-02  3:46 ` Failures on Fedora-ppc64be-m64, branch master sergiodj+buildbot
2016-06-02  3:47 ` Failures on Fedora-ppc64le-cc-with-index, " sergiodj+buildbot
2016-06-02  3:59 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
2016-06-02  4:00 ` Failures on Fedora-ppc64le-native-gdbserver-m64, " sergiodj+buildbot
2016-06-02  4:08 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj+buildbot
2016-06-02  4:11 ` Failures on Fedora-i686, " sergiodj+buildbot
2016-06-02  4:11 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-06-02  4:15 ` Failures on Fedora-ppc64le-m64, " sergiodj+buildbot
2016-06-02 13:17 ` Failures on Debian-i686, " sergiodj+buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).