public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdbserver/libthread_db: Don't ignore memory reading failures
@ 2017-09-30 1:31 sergiodj+buildbot
0 siblings, 0 replies; only message in thread
From: sergiodj+buildbot @ 2017-09-30 1:31 UTC (permalink / raw)
To: gdb-testers
*** TEST RESULTS FOR COMMIT 5b9ca4d43ba0313612e8ad6e50221e8f20ebd129 ***
Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 5b9ca4d43ba0313612e8ad6e50221e8f20ebd129
gdbserver/libthread_db: Don't ignore memory reading failures
If we had this in place before, then the regression fixed by the
previous commit would have been been visible is all test runs. E.g.:
Running src/gdb/testsuite/gdb.threads/multi-create-ns-info-thr.exp ...
FAIL: gdb.threads/multi-create-ns-info-thr.exp: continue to breakpoint 6
Debugging manually we'd see this:
gdbserver: Cannot get thread handle for LWP 1467: generic error
Instead of:
gdbserver: PID mismatch! Expected 27472, got 27471
which is misleading - gdbserver didn't 27471, that was stale stack
data from previous function invocations.
gdb/gdbserver/ChangeLog:
2017-09-29 Pedro Alves <palves@redhat.com>
* proc-service.c (ps_pdread): Return PS_ERR if reading memory
fails.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-09-29 13:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-30 1:31 [binutils-gdb] gdbserver/libthread_db: Don't ignore memory reading failures sergiodj+buildbot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).