From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114486 invoked by alias); 5 Nov 2019 22:51:52 -0000 Mailing-List: contact gdb-testers-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-testers-owner@sourceware.org Received: (qmail 114470 invoked by uid 89); 5 Nov 2019 22:51:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-15.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: kwanyin.sergiodj.net Received: from kwanyin.sergiodj.net (HELO kwanyin.sergiodj.net) (158.69.185.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Nov 2019 22:51:50 +0000 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [binutils-gdb] Change tui_source_element::line to have type std::string From: gdb-buildbot@sergiodj.net To: gdb-testers@sourceware.org Message-Id: <5d0510553eb447bf6861f4641b5ae3aaf9503a13@gdb-build> Date: Tue, 05 Nov 2019 22:51:00 -0000 X-SW-Source: 2019-q4/txt/msg01849.txt.bz2 *** TEST RESULTS FOR COMMIT 5d0510553eb447bf6861f4641b5ae3aaf9503a13 *** commit 5d0510553eb447bf6861f4641b5ae3aaf9503a13 Author: Tom Tromey AuthorDate: Mon Oct 21 10:58:08 2019 -0600 Commit: Tom Tromey CommitDate: Tue Nov 5 15:23:36 2019 -0700 Change tui_source_element::line to have type std::string This changes tui_source_element::line to be of type std::string. This reduces the number of copies made. gdb/ChangeLog 2019-11-05 Tom Tromey * tui/tui-winsource.h (struct tui_source_element) : Now a std::string. * tui/tui-winsource.c (tui_show_source_line): Update. * tui/tui-source.c (tui_source_window::set_contents): Update. * tui/tui-disasm.c (tui_disasm_window::set_contents): Update. Change-Id: Id600f3e1d386a2911f187366e05e2ec599068dd2 diff --git a/gdb/ChangeLog b/gdb/ChangeLog index efa66ee77d..0c05afeb13 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,11 @@ +2019-11-05 Tom Tromey + + * tui/tui-winsource.h (struct tui_source_element) : Now a + std::string. + * tui/tui-winsource.c (tui_show_source_line): Update. + * tui/tui-source.c (tui_source_window::set_contents): Update. + * tui/tui-disasm.c (tui_disasm_window::set_contents): Update. + 2019-11-05 Christian Biesinger * symtab.h (gdb_static_assert): Put && operator at the beginning diff --git a/gdb/tui/tui-disasm.c b/gdb/tui/tui-disasm.c index 33a3ba12d4..91c9845f5d 100644 --- a/gdb/tui/tui-disasm.c +++ b/gdb/tui/tui-disasm.c @@ -216,10 +216,10 @@ tui_disasm_window::set_contents (struct gdbarch *arch, + asm_lines[i].insn); /* Now copy the line taking the offset into account. */ - if (line.size() > offset) - src->line.reset (xstrndup (&line[offset], line_width)); + if (line.size () > offset) + src->line = line.substr (offset, line_width); else - src->line = make_unique_xstrdup (""); + src->line.clear (); src->line_or_addr.loa = LOA_ADDRESS; src->line_or_addr.u.addr = asm_lines[i].addr; diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c index bb1013bb86..f956645d89 100644 --- a/gdb/tui/tui-source.c +++ b/gdb/tui/tui-source.c @@ -183,7 +183,7 @@ tui_source_window::set_contents (struct gdbarch *arch, symtab_to_fullname (s)) == 0 && cur_line_no == locator->line_no); - content[cur_line].line = make_unique_xstrdup (text.c_str ()); + content[cur_line].line = std::move (text); cur_line++; cur_line_no++; diff --git a/gdb/tui/tui-winsource.c b/gdb/tui/tui-winsource.c index 3fbc49fd77..5d0bcb47b1 100644 --- a/gdb/tui/tui-winsource.c +++ b/gdb/tui/tui-winsource.c @@ -222,7 +222,7 @@ tui_show_source_line (struct tui_source_window_base *win_info, int lineno) tui_set_reverse_mode (win_info->handle.get (), true); wmove (win_info->handle.get (), lineno, TUI_EXECINFO_SIZE); - tui_puts (line->line.get (), win_info->handle.get ()); + tui_puts (line->line.c_str (), win_info->handle.get ()); if (line->is_exec_point) tui_set_reverse_mode (win_info->handle.get (), false); diff --git a/gdb/tui/tui-winsource.h b/gdb/tui/tui-winsource.h index 9417b282d6..185d3dd5e0 100644 --- a/gdb/tui/tui-winsource.h +++ b/gdb/tui/tui-winsource.h @@ -62,7 +62,7 @@ struct tui_source_element { } - gdb::unique_xmalloc_ptr line; + std::string line; struct tui_line_or_address line_or_addr; bool is_exec_point = false; tui_bp_flags break_mode = 0;