public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] gdb/amd64: Ignore zero sized fields when calling functions
Date: Tue, 06 Mar 2018 10:29:00 -0000	[thread overview]
Message-ID: <5dc4391345f6e86906a57af1434025cfb47b4100@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 5dc4391345f6e86906a57af1434025cfb47b4100 ***

Author: Andrew Burgess <andrew.burgess@embecosm.com>
Branch: master
Commit: 5dc4391345f6e86906a57af1434025cfb47b4100

gdb/amd64: Ignore zero sized fields when calling functions

In some cases passing an argument to a function on amd64, or attempting
to fetch the return value, can trigger an assertion failure within GDB.
An example of a type that would trigger such an error is:

  struct foo_t
  {
    long double a;
    struct {
      struct {
        /* Empty.  */
      } es1;
    } s1;
  };

GCC does permit empty structures, so we should probably support this.

The test that exposes this bug is in the next commit along with the
RiscV support.

gdb/ChangeLog:

	* amd64-tdep.c (amd64_classify_aggregate): Ignore zero sized
	fields within aggregates.


             reply	other threads:[~2018-03-06 10:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 10:29 sergiodj+buildbot [this message]
2018-03-06 10:29 ` Failures on Debian-s390x-m64, branch master sergiodj+buildbot
2018-03-06 10:42 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2018-03-06 10:42 ` Failures on Fedora-s390x-m64, " sergiodj+buildbot
2018-03-06 10:44 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2018-03-06 10:46 ` Failures on RHEL-s390x-m64, " sergiodj+buildbot
2018-03-06 10:54 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2018-03-06 10:55 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot
2018-03-06 11:08 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot
2018-03-06 11:10 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2018-03-06 11:14 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2018-03-06 11:34 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot
2018-03-07 10:03 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5dc4391345f6e86906a57af1434025cfb47b4100@gdb-build \
    --to=sergiodj+buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).