public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb/gdb-7.10-branch] Prelimit number of bytes to read in "vFile:pread:"
@ 2015-08-19 13:35 sergiodj+buildbot
  2015-08-19 13:35 ` Failures on RHEL-s390x-m64, branch gdb-7.10-branch sergiodj+buildbot
                   ` (20 more replies)
  0 siblings, 21 replies; 22+ messages in thread
From: sergiodj+buildbot @ 2015-08-19 13:35 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 5e83dd6fb19ba25a89e321a0eb1373b3d3fc3930 ***

Author: Gary Benson <gbenson@redhat.com>
Branch: gdb-7.10-branch
Commit: 5e83dd6fb19ba25a89e321a0eb1373b3d3fc3930

Prelimit number of bytes to read in "vFile:pread:"

While handling "vFile:pread:" packets, gdbserver would read the
number of bytes requested regardless of whether this would fit
into the reply packet.  gdbserver would then return a packet's
worth of data and discard the remainder.  When accessing large
binaries GDB (via BFD) routinely makes large "vFile:pread:"
requests, resulting in gdbserver allocating large unnecessary
buffers and reading some portions of the file many times over.

This commit causes gdbserver to limit the number of bytes to be
read to a sensible maximum prior to allocating buffers and reading
data.

gdb/gdbserver/ChangeLog:

	* hostio.c (handle_pread): Do not attempt to read more data
	than hostio_reply_with_data can fit in a packet.


^ permalink raw reply	[flat|nested] 22+ messages in thread

end of thread, other threads:[~2015-08-19 16:21 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-19 13:35 [binutils-gdb/gdb-7.10-branch] Prelimit number of bytes to read in "vFile:pread:" sergiodj+buildbot
2015-08-19 13:35 ` Failures on RHEL-s390x-m64, branch gdb-7.10-branch sergiodj+buildbot
2015-08-19 13:44 ` Failures on Fedora-i686, " sergiodj+buildbot
2015-08-19 13:53 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2015-08-19 13:53 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot
2015-08-19 13:54 ` Failures on AIX-POWER7-plain, " sergiodj+buildbot
2015-08-19 13:57 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2015-08-19 13:59 ` Failures on Fedora-s390x-m64, " sergiodj+buildbot
2015-08-19 14:04 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2015-08-19 14:06 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
2015-08-19 14:26 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2015-08-19 14:38 ` Failures on Fedora-ppc64be-cc-with-index, " sergiodj+buildbot
2015-08-19 14:59 ` Failures on Fedora-ppc64be-m64, " sergiodj+buildbot
2015-08-19 15:04 ` Failures on Debian-i686, " sergiodj+buildbot
2015-08-19 15:16 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj+buildbot
2015-08-19 15:22 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj+buildbot
2015-08-19 15:33 ` Failures on Debian-i686-native-gdbserver, " sergiodj+buildbot
2015-08-19 15:38 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot
2015-08-19 15:42 ` Failures on Fedora-ppc64le-cc-with-index, " sergiodj+buildbot
2015-08-19 15:57 ` Failures on Fedora-ppc64le-native-gdbserver-m64, " sergiodj+buildbot
2015-08-19 16:09 ` Failures on Debian-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2015-08-19 16:21 ` Failures on Debian-x86_64-m64, " sergiodj+buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).