public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] c++/8218: Destructors w/arguments.
Date: Fri, 10 Mar 2017 18:58:00 -0000	[thread overview]
Message-ID: <5f4d10850850cd95af5e95a16848c8c07a273d88@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 5f4d10850850cd95af5e95a16848c8c07a273d88 ***

Author: Keith Seitz <keiths@redhat.com>
Branch: master
Commit: 5f4d10850850cd95af5e95a16848c8c07a273d88

c++/8218: Destructors w/arguments.

For a long time now, c++/8218 has noted that GDB is printing argument types
for destructors:

(gdb) ptype A
type = class A {
  public:
    ~A(int);
}

This happens because cp_type_print_method_args doesn't ignore artificial
arguments.  [It ignores the first `this' pointer because it simply skips
the first argument for any non-static function.]

This patch fixes this:

(gdb) ptype  A
type = class A {
  public:
    ~A();
}

I've adjusted gdb.cp/templates.exp to account for this and added a new
passing regexp.

gdb/ChangeLog

	PR c++/8218
	* c-typeprint.c (cp_type_print_method_args): Skip artificial arguments.

gdb/testsuite/ChangeLog

	PR c++/8128
	* gdb.cp/templates.exp (test_ptype_of_templates): Remove argument
	type from destructor regexps.
	Add a branch which actually passes the test.
	Adjust "ptype t5i" test names.


             reply	other threads:[~2017-03-10 18:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-10 18:58 sergiodj+buildbot [this message]
2017-03-10 18:58 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, branch master sergiodj+buildbot
2017-03-10 19:07 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, " sergiodj+buildbot
2017-03-10 19:21 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2017-03-10 19:23 ` Failures on Fedora-s390x-m64, " sergiodj+buildbot
2017-03-10 19:34 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot
2017-03-10 19:43 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2017-03-10 19:44 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot
2017-03-15 20:27 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2017-03-16  5:35 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot
2017-03-16  5:48 ` Failures on Debian-s390x-m64, " sergiodj+buildbot
2017-03-17 17:18 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj+buildbot
2017-03-18  2:30 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot
2017-03-18  2:59 ` Failures on Fedora-ppc64le-native-gdbserver-m64, " sergiodj+buildbot
2017-03-22  1:18 ` Failures on Fedora-ppc64le-native-extended-gdbserver-m64, " sergiodj+buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f4d10850850cd95af5e95a16848c8c07a273d88@gdb-build \
    --to=sergiodj+buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).