public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] Improve comments in print-utils.h.
Date: Thu, 17 Oct 2019 14:11:00 -0000	[thread overview]
Message-ID: <5f93c5a6d5072d0bb2e4e734a6fe3336ce86ced9@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 5f93c5a6d5072d0bb2e4e734a6fe3336ce86ced9 ***

commit 5f93c5a6d5072d0bb2e4e734a6fe3336ce86ced9
Author:     Jim Wilson <jimw@sifive.com>
AuthorDate: Fri Oct 11 11:28:35 2019 -0700
Commit:     Jim Wilson <jimw@sifive.com>
CommitDate: Fri Oct 11 11:28:35 2019 -0700

    Improve comments in print-utils.h.
    
    Since I had to look at these function comments to fix the RISC-V ARI warnings,
    I noticed that they make no sense.  The pulongest and plongest comments are
    swapped.  phex is missing a comment.  And phex_nz doesn't mention how it is
    different from phex.
    
            * gdbsupport/print-utils.h (pulongest): Fix comment.
            (plongest): Likewise.
            (phex): Add missing comment, mention leading zeros.
            (phex_nz): Add mention of no leading zeros to comment.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 3c1f87b32d..b898bf77f9 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2019-10-11  Jim Wilson  <jimw@sifive.com>
 
+	* gdbsupport/print-utils.h (pulongest): Fix comment.
+	(plongest): Likewise.
+	(phex): Add missing comment, mention leading zeros.
+	(phex_nz): Add mention of no leading zeros to comment.
+
 	* riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 	plongest instead of unsigned long long cast.
 
diff --git a/gdb/gdbsupport/print-utils.h b/gdb/gdbsupport/print-utils.h
index 815b14cbed..d52bcf8f61 100644
--- a/gdb/gdbsupport/print-utils.h
+++ b/gdb/gdbsupport/print-utils.h
@@ -24,20 +24,23 @@
    cell.  */
 #define PRINT_CELL_SIZE 50
 
-/* %d for LONGEST.  The result is stored in a circular static buffer,
+/* %u for ULONGEST.  The result is stored in a circular static buffer,
    NUMCELLS deep.  */
 
 extern char *pulongest (ULONGEST u);
 
-/* %u for ULONGEST.  The result is stored in a circular static buffer,
+/* %d for LONGEST.  The result is stored in a circular static buffer,
    NUMCELLS deep.  */
 
 extern char *plongest (LONGEST l);
 
+/* Convert a ULONGEST into a HEX string, like %lx, with leading zeros.
+   The result is stored in a circular static buffer, NUMCELLS deep.  */
+
 extern char *phex (ULONGEST l, int sizeof_l);
 
-/* Convert a ULONGEST into a HEX string, like %lx.  The result is
-   stored in a circular static buffer, NUMCELLS deep.  */
+/* Convert a ULONGEST into a HEX string, like %lx, without leading zeros.
+   The result is  stored in a circular static buffer, NUMCELLS deep.  */
 
 extern char *phex_nz (ULONGEST l, int sizeof_l);
 


             reply	other threads:[~2019-10-17 14:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-17 14:11 gdb-buildbot [this message]
2019-10-17 14:11 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot
2019-10-17 15:47 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, " gdb-buildbot
2019-10-17 16:35 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, " gdb-buildbot
2019-10-24 17:05 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f93c5a6d5072d0bb2e4e734a6fe3336ce86ced9@gdb-build \
    --to=gdb-buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).