public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb/gdb-7.12-branch] Fix PR gdb/20505 - Make vDSO detection work with core files
Date: Tue, 23 Aug 2016 08:36:00 -0000	[thread overview]
Message-ID: <601a2a8f639f9ef6dab86118a87fa67861f2091e@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 601a2a8f639f9ef6dab86118a87fa67861f2091e ***

Author: Pedro Alves <palves@redhat.com>
Branch: gdb-7.12-branch
Commit: 601a2a8f639f9ef6dab86118a87fa67861f2091e

Fix PR gdb/20505 - Make vDSO detection work with core files

Loading a core dump that was either generated on a system running
pristine glibc master, or on a Fedora/RHEL system with LD_DEBUG=unused
set in the environment, solib-svr4.c:svr4_current_sos fails to filter
out the vDSO, resulting in:

  (gdb) core-file corefile.core^M
  [New LWP 2362]^M
  warning: Could not load shared library symbols for linux-vdso.so.1.^M
  Do you need "set solib-search-path" or "set sysroot"?^M
  Core was generated by `build-gdb/gdb/testsuite/outputs/gdb.base/corefile/'.^M
  ...

The problem is that gdbarch_vsyscall_range does not support core
inferiors at all.

When live debugging, we're finding the vDSO's start address with
auxv/AT_SYSINFO_EHDR, and then we find the vDSO's size by look for the
corresponding mapping, by parsing /proc/PID/maps.  When debugging a
core dump, we can also determine the starting address from
auxv/AT_SYSINFO_EHDR.  However, we obviously can't read the core
mappings out of the host's /proc.  But we can instead look for a
corresponding load segment in the core's bfd.

gdb/ChangeLog:
2016-08-22  Pedro Alves  <palves@redhat.com>

	PR gdb/20505
	* linux-tdep.c (linux_vsyscall_range_raw): For core inferiors,
	find the vDSO's start address with AT_SYSINFO_EHDR too, and
	determine the vDSO's size by finding the PT_LOAD segment that
	matches AT_SYSINFO_EHDR.

gdb/testsuite/ChangeLog:
2016-08-22  Pedro Alves  <palves@redhat.com>

	PR gdb/20505
	* gdb.base/vdso-warning.exp: Test core dumps too.  Use
	with_test_prefix.  Factor out bits to ...
	(test_no_vdso): ... this new procedure.


             reply	other threads:[~2016-08-22 20:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23  8:36 sergiodj+buildbot [this message]
2016-08-23  8:23 ` Failures on Fedora-x86_64-native-gdbserver-m32, branch gdb-7.12-branch sergiodj+buildbot
2016-08-23  9:00 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot
2016-08-23  9:01 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2016-08-23  9:53 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot
2016-08-23 10:05 ` Failures on Debian-i686, " sergiodj+buildbot
2016-08-23 10:08 ` Failures on Fedora-i686, " sergiodj+buildbot
2016-08-23 10:20 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2016-08-23 10:20 ` Failures on Debian-s390x-m64, " sergiodj+buildbot
2016-08-23 11:02 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-08-23 11:08 ` Failures on Debian-i686-native-extended-gdbserver, " sergiodj+buildbot
2016-08-23 11:19 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2016-08-23 11:40 ` Failures on Fedora-ppc64be-m64, " sergiodj+buildbot
2016-08-23 12:02 ` Failures on Fedora-ppc64be-native-gdbserver-m64, " sergiodj+buildbot
2016-08-23 12:35 ` Failures on Fedora-ppc64be-native-extended-gdbserver-m64, " sergiodj+buildbot
2016-08-23 12:46 ` Failures on Fedora-ppc64le-native-gdbserver-m64, " sergiodj+buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=601a2a8f639f9ef6dab86118a87fa67861f2091e@gdb-build \
    --to=sergiodj+buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).