public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] gdb/testsuite: Fix race condition compiling fortran test
@ 2019-11-28  1:30 gdb-buildbot
  2019-11-28  1:30 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: gdb-buildbot @ 2019-11-28  1:30 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 640ab94712483457b99bd1039b52821c510b28a7 ***

commit 640ab94712483457b99bd1039b52821c510b28a7
Author:     Andrew Burgess <andrew.burgess@embecosm.com>
AuthorDate: Wed Nov 27 21:18:38 2019 +0000
Commit:     Andrew Burgess <andrew.burgess@embecosm.com>
CommitDate: Wed Nov 27 21:18:38 2019 +0000

    gdb/testsuite: Fix race condition compiling fortran test
    
    The Fortran test gdb.fortran/info-modules compiles the files
    info-types.f90 and info-types-2.f90 in that order.  Unfortunately
    info-types.f90 makes use of a module defined in info-types-2.f90.
    
    This currently doesn't cause a problem if you run all of the Fortran
    tests as the info-types.exp test already compiles info-types-2.f90 and
    so the module description file 'mod2.mod' will be created, and can
    then be found by info-modules.exp during its compile.
    
    If however you try to run just info-modules.exp in a clean build
    directory, the test will fail to compile.
    
    Fix this by compiling the source files in the reverse order so that
    the module is compiled first, then the test program that uses the
    module.
    
    gdb/testsuite/ChangeLog:
    
            * gdb.fortran/info-modules.exp: Compile source files in correct
            order.
    
    Change-Id: Ic3a1eded0486f6264ebe3066cf1beafbd2534a91

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 3a6e925785..86f2130c26 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
+
+	* gdb.fortran/info-modules.exp: Compile source files in correct
+	order.
+
 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
 
 	* gdb.dwarf2/imported-unit.exp: New file.
diff --git a/gdb/testsuite/gdb.fortran/info-modules.exp b/gdb/testsuite/gdb.fortran/info-modules.exp
index 43570066d2..c57ac3ff56 100644
--- a/gdb/testsuite/gdb.fortran/info-modules.exp
+++ b/gdb/testsuite/gdb.fortran/info-modules.exp
@@ -23,7 +23,7 @@ if { [skip_fortran_tests] } { continue }
 standard_testfile info-types.f90 info-types-2.f90
 
 if { [prepare_for_testing "failed to prepare" $testfile \
-	  [list $srcfile $srcfile2] {debug f90}] } {
+	  [list $srcfile2 $srcfile] {debug f90}] } {
     return -1
 }
 


^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-12-01  3:42 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-28  1:30 [binutils-gdb] gdb/testsuite: Fix race condition compiling fortran test gdb-buildbot
2019-11-28  1:30 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot
2019-11-28  1:51 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, " gdb-buildbot
2019-12-01  2:49 ` Failures on Fedora-i686, " gdb-buildbot
2019-12-01  3:02 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2019-12-01  3:35 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot
2019-12-01  3:42 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).