[binutils-gdb] Rewrite target_read_string

[binutils-gdb] Rewrite target_read_string

[gdb-buildbot]

*** TEST RESULTS FOR COMMIT 670e35fad9c17e8e166c5a6260201eebcc2ba9e6 ***

commit 670e35fad9c17e8e166c5a6260201eebcc2ba9e6
Author:     Tom Tromey <tromey@adacore.com>
AuthorDate: Mon Jun 15 06:28:09 2020 -0600
Commit:     Tom Tromey <tromey@adacore.com>
CommitDate: Mon Jun 15 06:28:09 2020 -0600

    Rewrite target_read_string
    
    This rewrites target_read_string in terms of read_string.
    
    gdb/ChangeLog
    2020-06-15  Tom Tromey  <tromey@adacore.com>
    
            * valprint.c (read_string): Update comment.
            * target.c (MIN): Remove.
            (target_read_string): Rewrite.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1ebe8f3f89..4f12edc726 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2020-06-15  Tom Tromey  <tromey@adacore.com>
+
+	* valprint.c (read_string): Update comment.
+	* target.c (MIN): Remove.
+	(target_read_string): Rewrite.
+
 2020-06-15  Tom Tromey  <tromey@adacore.com>
 
 	* corefile.c (read_memory_string): Remove.
diff --git a/gdb/target.c b/gdb/target.c
index 82c405a849..897b8fdd32 100644
--- a/gdb/target.c
+++ b/gdb/target.c
@@ -50,6 +50,7 @@
 #include "terminal.h"
 #include <unordered_map>
 #include "target-connection.h"
+#include "valprint.h"
 
 static void generic_tls_error (void) ATTRIBUTE_NORETURN;
 
@@ -803,9 +804,6 @@ target_xfer_status_to_string (enum target_xfer_status status)
 };
 
 
-#undef	MIN
-#define MIN(A, B) (((A) <= (B)) ? (A) : (B))
-
 /* target_read_string -- read a null terminated string, up to LEN bytes,
    from MEMADDR in target.  Set *ERRNOP to the errno code, or 0 if successful.
    Set *STRING to a pointer to malloc'd memory containing the data; the caller
@@ -816,68 +814,18 @@ int
 target_read_string (CORE_ADDR memaddr, gdb::unique_xmalloc_ptr<char> *string,
 		    int len, int *errnop)
 {
-  int tlen, offset, i;
-  gdb_byte buf[4];
-  int errcode = 0;
-  char *buffer;
-  int buffer_allocated;
-  char *bufptr;
-  unsigned int nbytes_read = 0;
-
-  gdb_assert (string);
-
-  /* Small for testing.  */
-  buffer_allocated = 4;
-  buffer = (char *) xmalloc (buffer_allocated);
-  bufptr = buffer;
-
-  while (len > 0)
-    {
-      tlen = MIN (len, 4 - (memaddr & 3));
-      offset = memaddr & 3;
+  int bytes_read;
+  gdb::unique_xmalloc_ptr<gdb_byte> buffer;
 
-      errcode = target_read_memory (memaddr & ~3, buf, sizeof buf);
-      if (errcode != 0)
-	{
-	  /* The transfer request might have crossed the boundary to an
-	     unallocated region of memory.  Retry the transfer, requesting
-	     a single byte.  */
-	  tlen = 1;
-	  offset = 0;
-	  errcode = target_read_memory (memaddr, buf, 1);
-	  if (errcode != 0)
-	    goto done;
-	}
-
-      if (bufptr - buffer + tlen > buffer_allocated)
-	{
-	  unsigned int bytes;
+  /* Note that the endian-ness does not matter here.  */
+  int errcode = read_string (memaddr, -1, 1, len, BFD_ENDIAN_LITTLE,
+			     &buffer, &bytes_read);
 
-	  bytes = bufptr - buffer;
-	  buffer_allocated *= 2;
-	  buffer = (char *) xrealloc (buffer, buffer_allocated);
-	  bufptr = buffer + bytes;
-	}
-
-      for (i = 0; i < tlen; i++)
-	{
-	  *bufptr++ = buf[i + offset];
-	  if (buf[i + offset] == '\000')
-	    {
-	      nbytes_read += i + 1;
-	      goto done;
-	    }
-	}
-
-      memaddr += tlen;
-      len -= tlen;
-      nbytes_read += tlen;
-    }
-done:
-  string->reset (buffer);
-  if (errnop != NULL)
+  if (errnop != nullptr)
     *errnop = errcode;
-  return nbytes_read;
+
+  string->reset ((char *) buffer.release ());
+  return bytes_read;
 }
 
 struct target_section_table *
diff --git a/gdb/valprint.c b/gdb/valprint.c
index d5490898b9..f254980526 100644
--- a/gdb/valprint.c
+++ b/gdb/valprint.c
@@ -2027,13 +2027,7 @@ partial_memory_read (CORE_ADDR memaddr, gdb_byte *myaddr,
 
    Unless an exception is thrown, BUFFER will always be allocated, even on
    failure.  In this case, some characters might have been read before the
-   failure happened.  Check BYTES_READ to recognize this situation.
-
-   Note: There was a FIXME asking to make this code use target_read_string,
-   but this function is more general (can read past null characters, up to
-   given LEN).  Besides, it is used much more often than target_read_string
-   so it is more tested.  Perhaps callers of target_read_string should use
-   this function instead?  */
+   failure happened.  Check BYTES_READ to recognize this situation.  */
 
 int
 read_string (CORE_ADDR addr, int len, int width, unsigned int fetchlimit,

Failures on Fedora-i686, branch master

[gdb-buildbot]

Buildername:
        Fedora-i686

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/18/builds/3458

Author:
        Tom Tromey <tromey@adacore.com>

Commit tested:
        670e35fad9c17e8e166c5a6260201eebcc2ba9e6

Subject of commit:
        Rewrite target_read_string

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-i686/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6/

*** Diff to previous build ***
==============================================
PASS -> UNRESOLVED: gdb.base/shell.exp: -d spaces value missing
PASS -> UNRESOLVED: gdb.base/shell.exp: -d value missing
PASS -> UNRESOLVED: gdb.base/shell.exp: DELIM delimiter missing
PASS -> UNRESOLVED: gdb.base/shell.exp: SHELL_COMMAND missing
PASS -> UNRESOLVED: gdb.base/shell.exp: SHELL_COMMAND missing with delimiter
PASS -> UNRESOLVED: gdb.base/shell.exp: all missing
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe -"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe -d "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe -d XXX maint set test-se"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe -d XXX maint set"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe -d main"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe -d set maint set "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe -d set maint set"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe maint set test-se"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe print 1 | "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "pipe"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| -"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| -d "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| -d XXX maint set test-se"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| -d XXX maint set"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| -d main"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| -d set maint set "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| -d set maint set"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| maint set test-se"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "| print 1 | "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|-"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|-d "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|-d XXX maint set test-se"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|-d XXX maint set"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|-d main"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|-d set maint set "
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|-d set maint set"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|maint set test-se"
PASS -> UNRESOLVED: gdb.base/shell.exp: cmd complete "|print 1 | "
PASS -> UNRESOLVED: gdb.base/shell.exp: delimiter missing due to missing space
PASS -> UNRESOLVED: gdb.base/shell.exp: pipe fail exitcode
PASS -> UNRESOLVED: gdb.base/shell.exp: pipe fail exitsignal
PASS -> UNRESOLVED: gdb.base/shell.exp: pipe interrupt exitcode
PASS -> UNRESOLVED: gdb.base/shell.exp: pipe interrupt exitsignal
PASS -> UNRESOLVED: gdb.base/shell.exp: pipe success exitcode
PASS -> UNRESOLVED: gdb.base/shell.exp: pipe success exitsignal
new UNRESOLVED: gdb.base/shell.exp: set max-completions 0
new UNRESOLVED: gdb.base/shell.exp: set max-completions 2
new UNRESOLVED: gdb.base/shell.exp: show editing
new UNRESOLVED: gdb.base/shell.exp: show max-completions
PASS -> UNRESOLVED: gdb.base/shell.exp: | delimiter missing
PASS -> UNRESOLVED: gdb.base/shell.exp: |p 123| exit 0
PASS -> UNRESOLVED: gdb.base/shell.exp: |p 123| exit 1
PASS -> UNRESOLVED: gdb.base/shell.exp: |p 123| kill -2 $$
new KFAIL: gdb.base/step-over-syscall.exp: clone: displaced=on: single step over clone
PASS -> FAIL: gdb.fortran/vla-sizeof.exp: print sizeof non-allocated indexed vla1
PASS -> FAIL: gdb.linespec/explicit.exp: complete with no arguments and no symbols: cmd complete "b "
PASS -> FAIL: gdb.linespec/explicit.exp: complete with no arguments and no symbols: tab complete "b "
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-i686/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6//xfail.table.gz>

Failures on Fedora-x86_64-cc-with-index, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-cc-with-index

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/20/builds/3406

Author:
        Tom Tromey <tromey@adacore.com>

Commit tested:
        670e35fad9c17e8e166c5a6260201eebcc2ba9e6

Subject of commit:
        Rewrite target_read_string

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/non-ldr-exit.exp: program exits normally
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 3rd stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 3rd stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: outer_threads: outer stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: second thread: print i3
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-cc-with-index/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6//xfail.table.gz>

Failures on Fedora-x86_64-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-m64

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/3/builds/3515

Author:
        Tom Tromey <tromey@adacore.com>

Commit tested:
        670e35fad9c17e8e166c5a6260201eebcc2ba9e6

Subject of commit:
        Rewrite target_read_string

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6/

*** Diff to previous build ***
==============================================
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: second thread: print i3
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-m64/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m32

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/4/builds/3348

Author:
        Tom Tromey <tromey@adacore.com>

Commit tested:
        670e35fad9c17e8e166c5a6260201eebcc2ba9e6

Subject of commit:
        Rewrite target_read_string

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.base/options.exp: test-print: cmd complete "thread apply all print "
PASS -> FAIL: gdb.base/options.exp: test-print: tab complete "thread apply all print "
PASS -> FAIL: gdb.fortran/vla-ptype.exp: ptype vla1
PASS -> FAIL: gdb.fortran/vla-value.exp: print member in non-allocated vla1
PASS -> FAIL: gdb.fortran/vla-value.exp: set member in non-allocated vla1
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=1: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=1: print re_run_var_1
new UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: delete all breakpoints in delete_breakpoints
PASS -> UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: setting breakpoint at all_started
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=1: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=1: print re_run_var_2
new UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: delete all breakpoints in delete_breakpoints
PASS -> UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: setting breakpoint at all_started
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=off: cond_bp_target=1: inferior 1 exited
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m32/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6//xfail.table.gz>

Failures on Fedora-x86_64-native-extended-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-extended-gdbserver-m64

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/2/builds/3349

Author:
        Tom Tromey <tromey@adacore.com>

Commit tested:
        670e35fad9c17e8e166c5a6260201eebcc2ba9e6

Subject of commit:
        Rewrite target_read_string

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 10: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 10: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 10: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 3: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 3: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 3: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 3: detach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 3: reset timer in the inferior
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 4: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 4: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 4: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 4: detach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 4: reset timer in the inferior
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 5: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 5: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 5: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 5: detach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 5: reset timer in the inferior
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 6: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 6: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 6: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 6: detach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 6: reset timer in the inferior
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 7: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 7: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 7: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 7: detach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 7: reset timer in the inferior
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 8: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 8: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 8: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 8: detach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 8: reset timer in the inferior
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 9: break at break_fn: 1
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 9: break at break_fn: 2
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 9: break at break_fn: 3
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 9: detach
PASS -> FAIL: gdb.threads/attach-many-short-lived-threads.exp: iter 9: reset timer in the inferior
PASS -> FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: inferior 1 exited
PASS -> FAIL: gdb.threads/fork-plus-threads.exp: detach-on-fork=off: only inferior 1 left
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print k
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print r
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_func: 1st call: 2nd thread: print z
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 2nd stop: print j
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: single_scope: first thread: print i3
PASS -> FAIL: gdb.threads/thread-unwindonsignal.exp: continue until exit
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-extended-gdbserver-m64/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m32

Worker:
        fedora-x86-64-3

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/24/builds/3361

Author:
        Tom Tromey <tromey@adacore.com>

Commit tested:
        670e35fad9c17e8e166c5a6260201eebcc2ba9e6

Subject of commit:
        Rewrite target_read_string

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=1: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=1: print re_run_var_1
new UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: delete all breakpoints in delete_breakpoints
PASS -> UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=1: iter=2: setting breakpoint at all_started
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=1: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=1: print re_run_var_2
new UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: delete all breakpoints in delete_breakpoints
PASS -> UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: setting breakpoint at all_started
PASS -> KFAIL: gdb.threads/process-dies-while-handling-bp.exp: non_stop=on: cond_bp_target=0: inferior 1 exited
new KFAIL: gdb.threads/watchthreads2.exp: gdb can drop watchpoints in multithreaded app
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m32/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6//xfail.table.gz>

Failures on Fedora-x86_64-native-gdbserver-m64, branch master

[gdb-buildbot]

Buildername:
        Fedora-x86_64-native-gdbserver-m64

Worker:
        fedora-x86-64-4

Full Build URL:
	https://gdb-buildbot.osci.io/#builders/22/builds/3360

Author:
        Tom Tromey <tromey@adacore.com>

Commit tested:
        670e35fad9c17e8e166c5a6260201eebcc2ba9e6

Subject of commit:
        Rewrite target_read_string

Testsuite logs (gdb.sum, gdb.log and others):
        https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6/

*** Diff to previous build ***
==============================================
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=1: continue until exit
PASS -> FAIL: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=1: print re_run_var_2
new UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: delete all breakpoints in delete_breakpoints
PASS -> UNRESOLVED: gdb.multi/multi-re-run.exp: re_run_inf=2: iter=2: setting breakpoint at all_started
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 4th stop: print i
PASS -> KFAIL: gdb.threads/omp-par-scope.exp: nested_parallel: inner_threads: 4th stop: print j
PASS -> FAIL: gdb.threads/thread-unwindonsignal.exp: continue until exit
PASS -> FAIL: gdb.trace/ftrace.exp: advance through tracing
==============================================

*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6//xfail.gz>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

        <https://gdb-buildbot.osci.io/results/Fedora-x86_64-native-gdbserver-m64/67/670e35fad9c17e8e166c5a6260201eebcc2ba9e6//xfail.table.gz>