public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] PowerPC PLT stub alignment fixes Date: Thu, 18 Jan 2018 12:14:00 -0000 [thread overview] Message-ID: <691d2e9af211ff8dd5fa8c96cb961b73a78394d7@gdb-build> (raw) *** TEST RESULTS FOR COMMIT 691d2e9af211ff8dd5fa8c96cb961b73a78394d7 *** Author: Alan Modra <amodra@gmail.com> Branch: master Commit: 691d2e9af211ff8dd5fa8c96cb961b73a78394d7 PowerPC PLT stub alignment fixes Asking for ppc32 plt call stubs to be aligned at 32 byte boundaries didn't quite work. For ld.bfd they were spaced 32 bytes apart, but only started on a 16 byte boundary. ld.gold also didn't get it right. Finding that bug made me check over the ppc64 plt stub alignment, where I found that negative values for alignment (meaning align to minimize boundary crossing) were not accepted. Since no one has complained about that, I guess I could have removed the feature from ld.bfd documentation, but I've opted instead to correct the code. I've also added an optional alignment paramenter for ppc32 --plt-align, for some consistency with gold and ppc64 ld.bfd. bfd/ * elf32-ppc.c (ppc_elf_create_glink): Correct alignment of .glink. * elf64-ppc.c (ppc64_elf_size_stubs): Handle negative plt_stub_align. (ppc64_elf_build_stubs): Likewise. gold/ * powerpc.cc (param_plt_align): New function supplying default --plt-align values. Use it.. (Stub_table::plt_call_align): ..here, and.. (Output_data_glink::global_entry_align): ..here. (Stub_table::stub_align): Correct 32-bit minimum alignment. ld/ * emultempl/ppc32elf.em: Support optional --plt-align arg. * emultempl/ppc64elf.em: Support negative --plt-align arg.
next reply other threads:[~2018-01-18 12:14 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-18 12:14 sergiodj+buildbot [this message] 2018-01-18 12:14 ` Failures on RHEL-s390x-m64, branch master sergiodj+buildbot 2018-01-18 12:16 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot 2018-01-18 12:16 ` Failures on Debian-s390x-m64, " sergiodj+buildbot 2018-01-18 12:17 ` Failures on Fedora-i686, " sergiodj+buildbot 2018-01-18 12:19 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot 2018-01-18 12:31 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot 2018-01-18 12:32 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot 2018-01-18 12:38 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot 2018-01-18 12:40 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot 2018-01-18 12:44 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot 2018-01-18 12:49 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot 2018-01-18 15:09 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, " sergiodj+buildbot 2018-01-18 15:53 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot 2018-01-18 18:11 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot 2018-01-19 8:12 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot 2018-01-19 9:18 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot 2018-01-19 10:09 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=691d2e9af211ff8dd5fa8c96cb961b73a78394d7@gdb-build \ --to=sergiodj+buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).