From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from kwanyin.sergiodj.net (kwanyin.sergiodj.net [158.69.185.54]) by sourceware.org (Postfix) with ESMTPS id B8AD9385E006 for ; Fri, 27 Mar 2020 19:29:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B8AD9385E006 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [binutils-gdb] Introduce c_value_print_array From: gdb-buildbot@sergiodj.net To: gdb-testers@sourceware.org Message-Id: <6999f067c1b30c1a2c3e41a0f68f74e459652560@gdb-build> Date: Fri, 27 Mar 2020 15:29:58 -0400 X-Spam-Status: No, score=-15.5 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_CSS, URIBL_CSS_A autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-testers@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-testers mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2020 19:30:01 -0000 *** TEST RESULTS FOR COMMIT 6999f067c1b30c1a2c3e41a0f68f74e459652560 *** commit 6999f067c1b30c1a2c3e41a0f68f74e459652560 Author: Tom Tromey AuthorDate: Fri Mar 13 17:39:52 2020 -0600 Commit: Tom Tromey CommitDate: Fri Mar 13 18:03:41 2020 -0600 Introduce c_value_print_array This adds c_value_print_array, a value-based analogue of c_val_print_array. gdb/ChangeLog 2020-03-13 Tom Tromey * c-valprint.c (c_value_print_array): New function. (c_value_print_inner): Use it. diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 15d20e18e0..85894e72a1 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2020-03-13 Tom Tromey + + * c-valprint.c (c_value_print_array): New function. + (c_value_print_inner): Use it. + 2020-03-13 Tom Tromey * c-valprint.c (c_value_print_memberptr): New function. diff --git a/gdb/c-valprint.c b/gdb/c-valprint.c index d1a0816f43..dd4ab728c2 100644 --- a/gdb/c-valprint.c +++ b/gdb/c-valprint.c @@ -335,6 +335,102 @@ c_val_print_array (struct type *type, const gdb_byte *valaddr, } } +/* c_value_print helper for TYPE_CODE_ARRAY. */ + +static void +c_value_print_array (struct value *val, + struct ui_file *stream, int recurse, + const struct value_print_options *options) +{ + struct type *type = check_typedef (value_type (val)); + CORE_ADDR address = value_address (val); + const gdb_byte *valaddr = value_contents_for_printing (val); + struct type *unresolved_elttype = TYPE_TARGET_TYPE (type); + struct type *elttype = check_typedef (unresolved_elttype); + + if (TYPE_LENGTH (type) > 0 && TYPE_LENGTH (unresolved_elttype) > 0) + { + LONGEST low_bound, high_bound; + int eltlen, len; + enum bfd_endian byte_order = type_byte_order (type); + + if (!get_array_bounds (type, &low_bound, &high_bound)) + error (_("Could not determine the array high bound")); + + eltlen = TYPE_LENGTH (elttype); + len = high_bound - low_bound + 1; + if (options->prettyformat_arrays) + { + print_spaces_filtered (2 + 2 * recurse, stream); + } + + /* Print arrays of textual chars with a string syntax, as + long as the entire array is valid. */ + if (c_textual_element_type (unresolved_elttype, + options->format) + && value_bytes_available (val, 0, TYPE_LENGTH (type)) + && !value_bits_any_optimized_out (val, 0, + TARGET_CHAR_BIT * TYPE_LENGTH (type))) + { + int force_ellipses = 0; + + /* If requested, look for the first null char and only + print elements up to it. */ + if (options->stop_print_at_null) + { + unsigned int temp_len; + + for (temp_len = 0; + (temp_len < len + && temp_len < options->print_max + && extract_unsigned_integer (valaddr + temp_len * eltlen, + eltlen, byte_order) != 0); + ++temp_len) + ; + + /* Force LA_PRINT_STRING to print ellipses if + we've printed the maximum characters and + the next character is not \000. */ + if (temp_len == options->print_max && temp_len < len) + { + ULONGEST ival + = extract_unsigned_integer (valaddr + temp_len * eltlen, + eltlen, byte_order); + if (ival != 0) + force_ellipses = 1; + } + + len = temp_len; + } + + LA_PRINT_STRING (stream, unresolved_elttype, valaddr, len, + NULL, force_ellipses, options); + } + else + { + unsigned int i = 0; + fprintf_filtered (stream, "{"); + /* If this is a virtual function table, print the 0th + entry specially, and the rest of the members + normally. */ + if (cp_is_vtbl_ptr_type (elttype)) + { + i = 1; + fprintf_filtered (stream, _("%d vtable entries"), + len - 1); + } + value_print_array_elements (val, stream, recurse, options, i); + fprintf_filtered (stream, "}"); + } + } + else + { + /* Array of unspecified length: treat like pointer to first elt. */ + print_unpacked_pointer (type, elttype, unresolved_elttype, valaddr, + 0, address, stream, recurse, options); + } +} + /* c_val_print helper for TYPE_CODE_PTR. */ static void @@ -657,8 +753,7 @@ c_value_print_inner (struct value *val, struct ui_file *stream, int recurse, switch (TYPE_CODE (type)) { case TYPE_CODE_ARRAY: - c_val_print_array (type, valaddr, 0, address, stream, - recurse, val, options); + c_value_print_array (val, stream, recurse, options); break; case TYPE_CODE_METHODPTR: