public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] gdb: remove unused includes from dwarf2read.c
Date: Sun, 20 Oct 2019 00:10:00 -0000	[thread overview]
Message-ID: <6acc1a0b9d3dd16741474891eddbf77415cd70b1@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 6acc1a0b9d3dd16741474891eddbf77415cd70b1 ***

commit 6acc1a0b9d3dd16741474891eddbf77415cd70b1
Author:     Simon Marchi <simon.marchi@polymtl.ca>
AuthorDate: Sun Oct 13 00:46:13 2019 -0400
Commit:     Simon Marchi <simon.marchi@polymtl.ca>
CommitDate: Mon Oct 14 10:15:51 2019 -0400

    gdb: remove unused includes from dwarf2read.c
    
    include-what-you-use says:
    
    ../../../src/binutils-gdb/gdb/dwarf2read.c should remove these lines:
    - #include <ctype.h>  // lines 67-67
    - #include <sys/stat.h>  // lines 59-59
    - #include <sys/types.h>  // lines 83-83
    - #include <cmath>  // lines 88-88
    - #include <forward_list>  // lines 90-90
    - #include <set>  // lines 89-89
    - #include <unordered_set>  // lines 85-85
    - #include "completer.h"  // lines 60-60
    - #include "expression.h"  // lines 44-44
    - #include "gdbsupport/byte-vector.h"  // lines 78-78
    - #include "gdbsupport/filestuff.h"  // lines 71-71
    - #include "gdbsupport/gdb_unlinker.h"  // lines 74-74
    
    After a quick glance, that makes sense, so this patch removes them.
    
    gdb/ChangeLog:
    
            * dwarf2read.c: Remove includes.
    
    Change-Id: I13cfcb2f1d747144fddba7f66b329630b79dae90

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index bcedf02448..c6fff16af4 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
+
+	* dwarf2read.c: Remove includes.
+
 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 
 	* ui-out.c (ui_out::call_do_message): Silence
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index ee9df34ed2..5d072f569e 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -41,7 +41,6 @@
 #include "buildsym.h"
 #include "demangle.h"
 #include "gdb-demangle.h"
-#include "expression.h"
 #include "filenames.h"	/* for DOSish file names */
 #include "macrotab.h"
 #include "language.h"
@@ -56,38 +55,27 @@
 #include "addrmap.h"
 #include "typeprint.h"
 #include "psympriv.h"
-#include <sys/stat.h>
-#include "completer.h"
 #include "gdbsupport/vec.h"
 #include "c-lang.h"
 #include "go-lang.h"
 #include "valprint.h"
 #include "gdbcore.h" /* for gnutarget */
 #include "gdb/gdb-index.h"
-#include <ctype.h>
 #include "gdb_bfd.h"
 #include "f-lang.h"
 #include "source.h"
-#include "gdbsupport/filestuff.h"
 #include "build-id.h"
 #include "namespace.h"
-#include "gdbsupport/gdb_unlinker.h"
 #include "gdbsupport/function-view.h"
 #include "gdbsupport/gdb_optional.h"
 #include "gdbsupport/underlying.h"
-#include "gdbsupport/byte-vector.h"
 #include "gdbsupport/hash_enum.h"
 #include "filename-seen-cache.h"
 #include "producer.h"
 #include <fcntl.h>
-#include <sys/types.h>
 #include <algorithm>
-#include <unordered_set>
 #include <unordered_map>
 #include "gdbsupport/selftest.h"
-#include <cmath>
-#include <set>
-#include <forward_list>
 #include "rust-lang.h"
 #include "gdbsupport/pathstuff.h"
 


             reply	other threads:[~2019-10-20  0:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-20  0:10 gdb-buildbot [this message]
2019-10-20  0:10 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot
2019-10-20  1:35 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, " gdb-buildbot
2019-10-20  2:24 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, " gdb-buildbot
2019-10-27 17:52 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2019-10-27 18:03 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2019-10-27 19:31 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6acc1a0b9d3dd16741474891eddbf77415cd70b1@gdb-build \
    --to=gdb-buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).