public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: sergiodj+buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] s390: Hook s390 into OSABI mechanism
Date: Tue, 23 Jan 2018 14:30:00 -0000	[thread overview]
Message-ID: <7042632bf7976d29889ba89fe4867654c5f38e2d@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 7042632bf7976d29889ba89fe4867654c5f38e2d ***

Author: Philipp Rudo <prudo@linux.vnet.ibm.com>
Branch: master
Commit: 7042632bf7976d29889ba89fe4867654c5f38e2d

s390: Hook s390 into OSABI mechanism

Do what the title says and distinguish between 31- and 64-bit systems.
The goal is to init the OSABI as late as possible in gdbarch_init so the
OSABI has the chance to overwrite the defaults.

There are two pitfalls to be aware of:

First, the dwarf2 unwinder must be appended before the OSABI is
initialized.  Otherwise the OS could add a default unwinder which always
takes control before the dwarf unwinder even gets a chance.

Second, tdesc_use_registers has to be handled with extra care.  It sets
several gdbarch hooks, especially gdbarch_register_name, which has to be
overwritten again after the call.  Furthermore it deletes the tdesc_data
without checking.  Therefore there must not be a call to
tdesc_data_cleanup afterwards or GDB will crash with a double free.

gdb/ChangeLog:

	* s390-linux-tdep.c (osabi.h): New include.
	(s390_linux_init_abi_31, s390_linux_init_abi_64)
	(s390_linux_init_abi_any): New functions.
	(s390_gdbarch_init, _initialize_s390_tdep): Adjust.


             reply	other threads:[~2018-01-23 14:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-23 14:30 sergiodj+buildbot [this message]
2018-01-23 14:30 ` Failures on RHEL-s390x-m64, branch master sergiodj+buildbot
2018-01-23 17:55 ` Failures on Fedora-s390x-m64, " sergiodj+buildbot
2018-01-23 18:06 ` Failures on Debian-s390x-m64, " sergiodj+buildbot
2018-01-23 18:11 ` Failures on Fedora-x86_64-native-gdbserver-m32, " sergiodj+buildbot
2018-01-23 18:11 ` Failures on Fedora-i686, " sergiodj+buildbot
2018-01-23 18:12 ` Failures on Fedora-x86_64-m64, " sergiodj+buildbot
2018-01-23 18:22 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " sergiodj+buildbot
2018-01-23 18:28 ` Failures on Fedora-x86_64-m32, " sergiodj+buildbot
2018-01-23 18:33 ` Failures on Fedora-x86_64-cc-with-index, " sergiodj+buildbot
2018-01-23 18:34 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " sergiodj+buildbot
2018-01-23 18:35 ` Failures on Debian-s390x-native-gdbserver-m64, " sergiodj+buildbot
2018-01-23 18:36 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " sergiodj+buildbot
2018-01-23 18:46 ` Failures on Fedora-x86_64-native-gdbserver-m64, " sergiodj+buildbot
2018-01-23 21:58 ` Failures on Ubuntu-AArch64-native-gdbserver-m64, " sergiodj+buildbot
2018-01-23 22:35 ` Failures on Ubuntu-AArch64-m64, " sergiodj+buildbot
2018-01-24  0:31 ` Failures on Ubuntu-AArch32-native-extended-gdbserver-m32, " sergiodj+buildbot
2018-01-24  1:03 ` Failures on Ubuntu-AArch32-native-gdbserver-m32, " sergiodj+buildbot
2018-01-24  1:35 ` Failures on Ubuntu-AArch32-m32, " sergiodj+buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7042632bf7976d29889ba89fe4867654c5f38e2d@gdb-build \
    --to=sergiodj+buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).