public inbox for gdb-testers@sourceware.org help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net To: gdb-testers@sourceware.org Subject: [binutils-gdb] [gdb/testsuite] Fix .debug_aranges in gdb.dlang/watch-loc.c Date: Tue, 05 May 2020 12:47:47 -0400 [thread overview] Message-ID: <714534e1b88608f92b6946d8e5a24ea51a40e363@gdb-build> (raw) *** TEST RESULTS FOR COMMIT 714534e1b88608f92b6946d8e5a24ea51a40e363 *** commit 714534e1b88608f92b6946d8e5a24ea51a40e363 Author: Tom de Vries <tdevries@suse.de> AuthorDate: Wed Apr 22 13:17:32 2020 +0200 Commit: Tom de Vries <tdevries@suse.de> CommitDate: Wed Apr 22 13:17:32 2020 +0200 [gdb/testsuite] Fix .debug_aranges in gdb.dlang/watch-loc.c While investigating PR25862 (an assertion failure with target board cc-with-debug-names), I noticed that the .debug_aranges section in gdb.dlang/watch-loc.c contains a hardcoded 0x1000: ... " .4byte _Dmain \n" // Address " .4byte 0x1000 \n" // Length ... Fix this by using the actual length of _Dmain, along the lines of how that is done in gdb.mi/dw2-ref-missing-frame-func.c: ... " .4byte _Dmain_end - _Dmain \n" // Length ... such that the .debug_aranges entry: ... Address Length 004004a7 0000000b 00000000 00000000 ... matches the addresses found in the corresponding CU: ... <2><fd>: Abbrev Number: 6 (DW_TAG_subprogram) <fe> DW_AT_name : _Dmain <105> DW_AT_low_pc : 0x4004a7 <10d> DW_AT_high_pc : 0x4004b2 ... With this fix the assertion failure is no longer triggered for gdb.dlang/watch-loc.exp. Tested on x86_64-linux. gdb/testsuite/ChangeLog: 2020-04-22 Tom de Vries <tdevries@suse.de> * gdb.dlang/watch-loc.c (.debug_aranges): Fix _Dmain length. diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 26a15d5d0e..33ba594e19 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2020-04-22 Tom de Vries <tdevries@suse.de> + + * gdb.dlang/watch-loc.c (.debug_aranges): Fix _Dmain length. + 2020-02-18 Mihails Strasuns <mihails.strasuns@intel.com> * gdb.base/jit-attach-pie.c: Use jit-protocol.h. diff --git a/gdb/testsuite/gdb.dlang/watch-loc.c b/gdb/testsuite/gdb.dlang/watch-loc.c index c3159ce107..de594f35ae 100644 --- a/gdb/testsuite/gdb.dlang/watch-loc.c +++ b/gdb/testsuite/gdb.dlang/watch-loc.c @@ -28,6 +28,8 @@ int _Dmain (void) return 0; } +asm ("_Dmain_end: .globl _Dmain_end"); + int main (void) { @@ -51,7 +53,7 @@ asm ( " .2byte 0 \n" // Pad to 16 byte boundary " .2byte 0 \n" " .4byte _Dmain \n" // Address -" .4byte 0x1000 \n" // Length +" .4byte _Dmain_end - _Dmain \n" // Length " .4byte 0 \n" " .4byte 0 \n" ".Laranges_end: \n"
next reply other threads:[~2020-05-05 16:47 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-05 16:47 gdb-buildbot [this message] 2020-05-05 16:47 ` Failures on Fedora-i686, branch master gdb-buildbot 2020-05-05 17:18 ` Failures on Fedora-x86_64-m32, " gdb-buildbot 2020-05-05 17:36 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot 2020-05-05 17:49 ` Failures on Fedora-x86_64-m64, " gdb-buildbot 2020-05-05 18:28 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot 2020-05-05 18:32 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot 2020-05-06 19:30 ` Failures on Fedora-x86_64-native-gdbserver-m32, " gdb-buildbot 2020-05-08 2:48 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot 2020-05-11 19:30 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, " gdb-buildbot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=714534e1b88608f92b6946d8e5a24ea51a40e363@gdb-build \ --to=gdb-buildbot@sergiodj.net \ --cc=gdb-testers@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).