public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
From: gdb-buildbot@sergiodj.net
To: gdb-testers@sourceware.org
Subject: [binutils-gdb] Don't call tui_refresh_all from show_layout
Date: Sat, 31 Aug 2019 00:20:00 -0000	[thread overview]
Message-ID: <715bb467feab6e94e01bdf4f5aced092df7398c0@gdb-build> (raw)

*** TEST RESULTS FOR COMMIT 715bb467feab6e94e01bdf4f5aced092df7398c0 ***

commit 715bb467feab6e94e01bdf4f5aced092df7398c0
Author:     Tom Tromey <tom@tromey.com>
AuthorDate: Thu Jul 18 13:46:23 2019 -0600
Commit:     Tom Tromey <tom@tromey.com>
CommitDate: Fri Aug 30 12:57:07 2019 -0600

    Don't call tui_refresh_all from show_layout
    
    show_layout calls tui_refresh_all in one case.  However, it doesn't
    need to any more, because the resize method on each window will also
    update the contents.
    
    gdb/ChangeLog
    2019-08-30  Tom Tromey  <tom@tromey.com>
    
            * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4f20a78a8c..2a027a212d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2019-08-30  Tom Tromey  <tom@tromey.com>
+
+	* tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
+
 2019-08-30  Tom Tromey  <tom@tromey.com>
 
 	* tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
diff --git a/gdb/tui/tui-layout.c b/gdb/tui/tui-layout.c
index 7ec704e52f..df7056ae97 100644
--- a/gdb/tui/tui-layout.c
+++ b/gdb/tui/tui-layout.c
@@ -82,7 +82,6 @@ show_layout (enum tui_layout_type layout)
 	case SRC_DATA_COMMAND:
 	case DISASSEM_DATA_COMMAND:
 	  show_data (layout);
-	  tui_refresh_all ();
 	  break;
 	  /* Now show the new layout.  */
 	case SRC_COMMAND:


             reply	other threads:[~2019-08-30 23:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-31  0:20 gdb-buildbot [this message]
2019-08-31  0:24 ` Failures on Ubuntu-Aarch64-m64, branch master gdb-buildbot
2019-08-31  0:46 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, " gdb-buildbot
2019-08-31  3:47 ` Failures on Debian-s390x-m64, " gdb-buildbot
2019-08-31  4:03 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " gdb-buildbot
2019-08-31  4:08 ` Failures on Debian-s390x-native-gdbserver-m64, " gdb-buildbot
2019-08-31  6:54 ` Failures on Fedora-i686, " gdb-buildbot
2019-08-31  7:03 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2019-08-31  7:25 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2019-08-31  7:31 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2019-08-31  7:40 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot
2019-08-31  7:53 ` Failures on Fedora-x86_64-native-gdbserver-m64, " gdb-buildbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=715bb467feab6e94e01bdf4f5aced092df7398c0@gdb-build \
    --to=gdb-buildbot@sergiodj.net \
    --cc=gdb-testers@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).