public inbox for gdb-testers@sourceware.org
help / color / mirror / Atom feed
* [binutils-gdb] Rename a private data member in tui_source_window
@ 2019-09-20 23:58 gdb-buildbot
  2019-09-20 23:59 ` Failures on RHEL-s390x-m64, branch master gdb-buildbot
                   ` (11 more replies)
  0 siblings, 12 replies; 13+ messages in thread
From: gdb-buildbot @ 2019-09-20 23:58 UTC (permalink / raw)
  To: gdb-testers

*** TEST RESULTS FOR COMMIT 7226433c44e3792aeea6ad19c54cd3056ea4308e ***

commit 7226433c44e3792aeea6ad19c54cd3056ea4308e
Author:     Tom Tromey <tom@tromey.com>
AuthorDate: Mon Sep 2 08:10:44 2019 -0600
Commit:     Tom Tromey <tom@tromey.com>
CommitDate: Fri Sep 20 13:49:11 2019 -0600

    Rename a private data member in tui_source_window
    
    This renames tui_source_window::fullname to add the "m_" prefix, as it
    is a private data member.
    
    gdb/ChangeLog
    2019-09-20  Tom Tromey  <tom@tromey.com>
    
            * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
            from "fullname".
            * tui/tui-source.c (tui_source_window::set_contents)
            (tui_source_window::location_matches_p)
            (tui_source_window::maybe_update): Update.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 96bf00595d..3b2fdd2056 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,11 @@
+2019-09-20  Tom Tromey  <tom@tromey.com>
+
+	* tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
+	from "fullname".
+	* tui/tui-source.c (tui_source_window::set_contents)
+	(tui_source_window::location_matches_p)
+	(tui_source_window::maybe_update): Update.
+
 2019-09-20  Tom Tromey  <tom@tromey.com>
 
 	* tui/tui-regs.h (struct tui_data_window) <get_current_group>:
diff --git a/gdb/tui/tui-source.c b/gdb/tui/tui-source.c
index e6cc0dbc1a..fa6ed7893f 100644
--- a/gdb/tui/tui-source.c
+++ b/gdb/tui/tui-source.c
@@ -155,7 +155,7 @@ tui_source_window::set_contents (struct gdbarch *arch,
 
 	  title = s_filename;
 
-	  fullname = make_unique_xstrdup (symtab_to_fullname (s));
+	  m_fullname = make_unique_xstrdup (symtab_to_fullname (s));
 
 	  cur_line = 0;
 	  gdbarch = get_objfile_arch (SYMTAB_OBJFILE (s));
@@ -275,7 +275,7 @@ tui_source_window::location_matches_p (struct bp_location *loc, int line_no)
   return (content[line_no].line_or_addr.loa == LOA_LINE
 	  && content[line_no].line_or_addr.u.line_no == loc->line_number
 	  && loc->symtab != NULL
-	  && filename_cmp (fullname.get (),
+	  && filename_cmp (m_fullname.get (),
 			   symtab_to_fullname (loc->symtab)) == 0);
 }
 
@@ -307,7 +307,7 @@ tui_source_window::maybe_update (struct frame_info *fi, symtab_and_line sal,
     start_line = 1;
 
   bool source_already_displayed = (sal.symtab != 0
-				   && showing_source_p (fullname.get ()));
+				   && showing_source_p (m_fullname.get ()));
 
   struct tui_line_or_address l;
 
diff --git a/gdb/tui/tui-source.h b/gdb/tui/tui-source.h
index 30728e4214..3ef737c56e 100644
--- a/gdb/tui/tui-source.h
+++ b/gdb/tui/tui-source.h
@@ -77,7 +77,7 @@ private:
   bool line_is_displayed (int line) const;
 
   /* It is the resolved form as returned by symtab_to_fullname.  */
-  gdb::unique_xmalloc_ptr<char> fullname;
+  gdb::unique_xmalloc_ptr<char> m_fullname;
 
   /* A token used to register and unregister an observer.  */
   gdb::observers::token m_observable;


^ permalink raw reply	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2019-09-21 22:24 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-20 23:58 [binutils-gdb] Rename a private data member in tui_source_window gdb-buildbot
2019-09-20 23:59 ` Failures on RHEL-s390x-m64, branch master gdb-buildbot
2019-09-21  5:28 ` Failures on Ubuntu-Aarch64-m64, " gdb-buildbot
2019-09-21  5:51 ` Failures on Ubuntu-Aarch64-native-extended-gdbserver-m64, " gdb-buildbot
2019-09-21  6:01 ` Failures on Ubuntu-Aarch64-native-gdbserver-m64, " gdb-buildbot
2019-09-21 11:42 ` Failures on Debian-s390x-m64, " gdb-buildbot
2019-09-21 12:02 ` Failures on Debian-s390x-native-extended-gdbserver-m64, " gdb-buildbot
2019-09-21 12:06 ` Failures on Debian-s390x-native-gdbserver-m64, " gdb-buildbot
2019-09-21 22:12 ` Failures on Fedora-x86_64-cc-with-index, " gdb-buildbot
2019-09-21 22:32 ` Failures on Fedora-x86_64-m64, " gdb-buildbot
2019-09-21 22:39 ` Failures on Fedora-x86_64-m32, " gdb-buildbot
2019-09-21 22:40 ` Failures on Fedora-x86_64-native-extended-gdbserver-m32, " gdb-buildbot
2019-09-21 23:07 ` Failures on Fedora-x86_64-native-extended-gdbserver-m64, " gdb-buildbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).