[binutils-gdb] Make the intepreters output to all UIs

[binutils-gdb] Make the intepreters output to all UIs

[sergiodj+buildbot]

*** TEST RESULTS FOR COMMIT 73ab01a07dfef77a9d845be2ef87754435eeffa1 ***

Author: Pedro Alves <palves@redhat.com>
Branch: master
Commit: 73ab01a07dfef77a9d845be2ef87754435eeffa1

Make the intepreters output to all UIs

When we have multiple consoles, MI channels, etc., then we need to
broadcast breakpoint hits, etc. to all UIs.  In the past, I've
adjusted most of the run control to communicate events to the
interpreters through observer notifications, so events would be
properly sent to console and MI streams, in sync and async modes.

This patch does the next logical step -- have each interpreter's
observers output interpreter-specific info to _all_ UIs.

Note that when we have multiple instances of active cli/tui
interpreters, then the cli_interp and tui_interp globals no longer
work.  This is addressed by this patch.

Also, the interpreters currently register some observers when resumed
and remove them when suspended.  If we have multiple instances of the
interpreters, and they can be suspended/resumed at different,
independent times, that no longer works.  What we instead do is always
install the observers, and then have the observers themselves know
when to do nothing.

An earlier prototype of this series did the looping over struct UIs in
common code, and then dispatched events to the interpreters through a
matching interp_on_foo method for each observer.  That turned out a
lot more complicated than the present solution, as we'd end up with
having to create a new interp method every time some interpreter
wanted to listen to some observer notification, resulting in a lot of
duplicated make-work and more coupling than desirable.

gdb/ChangeLog:
2016-06-21  Pedro Alves  <palves@redhat.com>

	* cli/cli-interp.c (cli_interp): Delete.
	(as_cli_interp): New function.
	(cli_on_normal_stop, cli_on_signal_received)
	(cli_on_end_stepping_range, cli_on_signal_exited, cli_on_exited)
	(cli_on_no_history): Send output to all CLI UIs.
	(cli_on_sync_execution_done, cli_on_command_error): Skip output if
	the top level interpreter is not a CLI.
	(cli_interpreter_init): Don't set cli_interp or install observers
	here.
	(_initialize_cli_interp): Install observers here.
	* event-top.c (main_ui_, ui_list): New globals.
	(current_ui): Point to main_ui_.
	(restore_ui_cleanup, switch_thru_all_uis_init)
	(switch_thru_all_uis_cond, switch_thru_all_uis_next): New
	functions.
	* mi/mi-interp.c (as_mi_interp): New function.
	(mi_interpreter_init): Don't install observers here.
	(mi_on_sync_execution_done): Skip output if the top level
	interpreter is not a MI.
	(mi_new_thread, mi_thread_exit, mi_record_changed)
	(mi_inferior_added, mi_inferior_appeared, mi_inferior_exit)
	(mi_inferior_removed): Send output to all MI UIs.
	(find_mi_interpreter, mi_interp_data): Delete.
	(find_mi_interp): New function.
	(mi_on_signal_received, mi_on_end_stepping_range)
	(mi_on_signal_exited, mi_on_exited, mi_on_no_history): Send output
	to all MI UIs.
	(mi_on_normal_stop): Rename to ...
	(mi_on_normal_stop_1): ... this.
	(mi_on_normal_stop): Reimplement, sending output to all MI UIs.
	(mi_traceframe_changed, mi_tsv_created, mi_tsv_deleted)
	(mi_tsv_modified, mi_breakpoint_created, mi_breakpoint_deleted)
	(mi_breakpoint_modified, mi_output_running_pid): Send output to
	all MI UIs.
	(mi_on_resume): Rename to ...
	(mi_on_resume_1): ... this.  Don't handle infcalls here.
	(mi_on_resume): Reimplement, sending output to all MI UIs.
	(mi_solib_loaded, mi_solib_unloaded, mi_command_param_changed)
	(mi_memory_changed): Send output to all MI UIs.
	(report_initial_inferior): Install observers here.
	* top.h (struct ui) <next>: New field.
	(ui_list): Declare.
	(struct switch_thru_all_uis): New.
	(switch_thru_all_uis_init, switch_thru_all_uis_cond)
	(switch_thru_all_uis_next): Declare.
	(SWITCH_THRU_ALL_UIS): New macro.
	* tui/tui-interp.c (tui_interp): Delete global.
	(as_tui_interp): New function.
	(tui_on_normal_stop, tui_on_signal_received)
	(tui_on_end_stepping_range, tui_on_signal_exited, tui_on_exited)
	(tui_on_no_history): Send output to all TUI UIs.
	(tui_on_sync_execution_done, tui_on_command_error): Skip output if
	the top level interpreter is not a TUI.
	(tui_init): Don't set tui_interp or install observers here.
	(_initialize_tui_interp): Install observers here.

Failures on Fedora-i686, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-4

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/3796>

Commit(s) tested:
	73ab01a07dfef77a9d845be2ef87754435eeffa1

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Make the intepreters output to all UIs

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Fedora-i686/.git/tree/?h=master&id=7efcb43f5127b4c047cc8c459f2509680fc9c424>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.server/ext-run.exp: get process list
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-i686/xfails/master/xfail;hb=f0860e6>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-i686/xfails/master/xfail.table;hb=f0860e6>

Failures on Fedora-x86_64-native-gdbserver-m32, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-3

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-native-gdbserver-m32/builds/3783>

Commit(s) tested:
	73ab01a07dfef77a9d845be2ef87754435eeffa1

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Make the intepreters output to all UIs

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Fedora-x86_64-native-gdbserver-m32/.git/tree/?h=master&id=8181e2866b5ee860e5ef1c98754aed22652bee88>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.ada/win_fu_syms.exp: compilation foo.adb
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m32/xfails/master/xfail;hb=b2113d8>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-native-gdbserver-m32/xfails/master/xfail.table;hb=b2113d8>

Failures on Fedora-x86_64-cc-with-index, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-x86-64-2

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-x86_64-cc-with-index/builds/3756>

Commit(s) tested:
	73ab01a07dfef77a9d845be2ef87754435eeffa1

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Make the intepreters output to all UIs

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Fedora-x86_64-cc-with-index/.git/tree/?h=master&id=0a5bd6a1ae1223708845c4f38f0cad120f99048f>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/exitsignal.exp: program terminated with SIGSEGV
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail;hb=1d9d08f>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-x86_64-cc-with-index/xfails/master/xfail.table;hb=1d9d08f>

Failures on Debian-i686, branch master

[sergiodj+buildbot]

Buildslave:
	wildebeest-debian-wheezy-i686

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-i686/builds/3686>

Commit(s) tested:
	73ab01a07dfef77a9d845be2ef87754435eeffa1

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Make the intepreters output to all UIs

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Debian-i686/.git/tree/?h=master&id=b65f4f9b13e21066fa3095262aa83556fa3c0b11>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: continue: setup: continue to breakpoint: run to breakpoint in thread 2
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: continue: setup: unbreak loop in thread 2
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr1: setup: continue to breakpoint: run to breakpoint in thread 3
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr1: setup: unbreak loop in thread 3
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr1: continue to sigusr1_handler
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-i686/xfails/master/xfail;hb=b49a91b>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-i686/xfails/master/xfail.table;hb=b49a91b>

Failures on Debian-i686-native-extended-gdbserver, branch master

[sergiodj+buildbot]

Buildslave:
	wildebeest-debian-wheezy-i686

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-i686-native-extended-gdbserver/builds/3667>

Commit(s) tested:
	73ab01a07dfef77a9d845be2ef87754435eeffa1

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Make the intepreters output to all UIs

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Debian-i686-native-extended-gdbserver/.git/tree/?h=master&id=797a1dd050ddf1cdcd3d758e2d897edcd008bc2f>

*** Diff to previous build ***
============================
new FAIL: gdb.threads/attach-into-signal.exp: threaded: process is still running on the attempt # 1 of 100
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr2: setup: continue to breakpoint: run to breakpoint in thread 2
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr2: setup: unbreak loop in thread 2
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr3: setup: continue to breakpoint: run to breakpoint in thread 3
PASS -> FAIL: gdb.threads/multiple-step-overs.exp: displaced=on: signal thr3: setup: unbreak loop in thread 3
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-i686-native-extended-gdbserver/xfails/master/xfail;hb=b49a91b>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-i686-native-extended-gdbserver/xfails/master/xfail.table;hb=b49a91b>

Failures on Debian-x86_64-m64, branch master

[sergiodj+buildbot]

Buildslave:
	wildebeest-debian-wheezy-x86_64

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-x86_64-m64/builds/3603>

Commit(s) tested:
	73ab01a07dfef77a9d845be2ef87754435eeffa1

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Make the intepreters output to all UIs

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Debian-x86_64-m64/.git/tree/?h=master&id=2a635d1d13a2d0a41833b150bd7a91886286e198>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.base/step-over-syscall.exp: clone: displaced=off: single step over clone
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-x86_64-m64/xfails/master/xfail;hb=b49a91b>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-x86_64-m64/xfails/master/xfail.table;hb=b49a91b>

Failures on Debian-x86_64-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	wildebeest-debian-wheezy-x86_64

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Debian-x86_64-native-extended-gdbserver-m64/builds/3716>

Commit(s) tested:
	73ab01a07dfef77a9d845be2ef87754435eeffa1

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Make the intepreters output to all UIs

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Debian-x86_64-native-extended-gdbserver-m64/.git/tree/?h=master&id=1fa53fbc047ed2889f88c874ef154dee76321c75>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.threads/interrupted-hand-call.exp: continue until exit
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-x86_64-native-extended-gdbserver-m64/xfails/master/xfail;hb=b49a91b>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Debian-x86_64-native-extended-gdbserver-m64/xfails/master/xfail.table;hb=b49a91b>

Failures on Fedora-s390x-m64, branch master

[sergiodj+buildbot]

Buildslave:
	marist-fedora-s390x

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-s390x-m64/builds/3351>

Commit(s) tested:
	73ab01a07dfef77a9d845be2ef87754435eeffa1

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Make the intepreters output to all UIs

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/cgit/Fedora-s390x-m64/.git/tree/?h=master&id=6774fa411b1e46d1836807f0467eae64b71787ee>

*** Diff to previous build ***
============================
PASS -> FAIL: gdb.threads/watchpoint-fork.exp: child: singlethreaded: watchpoint after the second fork
PASS -> FAIL: gdb.threads/watchpoint-fork.exp: child: singlethreaded: finish
============================


*** Complete list of XFAILs for this builder ***

To obtain the list of XFAIL tests for this builder, go to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-s390x-m64/xfails/master/xfail;hb=15047dd>

You can also see a pretty-printed version of the list, with more information
about each XFAIL, by going to:

	<http://git.sergiodj.net/?p=gdb-xfails.git;a=blob;f=xfails/Fedora-s390x-m64/xfails/master/xfail.table;hb=15047dd>

Failures on Fedora-ppc64le-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64le-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64le-native-extended-gdbserver-m64/builds/3663>

Commit(s) tested:
	73ab01a07dfef77a9d845be2ef87754435eeffa1

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Make the intepreters output to all UIs

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 73ab01a07dfef77a9d845be2ef87754435eeffa1>

Failures on Fedora-ppc64be-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64be-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64be-native-gdbserver-m64/builds/3722>

Commit(s) tested:
	73ab01a07dfef77a9d845be2ef87754435eeffa1

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Make the intepreters output to all UIs

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 73ab01a07dfef77a9d845be2ef87754435eeffa1>

Failures on Fedora-ppc64be-native-extended-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64be-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64be-native-extended-gdbserver-m64/builds/3730>

Commit(s) tested:
	73ab01a07dfef77a9d845be2ef87754435eeffa1

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Make the intepreters output to all UIs

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 73ab01a07dfef77a9d845be2ef87754435eeffa1>

Failures on Fedora-ppc64le-native-gdbserver-m64, branch master

[sergiodj+buildbot]

Buildslave:
	fedora-ppc64le-1

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-ppc64le-native-gdbserver-m64/builds/3651>

Commit(s) tested:
	73ab01a07dfef77a9d845be2ef87754435eeffa1

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Make the intepreters output to all UIs

Testsuite log (gdb.sum and gdb.log) URL(s):
	<Error fetching commit ID for 73ab01a07dfef77a9d845be2ef87754435eeffa1>